All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sonal Santan <sonal.santan@xilinx.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Sonal Santan <sonal.santan@xilinx.com>,
	linux-fpga@vger.kernel.org, maxz@xilinx.com, lizhih@xilinx.com,
	michal.simek@xilinx.com, stefanos@xilinx.com,
	devicetree@vger.kernel.org, trix@redhat.com, mdf@kernel.org
Subject: Re: [PATCH V2 XRT Alveo 6/6] fpga: xrt: Kconfig and Makefile updates for XRT drivers
Date: Thu, 17 Dec 2020 22:55:00 +0800	[thread overview]
Message-ID: <202012172217.TVSv18Y2-lkp@intel.com> (raw)
In-Reply-To: <20201217075046.28553-7-sonals@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 10447 bytes --]

Hi Sonal,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.10 next-20201217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sonal-Santan/XRT-Alveo-driver-overview/20201217-160048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: i386-randconfig-r035-20201217 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/3096c9b7caac1243afabb56e8b6c6f752cd1a0de
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sonal-Santan/XRT-Alveo-driver-overview/20201217-160048
        git checkout 3096c9b7caac1243afabb56e8b6c6f752cd1a0de
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/fpga/xrt/lib/xrt-main.c: In function 'xrt_subdev_register_external_driver':
>> drivers/fpga/xrt/lib/xrt-main.c:158:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
     158 |  int result = 0;
         |      ^~~~~~
--
>> drivers/fpga/xrt/lib/../common/xrt-metadata.c:76:5: warning: no previous prototype for 'xrt_md_add_node' [-Wmissing-prototypes]
      76 | int xrt_md_add_node(struct device *dev, char *blob, int parent_offset,
         |     ^~~~~~~~~~~~~~~
--
   drivers/fpga/xrt/lib/subdevs/xrt-icap.c: In function 'icap_probe_chip':
>> drivers/fpga/xrt/lib/subdevs/xrt-icap.c:181:6: warning: variable 'w' set but not used [-Wunused-but-set-variable]
     181 |  u32 w;
         |      ^
--
>> drivers/fpga/xrt/lib/subdevs/xrt-clock.c:55:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
      55 | const static struct xmgmt_ocl_clockwiz {
         | ^~~~~
--
   drivers/fpga/xrt/lib/subdevs/xrt-ucs.c: In function 'xrt_ucs_event_cb':
>> drivers/fpga/xrt/lib/subdevs/xrt-ucs.c:77:19: warning: variable 'ucs' set but not used [-Wunused-but-set-variable]
      77 |  struct xrt_ucs  *ucs;
         |                   ^~~
--
>> drivers/fpga/xrt/lib/subdevs/xrt-calib.c:125:5: warning: no previous prototype for 'xrt_calib_remove' [-Wmissing-prototypes]
     125 | int xrt_calib_remove(struct platform_device *pdev)
         |     ^~~~~~~~~~~~~~~~
>> drivers/fpga/xrt/lib/subdevs/xrt-calib.c:141:5: warning: no previous prototype for 'xrt_calib_probe' [-Wmissing-prototypes]
     141 | int xrt_calib_probe(struct platform_device *pdev)
         |     ^~~~~~~~~~~~~~~
--
   In file included from include/linux/device.h:15,
                    from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14,
                    from drivers/fpga/xrt/mgmt/xmgmt-main.c:13:
   drivers/fpga/xrt/mgmt/xmgmt-main.c: In function 'ulp_image_write':
>> drivers/fpga/xrt/mgmt/../include/subdev.h:187:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |                    ^~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err'
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |  ^~~~~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT'
     189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args)
         |                                     ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:216:4: note: in expansion of macro 'xrt_err'
     216 |    xrt_err(xmm->pdev, "count is too small %ld", count);
         |    ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:216:45: note: format string is defined here
     216 |    xrt_err(xmm->pdev, "count is too small %ld", count);
         |                                           ~~^
         |                                             |
         |                                             long int
         |                                           %d
   In file included from include/linux/device.h:15,
                    from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14,
                    from drivers/fpga/xrt/mgmt/xmgmt-main.c:13:
   drivers/fpga/xrt/mgmt/xmgmt-main.c: In function 'is_valid_firmware':
>> drivers/fpga/xrt/mgmt/../include/subdev.h:187:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |                    ^~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err'
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |  ^~~~~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT'
     189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args)
         |                                     ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:3: note: in expansion of macro 'xrt_err'
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |   ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:42: note: format string is defined here
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |                                        ~~^
         |                                          |
         |                                          long int
         |                                        %d
   In file included from include/linux/device.h:15,
                    from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14,
                    from drivers/fpga/xrt/mgmt/xmgmt-main.c:13:
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:20: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |                    ^~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err'
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |  ^~~~~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT'
     189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args)
         |                                     ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:3: note: in expansion of macro 'xrt_err'
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |   ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:55: note: format string is defined here
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |                                                     ~~^
         |                                                       |
         |                                                       long int
         |                                                     %d
   In file included from drivers/fpga/xrt/mgmt/xmgmt-main.c:21:
   At top level:
   drivers/fpga/xrt/mgmt/../include/subdev/axigate.h:25:27: warning: 'xrt_axigate_epnames' defined but not used [-Wunused-const-variable=]
      25 | static const char * const xrt_axigate_epnames[] = {
         |                           ^~~~~~~~~~~~~~~~~~~
--
>> drivers/fpga/xrt/mgmt/../common/xrt-metadata.c:76:5: warning: no previous prototype for 'xrt_md_add_node' [-Wmissing-prototypes]
      76 | int xrt_md_add_node(struct device *dev, char *blob, int parent_offset,
         |     ^~~~~~~~~~~~~~~


vim +/result +158 drivers/fpga/xrt/lib/xrt-main.c

2039758de374ce7 Sonal Santan 2020-12-16  153  
2039758de374ce7 Sonal Santan 2020-12-16  154  int xrt_subdev_register_external_driver(enum xrt_subdev_id id,
2039758de374ce7 Sonal Santan 2020-12-16  155  	struct platform_driver *drv, struct xrt_subdev_endpoints *eps)
2039758de374ce7 Sonal Santan 2020-12-16  156  {
2039758de374ce7 Sonal Santan 2020-12-16  157  	int i;
2039758de374ce7 Sonal Santan 2020-12-16 @158  	int result = 0;
2039758de374ce7 Sonal Santan 2020-12-16  159  
2039758de374ce7 Sonal Santan 2020-12-16  160  	mutex_lock(&xrt_class_lock);
2039758de374ce7 Sonal Santan 2020-12-16  161  	for (i = 0; i < ARRAY_SIZE(xrt_drv_maps); i++) {
2039758de374ce7 Sonal Santan 2020-12-16  162  		struct xrt_drv_map *map = &xrt_drv_maps[i];
2039758de374ce7 Sonal Santan 2020-12-16  163  
2039758de374ce7 Sonal Santan 2020-12-16  164  		if (map->id != id)
2039758de374ce7 Sonal Santan 2020-12-16  165  			continue;
2039758de374ce7 Sonal Santan 2020-12-16  166  		if (map->drv) {
2039758de374ce7 Sonal Santan 2020-12-16  167  			result = -EEXIST;
2039758de374ce7 Sonal Santan 2020-12-16  168  			pr_err("Id %d already has a registered driver, 0x%p\n",
2039758de374ce7 Sonal Santan 2020-12-16  169  				id, map->drv);
2039758de374ce7 Sonal Santan 2020-12-16  170  			break;
2039758de374ce7 Sonal Santan 2020-12-16  171  		}
2039758de374ce7 Sonal Santan 2020-12-16  172  		map->drv = drv;
2039758de374ce7 Sonal Santan 2020-12-16  173  		BUG_ON(map->eps);
2039758de374ce7 Sonal Santan 2020-12-16  174  		map->eps = eps;
2039758de374ce7 Sonal Santan 2020-12-16  175  		xrt_drv_register_driver(id);
2039758de374ce7 Sonal Santan 2020-12-16  176  	}
2039758de374ce7 Sonal Santan 2020-12-16  177  	mutex_unlock(&xrt_class_lock);
2039758de374ce7 Sonal Santan 2020-12-16  178  	return 0;
2039758de374ce7 Sonal Santan 2020-12-16  179  }
2039758de374ce7 Sonal Santan 2020-12-16  180  EXPORT_SYMBOL_GPL(xrt_subdev_register_external_driver);
2039758de374ce7 Sonal Santan 2020-12-16  181  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32814 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH V2 XRT Alveo 6/6] fpga: xrt: Kconfig and Makefile updates for XRT drivers
Date: Thu, 17 Dec 2020 22:55:00 +0800	[thread overview]
Message-ID: <202012172217.TVSv18Y2-lkp@intel.com> (raw)
In-Reply-To: <20201217075046.28553-7-sonals@xilinx.com>

[-- Attachment #1: Type: text/plain, Size: 10626 bytes --]

Hi Sonal,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.10 next-20201217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sonal-Santan/XRT-Alveo-driver-overview/20201217-160048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: i386-randconfig-r035-20201217 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/3096c9b7caac1243afabb56e8b6c6f752cd1a0de
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sonal-Santan/XRT-Alveo-driver-overview/20201217-160048
        git checkout 3096c9b7caac1243afabb56e8b6c6f752cd1a0de
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/fpga/xrt/lib/xrt-main.c: In function 'xrt_subdev_register_external_driver':
>> drivers/fpga/xrt/lib/xrt-main.c:158:6: warning: variable 'result' set but not used [-Wunused-but-set-variable]
     158 |  int result = 0;
         |      ^~~~~~
--
>> drivers/fpga/xrt/lib/../common/xrt-metadata.c:76:5: warning: no previous prototype for 'xrt_md_add_node' [-Wmissing-prototypes]
      76 | int xrt_md_add_node(struct device *dev, char *blob, int parent_offset,
         |     ^~~~~~~~~~~~~~~
--
   drivers/fpga/xrt/lib/subdevs/xrt-icap.c: In function 'icap_probe_chip':
>> drivers/fpga/xrt/lib/subdevs/xrt-icap.c:181:6: warning: variable 'w' set but not used [-Wunused-but-set-variable]
     181 |  u32 w;
         |      ^
--
>> drivers/fpga/xrt/lib/subdevs/xrt-clock.c:55:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
      55 | const static struct xmgmt_ocl_clockwiz {
         | ^~~~~
--
   drivers/fpga/xrt/lib/subdevs/xrt-ucs.c: In function 'xrt_ucs_event_cb':
>> drivers/fpga/xrt/lib/subdevs/xrt-ucs.c:77:19: warning: variable 'ucs' set but not used [-Wunused-but-set-variable]
      77 |  struct xrt_ucs  *ucs;
         |                   ^~~
--
>> drivers/fpga/xrt/lib/subdevs/xrt-calib.c:125:5: warning: no previous prototype for 'xrt_calib_remove' [-Wmissing-prototypes]
     125 | int xrt_calib_remove(struct platform_device *pdev)
         |     ^~~~~~~~~~~~~~~~
>> drivers/fpga/xrt/lib/subdevs/xrt-calib.c:141:5: warning: no previous prototype for 'xrt_calib_probe' [-Wmissing-prototypes]
     141 | int xrt_calib_probe(struct platform_device *pdev)
         |     ^~~~~~~~~~~~~~~
--
   In file included from include/linux/device.h:15,
                    from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14,
                    from drivers/fpga/xrt/mgmt/xmgmt-main.c:13:
   drivers/fpga/xrt/mgmt/xmgmt-main.c: In function 'ulp_image_write':
>> drivers/fpga/xrt/mgmt/../include/subdev.h:187:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |                    ^~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err'
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |  ^~~~~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT'
     189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args)
         |                                     ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:216:4: note: in expansion of macro 'xrt_err'
     216 |    xrt_err(xmm->pdev, "count is too small %ld", count);
         |    ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:216:45: note: format string is defined here
     216 |    xrt_err(xmm->pdev, "count is too small %ld", count);
         |                                           ~~^
         |                                             |
         |                                             long int
         |                                           %d
   In file included from include/linux/device.h:15,
                    from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14,
                    from drivers/fpga/xrt/mgmt/xmgmt-main.c:13:
   drivers/fpga/xrt/mgmt/xmgmt-main.c: In function 'is_valid_firmware':
>> drivers/fpga/xrt/mgmt/../include/subdev.h:187:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |                    ^~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err'
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |  ^~~~~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT'
     189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args)
         |                                     ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:3: note: in expansion of macro 'xrt_err'
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |   ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:42: note: format string is defined here
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |                                        ~~^
         |                                          |
         |                                          long int
         |                                        %d
   In file included from include/linux/device.h:15,
                    from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14,
                    from drivers/fpga/xrt/mgmt/xmgmt-main.c:13:
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:20: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |                    ^~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err'
     187 |  prt_fn(DEV(pdev), "%s %s: "fmt,   \
         |  ^~~~~~
   drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT'
     189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args)
         |                                     ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:3: note: in expansion of macro 'xrt_err'
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |   ^~~~~~~
   drivers/fpga/xrt/mgmt/xmgmt-main.c:370:55: note: format string is defined here
     370 |   xrt_err(pdev, "truncated fw, length: %ld, expect: %ld",
         |                                                     ~~^
         |                                                       |
         |                                                       long int
         |                                                     %d
   In file included from drivers/fpga/xrt/mgmt/xmgmt-main.c:21:
   At top level:
   drivers/fpga/xrt/mgmt/../include/subdev/axigate.h:25:27: warning: 'xrt_axigate_epnames' defined but not used [-Wunused-const-variable=]
      25 | static const char * const xrt_axigate_epnames[] = {
         |                           ^~~~~~~~~~~~~~~~~~~
--
>> drivers/fpga/xrt/mgmt/../common/xrt-metadata.c:76:5: warning: no previous prototype for 'xrt_md_add_node' [-Wmissing-prototypes]
      76 | int xrt_md_add_node(struct device *dev, char *blob, int parent_offset,
         |     ^~~~~~~~~~~~~~~


vim +/result +158 drivers/fpga/xrt/lib/xrt-main.c

2039758de374ce7 Sonal Santan 2020-12-16  153  
2039758de374ce7 Sonal Santan 2020-12-16  154  int xrt_subdev_register_external_driver(enum xrt_subdev_id id,
2039758de374ce7 Sonal Santan 2020-12-16  155  	struct platform_driver *drv, struct xrt_subdev_endpoints *eps)
2039758de374ce7 Sonal Santan 2020-12-16  156  {
2039758de374ce7 Sonal Santan 2020-12-16  157  	int i;
2039758de374ce7 Sonal Santan 2020-12-16 @158  	int result = 0;
2039758de374ce7 Sonal Santan 2020-12-16  159  
2039758de374ce7 Sonal Santan 2020-12-16  160  	mutex_lock(&xrt_class_lock);
2039758de374ce7 Sonal Santan 2020-12-16  161  	for (i = 0; i < ARRAY_SIZE(xrt_drv_maps); i++) {
2039758de374ce7 Sonal Santan 2020-12-16  162  		struct xrt_drv_map *map = &xrt_drv_maps[i];
2039758de374ce7 Sonal Santan 2020-12-16  163  
2039758de374ce7 Sonal Santan 2020-12-16  164  		if (map->id != id)
2039758de374ce7 Sonal Santan 2020-12-16  165  			continue;
2039758de374ce7 Sonal Santan 2020-12-16  166  		if (map->drv) {
2039758de374ce7 Sonal Santan 2020-12-16  167  			result = -EEXIST;
2039758de374ce7 Sonal Santan 2020-12-16  168  			pr_err("Id %d already has a registered driver, 0x%p\n",
2039758de374ce7 Sonal Santan 2020-12-16  169  				id, map->drv);
2039758de374ce7 Sonal Santan 2020-12-16  170  			break;
2039758de374ce7 Sonal Santan 2020-12-16  171  		}
2039758de374ce7 Sonal Santan 2020-12-16  172  		map->drv = drv;
2039758de374ce7 Sonal Santan 2020-12-16  173  		BUG_ON(map->eps);
2039758de374ce7 Sonal Santan 2020-12-16  174  		map->eps = eps;
2039758de374ce7 Sonal Santan 2020-12-16  175  		xrt_drv_register_driver(id);
2039758de374ce7 Sonal Santan 2020-12-16  176  	}
2039758de374ce7 Sonal Santan 2020-12-16  177  	mutex_unlock(&xrt_class_lock);
2039758de374ce7 Sonal Santan 2020-12-16  178  	return 0;
2039758de374ce7 Sonal Santan 2020-12-16  179  }
2039758de374ce7 Sonal Santan 2020-12-16  180  EXPORT_SYMBOL_GPL(xrt_subdev_register_external_driver);
2039758de374ce7 Sonal Santan 2020-12-16  181  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32814 bytes --]

  reply	other threads:[~2020-12-17 14:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  7:50 [PATCH V2 XRT Alveo 0/6] XRT Alveo driver overview Sonal Santan
2020-12-17  7:50 ` [PATCH V2 XRT Alveo 1/6] Documentation: fpga: Add a document describing XRT Alveo drivers Sonal Santan
2020-12-17  7:50 ` [PATCH V2 XRT Alveo 2/6] fpga: xrt: infrastructure support for xmgmt driver Sonal Santan
2020-12-21  6:41   ` kernel test robot
2020-12-21  6:41     ` kernel test robot
2020-12-17  7:50 ` [PATCH V2 XRT Alveo 3/6] fpga: xrt: core infrastructure for xrt-lib module Sonal Santan
2020-12-17  7:50 ` [PATCH V2 XRT Alveo 4/6] fpga: xrt: XRT Alveo management physical function driver Sonal Santan
2020-12-21  9:03   ` kernel test robot
2020-12-21  9:03     ` kernel test robot
2020-12-17  7:50 ` [PATCH V2 XRT Alveo 5/6] fpga: xrt: platform drivers for subsystems in shell partition Sonal Santan
2020-12-17  7:50 ` [PATCH V2 XRT Alveo 6/6] fpga: xrt: Kconfig and Makefile updates for XRT drivers Sonal Santan
2020-12-17 14:55   ` kernel test robot [this message]
2020-12-17 14:55     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202012172217.TVSv18Y2-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhih@xilinx.com \
    --cc=maxz@xilinx.com \
    --cc=mdf@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=sonal.santan@xilinx.com \
    --cc=stefanos@xilinx.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.