All of lore.kernel.org
 help / color / mirror / Atom feed
From: Erwan Le Ray <erwan.leray@foss.st.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, Rob Herring <robh+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: <linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Erwan Le Ray <erwan.leray@foss.st.com>,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	Valentin Caron <valentin.caron@foss.st.com>
Subject: [PATCH 8/8] serial: stm32: update transmission complete error message in shutdown
Date: Fri, 18 Dec 2020 20:00:19 +0100	[thread overview]
Message-ID: <20201218190020.1572-9-erwan.leray@foss.st.com> (raw)
In-Reply-To: <20201218190020.1572-1-erwan.leray@foss.st.com>

The transmission complete error message provides the status of the
ISR_USART_TC bit. This bit, when set, indicates that the transmission
has not been completed.
The bit status indication is not a very understandable information.
The error message sent on console should indicate that the transmission is
not complete, instead of providing USART_TC bit status.
Update the error message and add a comment for better understanding.

Signed-off-by: Erwan Le Ray <erwan.leray@foss.st.com>

diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 9d73f6976586..6a9a5ef5f5ba 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -687,8 +687,9 @@ static void stm32_usart_shutdown(struct uart_port *port)
 					 isr, (isr & USART_SR_TC),
 					 10, 100000);
 
+	/* Send the TC error message only when ISR_TC is not set */
 	if (ret)
-		dev_err(port->dev, "transmission complete not set\n");
+		dev_err(port->dev, "Transmission is not complete\n");
 
 	stm32_usart_clr_bits(port, ofs->cr1, val);
 
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Erwan Le Ray <erwan.leray@foss.st.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, Rob Herring <robh+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: devicetree@vger.kernel.org,
	Valentin Caron <valentin.caron@foss.st.com>,
	Erwan Le Ray <erwan.leray@foss.st.com>,
	linux-kernel@vger.kernel.org,
	Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
	linux-serial@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] serial: stm32: update transmission complete error message in shutdown
Date: Fri, 18 Dec 2020 20:00:19 +0100	[thread overview]
Message-ID: <20201218190020.1572-9-erwan.leray@foss.st.com> (raw)
In-Reply-To: <20201218190020.1572-1-erwan.leray@foss.st.com>

The transmission complete error message provides the status of the
ISR_USART_TC bit. This bit, when set, indicates that the transmission
has not been completed.
The bit status indication is not a very understandable information.
The error message sent on console should indicate that the transmission is
not complete, instead of providing USART_TC bit status.
Update the error message and add a comment for better understanding.

Signed-off-by: Erwan Le Ray <erwan.leray@foss.st.com>

diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 9d73f6976586..6a9a5ef5f5ba 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -687,8 +687,9 @@ static void stm32_usart_shutdown(struct uart_port *port)
 					 isr, (isr & USART_SR_TC),
 					 10, 100000);
 
+	/* Send the TC error message only when ISR_TC is not set */
 	if (ret)
-		dev_err(port->dev, "transmission complete not set\n");
+		dev_err(port->dev, "Transmission is not complete\n");
 
 	stm32_usart_clr_bits(port, ofs->cr1, val);
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-12-18 19:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 19:00 [PATCH 0/7] STM32 uart cleanup and improvements Erwan Le Ray
2020-12-18 19:00 ` Erwan Le Ray
2020-12-18 19:00 ` [PATCH 1/8] serial: stm32: fix -Wall W=1 compilation warnings Erwan Le Ray
2020-12-18 19:00   ` Erwan Le Ray
2020-12-18 19:00 ` [PATCH 2/8] serial: stm32: fix code cleaning warnings and checks Erwan Le Ray
2020-12-18 19:00   ` Erwan Le Ray
2020-12-18 19:00 ` [PATCH 3/8] serial: stm32: add "_usart" prefix in functions name Erwan Le Ray
2020-12-18 19:00   ` Erwan Le Ray
2020-12-18 19:00 ` [PATCH 4/8] serial: stm32: add author Erwan Le Ray
2020-12-18 19:00   ` Erwan Le Ray
2020-12-18 19:00 ` [PATCH 5/8] dt-bindings: serial: stm32: update rts-gpios and cts-gpios Erwan Le Ray
2020-12-18 19:00   ` Erwan Le Ray
2020-12-31 20:37   ` Rob Herring
2020-12-31 20:37     ` Rob Herring
2020-12-18 19:00 ` [PATCH 6/8] serial: stm32: update conflicting RTS/CTS config comment Erwan Le Ray
2020-12-18 19:00   ` Erwan Le Ray
2020-12-18 19:00 ` [PATCH 7/8] serial: stm32: clean probe and remove port deinit Erwan Le Ray
2020-12-18 19:00   ` Erwan Le Ray
2020-12-18 19:00 ` Erwan Le Ray [this message]
2020-12-18 19:00   ` [PATCH 8/8] serial: stm32: update transmission complete error message in shutdown Erwan Le Ray
2020-12-28 15:17 ` [PATCH 0/7] STM32 uart cleanup and improvements Greg Kroah-Hartman
2020-12-28 15:17   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201218190020.1572-9-erwan.leray@foss.st.com \
    --to=erwan.leray@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=valentin.caron@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.