All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Alice Guo (OSS)" <alice.guo@oss.nxp.com>
Cc: devicetree@vger.kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 4/4] soc: imx8m: change to use platform driver
Date: Sat, 19 Dec 2020 13:18:29 +0100	[thread overview]
Message-ID: <20201219121829.GB13886@kozik-lap> (raw)
In-Reply-To: <20201218083726.16427-4-alice.guo@oss.nxp.com>

On Fri, Dec 18, 2020 at 04:37:26PM +0800, Alice Guo (OSS) wrote:
> From: Alice Guo <alice.guo@nxp.com>
> 
> Directly reading ocotp register depends on that bootloader enables ocotp
> clk, which is not always effective, so change to use nvmem API. Using
> nvmem API requires to support driver defer probe and thus change
> soc-imx8m.c to use platform driver.
> 
> The other reason is that directly reading ocotp register causes kexec
> kernel hang because the 1st kernel running will disable unused clks
> after kernel boots up, and then ocotp clk will be disabled even if
> bootloader enables it. When kexec kernel, ocotp clk needs to be enabled
> before reading ocotp registers, and nvmem API with platform driver
> supported can accomplish this.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
> Changes for v8:
>  - none
> Changes for v7:
>  - solve the problem "drivers/soc/imx/soc-imx8m.c:174:34: warning:
>    unused variable"

There was a reviewed-by part of changelog. The tag was in your commit.
I am now confused, as changes for v8 say "none"... but shall I trust it?

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Alice Guo (OSS)" <alice.guo@oss.nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH v8 4/4] soc: imx8m: change to use platform driver
Date: Sat, 19 Dec 2020 13:18:29 +0100	[thread overview]
Message-ID: <20201219121829.GB13886@kozik-lap> (raw)
In-Reply-To: <20201218083726.16427-4-alice.guo@oss.nxp.com>

On Fri, Dec 18, 2020 at 04:37:26PM +0800, Alice Guo (OSS) wrote:
> From: Alice Guo <alice.guo@nxp.com>
> 
> Directly reading ocotp register depends on that bootloader enables ocotp
> clk, which is not always effective, so change to use nvmem API. Using
> nvmem API requires to support driver defer probe and thus change
> soc-imx8m.c to use platform driver.
> 
> The other reason is that directly reading ocotp register causes kexec
> kernel hang because the 1st kernel running will disable unused clks
> after kernel boots up, and then ocotp clk will be disabled even if
> bootloader enables it. When kexec kernel, ocotp clk needs to be enabled
> before reading ocotp registers, and nvmem API with platform driver
> supported can accomplish this.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
> Changes for v8:
>  - none
> Changes for v7:
>  - solve the problem "drivers/soc/imx/soc-imx8m.c:174:34: warning:
>    unused variable"

There was a reviewed-by part of changelog. The tag was in your commit.
I am now confused, as changes for v8 say "none"... but shall I trust it?

Best regards,
Krzysztof

  reply	other threads:[~2020-12-19 12:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18  8:37 [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo (OSS)
2020-12-18  8:37 ` Alice Guo (OSS)
2020-12-18  8:37 ` [PATCH v8 2/4] arm64: dts: imx8m: add SoC ID compatible Alice Guo (OSS)
2020-12-18  8:37   ` Alice Guo (OSS)
2020-12-18  8:37 ` [PATCH v8 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Alice Guo (OSS)
2020-12-18  8:37   ` Alice Guo (OSS)
2020-12-19 12:16   ` Krzysztof Kozlowski
2020-12-19 12:16     ` Krzysztof Kozlowski
2020-12-21  3:10     ` Alice Guo (OSS)
2020-12-21  3:10       ` Alice Guo (OSS)
2020-12-21  7:56       ` Krzysztof Kozlowski
2020-12-21  7:56         ` Krzysztof Kozlowski
2020-12-18  8:37 ` [PATCH v8 4/4] soc: imx8m: change to use platform driver Alice Guo (OSS)
2020-12-18  8:37   ` Alice Guo (OSS)
2020-12-19 12:18   ` Krzysztof Kozlowski [this message]
2020-12-19 12:18     ` Krzysztof Kozlowski
2020-12-21  2:36     ` Alice Guo (OSS)
2020-12-21  2:36       ` Alice Guo (OSS)
2020-12-18  8:52 ` [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski
2020-12-18  8:52   ` Krzysztof Kozlowski
2020-12-18  9:05   ` Alice Guo (OSS)
2020-12-18  9:05     ` Alice Guo (OSS)
2020-12-18  9:36     ` Krzysztof Kozlowski
2020-12-18  9:36       ` Krzysztof Kozlowski
2020-12-18 10:14       ` Alice Guo (OSS)
2020-12-18 10:14         ` Alice Guo (OSS)
2020-12-18 13:59         ` Rob Herring
2020-12-18 13:59           ` Rob Herring
2020-12-21  9:20           ` Alice Guo (OSS)
2020-12-21  9:20             ` Alice Guo (OSS)
2020-12-21 20:29             ` Rob Herring
2020-12-21 20:29               ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201219121829.GB13886@kozik-lap \
    --to=krzk@kernel.org \
    --cc=alice.guo@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.