All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	Angus Ainslie <angus@akkea.ca>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Li Yang <leoyang.li@nxp.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Vinod Koul <vkoul@kernel.org>, Anson Huang <Anson.Huang@nxp.com>,
	Michael Walle <michael@walle.cc>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators
Date: Sat, 19 Dec 2020 13:25:19 +0100	[thread overview]
Message-ID: <20201219122519.GG13886@kozik-lap> (raw)
In-Reply-To: <a930ccca2f9a5dc49f24c46c3f4280c4de960f9d.1608216796.git.agx@sigxcpu.org>

On Thu, Dec 17, 2020 at 04:13:13PM +0100, Guido Günther wrote:
> BUCK3 needs a regulator-enable-ramp-delay since otherwise the board
> freezes on etnaviv probe. With this pgc_gpu suspends and resumes as
> expected. This must have been always broken since gpcv2 support was
> enabled.
> 
> We also enable all the regulators needed for Deep Sleep Mode (DSM) as
> always-on:
> 
> - VDD_SOC supplied by BUCK1
> - VDDA_1P8 supplied by BUCK7
> - VDDA_0P9 supplied by LDO4
> - VDDA_DRAM supplied by LDO3
> - NVCC_DRAM supplied by BUCK8
> - VDD_DRAM supplied by BUCK5
> 
> Finally LDO5 and LDO6 provide VDD_PHY_1V8 and VDD_PHY_0V9 used by the
> SOCs MIPI, HDMI and USB IP cores. While we would in theory be able to
> turn these off (and I've tested that or LDO6 and mipi with USB disabled)
> it is of little practical use atm since USB doesn't runtime suspend so
> let's revisit this at a later point.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  .../boot/dts/freescale/imx8mq-librem5-devkit.dts      | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Will Deacon <will@kernel.org>, Anson Huang <Anson.Huang@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Angus Ainslie <angus@akkea.ca>, Michael Walle <michael@walle.cc>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Martin Kepplinger <martink@posteo.de>,
	Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators
Date: Sat, 19 Dec 2020 13:25:19 +0100	[thread overview]
Message-ID: <20201219122519.GG13886@kozik-lap> (raw)
In-Reply-To: <a930ccca2f9a5dc49f24c46c3f4280c4de960f9d.1608216796.git.agx@sigxcpu.org>

On Thu, Dec 17, 2020 at 04:13:13PM +0100, Guido Günther wrote:
> BUCK3 needs a regulator-enable-ramp-delay since otherwise the board
> freezes on etnaviv probe. With this pgc_gpu suspends and resumes as
> expected. This must have been always broken since gpcv2 support was
> enabled.
> 
> We also enable all the regulators needed for Deep Sleep Mode (DSM) as
> always-on:
> 
> - VDD_SOC supplied by BUCK1
> - VDDA_1P8 supplied by BUCK7
> - VDDA_0P9 supplied by LDO4
> - VDDA_DRAM supplied by LDO3
> - NVCC_DRAM supplied by BUCK8
> - VDD_DRAM supplied by BUCK5
> 
> Finally LDO5 and LDO6 provide VDD_PHY_1V8 and VDD_PHY_0V9 used by the
> SOCs MIPI, HDMI and USB IP cores. While we would in theory be able to
> turn these off (and I've tested that or LDO6 and mipi with USB disabled)
> it is of little practical use atm since USB doesn't runtime suspend so
> let's revisit this at a later point.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  .../boot/dts/freescale/imx8mq-librem5-devkit.dts      | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-19 12:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 15:13 [PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit Guido Günther
2020-12-17 15:13 ` Guido Günther
2020-12-17 15:13 ` [PATCH v2 1/4] arm64: defconfig: Enable Librem 5 devkit components Guido Günther
2020-12-17 15:13   ` Guido Günther
2020-12-19 12:23   ` Krzysztof Kozlowski
2020-12-19 12:23     ` Krzysztof Kozlowski
2020-12-17 15:13 ` [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators Guido Günther
2020-12-17 15:13   ` Guido Günther
2020-12-19 12:25   ` Krzysztof Kozlowski [this message]
2020-12-19 12:25     ` Krzysztof Kozlowski
2021-01-10 12:24   ` Shawn Guo
2021-01-10 12:24     ` Shawn Guo
2020-12-17 15:13 ` [PATCH v2 3/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc Guido Günther
2020-12-17 15:13   ` Guido Günther
2020-12-19 12:25   ` Krzysztof Kozlowski
2020-12-19 12:25     ` Krzysztof Kozlowski
2021-01-10 12:25   ` Shawn Guo
2021-01-10 12:25     ` Shawn Guo
2020-12-17 15:13 ` [PATCH v2 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings Guido Günther
2020-12-17 15:13   ` Guido Günther
2020-12-19 12:24   ` Krzysztof Kozlowski
2020-12-19 12:24     ` Krzysztof Kozlowski
2021-01-10 12:25   ` Shawn Guo
2021-01-10 12:25     ` Shawn Guo
2021-01-10 12:26 ` [PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit Shawn Guo
2021-01-10 12:26   ` Shawn Guo
2021-01-10 15:06   ` Guido Günther
2021-01-10 15:06     ` Guido Günther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201219122519.GG13886@kozik-lap \
    --to=krzk@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=agx@sigxcpu.org \
    --cc=angus@akkea.ca \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=kernel@pengutronix.de \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    --cc=michael@walle.cc \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.