From: Rob Herring <robh@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>,
mark.rutland@arm.com, nicolas.ferre@microchip.com,
ludovic.desroches@microchip.com, sre@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: atmel-sysreg: add microchip,sama7g5-shdwc
Date: Mon, 21 Dec 2020 12:37:14 -0700 [thread overview]
Message-ID: <20201221193714.GA420008@robh.at.kernel.org> (raw)
In-Reply-To: <20201216134100.GG2814589@piout.net>
On Wed, Dec 16, 2020 at 02:41:00PM +0100, Alexandre Belloni wrote:
> On 16/12/2020 14:57:32+0200, Claudiu Beznea wrote:
> > Add compatible for Microchip SAMA7G5's shutdown controller.
> >
> > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> > ---
> > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> I'm pretty sure the first comment you'll get is to convert this file to
> yaml ;)
I certainly wouldn't object, but just for a new compatible not requiring
that (yet).
> > diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > index 62cd4e89817c..7990358ac06e 100644
> > --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > @@ -91,7 +91,8 @@ SHDWC SAMA5D2-Compatible Shutdown Controller
> > 1) shdwc node
> >
> > required properties:
> > -- compatible: should be "atmel,sama5d2-shdwc" or "microchip,sam9x60-shdwc".
> > +- compatible: should be "atmel,sama5d2-shdwc", "microchip,sam9x60-shdwc" or
> > + "microchip,sama7g5-shdwc"
> > - reg: should contain registers location and length
> > - clocks: phandle to input clock.
> > - #address-cells: should be one. The cell is the wake-up input index.
> > @@ -103,7 +104,7 @@ optional properties:
> > microseconds. It's usually a board-related property.
> > - atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up.
> >
> > -optional microchip,sam9x60-shdwc properties:
> > +optional microchip,sam9x60-shdwc or microchip,sama7g5-shdwc properties:
> > - atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up.
> >
> > The node contains child nodes for each wake-up input that the platform uses.
> > --
> > 2.7.4
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
sre@kernel.org, ludovic.desroches@microchip.com,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: atmel-sysreg: add microchip,sama7g5-shdwc
Date: Mon, 21 Dec 2020 12:37:14 -0700 [thread overview]
Message-ID: <20201221193714.GA420008@robh.at.kernel.org> (raw)
In-Reply-To: <20201216134100.GG2814589@piout.net>
On Wed, Dec 16, 2020 at 02:41:00PM +0100, Alexandre Belloni wrote:
> On 16/12/2020 14:57:32+0200, Claudiu Beznea wrote:
> > Add compatible for Microchip SAMA7G5's shutdown controller.
> >
> > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> > ---
> > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> I'm pretty sure the first comment you'll get is to convert this file to
> yaml ;)
I certainly wouldn't object, but just for a new compatible not requiring
that (yet).
> > diff --git a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > index 62cd4e89817c..7990358ac06e 100644
> > --- a/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > +++ b/Documentation/devicetree/bindings/arm/atmel-sysregs.txt
> > @@ -91,7 +91,8 @@ SHDWC SAMA5D2-Compatible Shutdown Controller
> > 1) shdwc node
> >
> > required properties:
> > -- compatible: should be "atmel,sama5d2-shdwc" or "microchip,sam9x60-shdwc".
> > +- compatible: should be "atmel,sama5d2-shdwc", "microchip,sam9x60-shdwc" or
> > + "microchip,sama7g5-shdwc"
> > - reg: should contain registers location and length
> > - clocks: phandle to input clock.
> > - #address-cells: should be one. The cell is the wake-up input index.
> > @@ -103,7 +104,7 @@ optional properties:
> > microseconds. It's usually a board-related property.
> > - atmel,wakeup-rtc-timer: boolean to enable Real-Time Clock wake-up.
> >
> > -optional microchip,sam9x60-shdwc properties:
> > +optional microchip,sam9x60-shdwc or microchip,sama7g5-shdwc properties:
> > - atmel,wakeup-rtt-timer: boolean to enable Real-time Timer Wake-up.
> >
> > The node contains child nodes for each wake-up input that the platform uses.
> > --
> > 2.7.4
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-21 19:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 12:57 [PATCH 0/3] power: reset: at91-sama5d2_shdwc: add support for SAMA7G5 Claudiu Beznea
2020-12-16 12:57 ` Claudiu Beznea
2020-12-16 12:57 ` [PATCH 1/3] power: reset: at91-sama5d2_shdwc: fix wkupdbc mask Claudiu Beznea
2020-12-16 12:57 ` Claudiu Beznea
2020-12-16 13:40 ` Alexandre Belloni
2020-12-16 13:40 ` Alexandre Belloni
2020-12-16 12:57 ` [PATCH 2/3] dt-bindings: atmel-sysreg: add microchip,sama7g5-shdwc Claudiu Beznea
2020-12-16 12:57 ` Claudiu Beznea
2020-12-16 13:41 ` Alexandre Belloni
2020-12-16 13:41 ` Alexandre Belloni
2020-12-21 19:37 ` Rob Herring [this message]
2020-12-21 19:37 ` Rob Herring
2020-12-21 19:37 ` Rob Herring
2020-12-21 19:37 ` Rob Herring
2020-12-16 12:57 ` [PATCH 3/3] power: reset: at91-sama5d2_shdwc: add support for sama7g5 Claudiu Beznea
2020-12-16 12:57 ` Claudiu Beznea
2020-12-16 13:45 ` Alexandre Belloni
2020-12-16 13:45 ` Alexandre Belloni
2020-12-16 14:11 ` Claudiu.Beznea
2020-12-16 14:11 ` Claudiu.Beznea
2020-12-16 14:12 ` Claudiu.Beznea
2020-12-16 14:12 ` Claudiu.Beznea
2021-01-16 13:58 ` [PATCH 0/3] power: reset: at91-sama5d2_shdwc: add support for SAMA7G5 Sebastian Reichel
2021-01-16 13:58 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221193714.GA420008@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.