From: Christoph Hellwig <hch@infradead.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, Tomasz Figa <tfiga@google.com>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
chao.hao@mediatek.com, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
kernel-team@android.com, Greg Kroah-Hartman <gregkh@google.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/7] iommu: Move iotlb_sync_map out from __iommu_map
Date: Wed, 23 Dec 2020 08:51:53 +0000 [thread overview]
Message-ID: <20201223085153.GA30643@infradead.org> (raw)
In-Reply-To: <20201216103607.23050-2-yong.wu@mediatek.com>
On Wed, Dec 16, 2020 at 06:36:01PM +0800, Yong Wu wrote:
> In the end of __iommu_map, It alway call iotlb_sync_map.
> This patch moves iotlb_sync_map out from __iommu_map since it is
> unnecessary to call this for each sg segment especially iotlb_sync_map
> is flush tlb all currently.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
What about adding a little helper that does the NULL check and method
call instead of duplicating it all over?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, Tomasz Figa <tfiga@google.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
chao.hao@mediatek.com, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
kernel-team@android.com, Greg Kroah-Hartman <gregkh@google.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/7] iommu: Move iotlb_sync_map out from __iommu_map
Date: Wed, 23 Dec 2020 08:51:53 +0000 [thread overview]
Message-ID: <20201223085153.GA30643@infradead.org> (raw)
In-Reply-To: <20201216103607.23050-2-yong.wu@mediatek.com>
On Wed, Dec 16, 2020 at 06:36:01PM +0800, Yong Wu wrote:
> In the end of __iommu_map, It alway call iotlb_sync_map.
> This patch moves iotlb_sync_map out from __iommu_map since it is
> unnecessary to call this for each sg segment especially iotlb_sync_map
> is flush tlb all currently.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
What about adding a little helper that does the NULL check and method
call instead of duplicating it all over?
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, Tomasz Figa <tfiga@google.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
chao.hao@mediatek.com, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
kernel-team@android.com, Greg Kroah-Hartman <gregkh@google.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/7] iommu: Move iotlb_sync_map out from __iommu_map
Date: Wed, 23 Dec 2020 08:51:53 +0000 [thread overview]
Message-ID: <20201223085153.GA30643@infradead.org> (raw)
In-Reply-To: <20201216103607.23050-2-yong.wu@mediatek.com>
On Wed, Dec 16, 2020 at 06:36:01PM +0800, Yong Wu wrote:
> In the end of __iommu_map, It alway call iotlb_sync_map.
> This patch moves iotlb_sync_map out from __iommu_map since it is
> unnecessary to call this for each sg segment especially iotlb_sync_map
> is flush tlb all currently.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
What about adding a little helper that does the NULL check and method
call instead of duplicating it all over?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
youlin.pei@mediatek.com, anan.sun@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, chao.hao@mediatek.com,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Tomasz Figa <tfiga@google.com>,
iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Greg Kroah-Hartman <gregkh@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/7] iommu: Move iotlb_sync_map out from __iommu_map
Date: Wed, 23 Dec 2020 08:51:53 +0000 [thread overview]
Message-ID: <20201223085153.GA30643@infradead.org> (raw)
In-Reply-To: <20201216103607.23050-2-yong.wu@mediatek.com>
On Wed, Dec 16, 2020 at 06:36:01PM +0800, Yong Wu wrote:
> In the end of __iommu_map, It alway call iotlb_sync_map.
> This patch moves iotlb_sync_map out from __iommu_map since it is
> unnecessary to call this for each sg segment especially iotlb_sync_map
> is flush tlb all currently.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
What about adding a little helper that does the NULL check and method
call instead of duplicating it all over?
next prev parent reply other threads:[~2020-12-23 8:52 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 10:36 [PATCH v3 0/7] MediaTek IOMMU improve tlb flush performance in map/unmap Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` [PATCH v3 1/7] iommu: Move iotlb_sync_map out from __iommu_map Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-23 8:51 ` Christoph Hellwig [this message]
2020-12-23 8:51 ` Christoph Hellwig
2020-12-23 8:51 ` Christoph Hellwig
2020-12-23 8:51 ` Christoph Hellwig
2020-12-24 11:27 ` Yong Wu
2020-12-24 11:27 ` Yong Wu
2020-12-24 11:27 ` Yong Wu
2020-12-24 11:27 ` Yong Wu
2020-12-16 10:36 ` [PATCH v3 2/7] iommu: Add iova and size as parameters in iotlb_sync_map Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` [PATCH v3 3/7] iommu/mediatek: Add iotlb_sync_map to sync whole the iova range Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` [PATCH v3 4/7] iommu: Switch gather->end to unsigned long long Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 11:03 ` David Laight
2020-12-16 11:03 ` David Laight
2020-12-16 11:03 ` David Laight
2020-12-16 11:03 ` David Laight
2020-12-17 2:26 ` Yong Wu
2020-12-17 2:26 ` Yong Wu
2020-12-17 2:26 ` Yong Wu
2020-12-17 2:26 ` Yong Wu
2020-12-16 12:10 ` Robin Murphy
2020-12-16 12:10 ` Robin Murphy
2020-12-16 12:10 ` Robin Murphy
2020-12-16 12:10 ` Robin Murphy
2020-12-17 2:26 ` Yong Wu
2020-12-17 2:26 ` Yong Wu
2020-12-17 2:26 ` Yong Wu
2020-12-17 2:26 ` Yong Wu
2020-12-16 10:36 ` [PATCH v3 5/7] iommu: Allow io_pgtable_tlb ops optional Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2021-01-18 16:18 ` Robin Murphy
2021-01-18 16:18 ` Robin Murphy
2021-01-18 16:18 ` Robin Murphy
2021-01-18 16:18 ` Robin Murphy
2020-12-16 10:36 ` [PATCH v3 6/7] iommu/mediatek: Gather iova in iommu_unmap to achieve tlb sync once Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-23 8:56 ` Tomasz Figa
2020-12-23 8:56 ` Tomasz Figa
2020-12-23 8:56 ` Tomasz Figa
2020-12-23 8:56 ` Tomasz Figa
2020-12-23 11:00 ` Robin Murphy
2020-12-23 11:00 ` Robin Murphy
2020-12-23 11:00 ` Robin Murphy
2020-12-23 11:00 ` Robin Murphy
2021-01-08 9:56 ` Tomasz Figa
2021-01-08 9:56 ` Tomasz Figa
2021-01-08 9:56 ` Tomasz Figa
2021-01-08 9:56 ` Tomasz Figa
2021-01-08 9:56 ` Tomasz Figa
2021-01-08 9:56 ` Tomasz Figa
2021-01-08 9:56 ` Tomasz Figa
2021-01-08 9:56 ` Tomasz Figa
2021-01-18 16:35 ` Robin Murphy
2021-01-18 16:35 ` Robin Murphy
2021-01-18 16:35 ` Robin Murphy
2021-01-18 16:35 ` Robin Murphy
2021-01-18 16:58 ` Will Deacon
2021-01-18 16:58 ` Will Deacon
2021-01-18 16:58 ` Will Deacon
2021-01-18 16:58 ` Will Deacon
2021-01-18 17:14 ` Robin Murphy
2021-01-18 17:14 ` Robin Murphy
2021-01-18 17:14 ` Robin Murphy
2021-01-18 17:14 ` Robin Murphy
2020-12-16 10:36 ` [PATCH v3 7/7] iommu/mediatek: Remove the tlb-ops for v7s Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2020-12-16 10:36 ` Yong Wu
2021-01-18 16:39 ` Robin Murphy
2021-01-18 16:39 ` Robin Murphy
2021-01-18 16:39 ` Robin Murphy
2021-01-18 16:39 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223085153.GA30643@infradead.org \
--to=hch@infradead.org \
--cc=anan.sun@mediatek.com \
--cc=chao.hao@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=gregkh@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.