From: Christoph Hellwig <hch@lst.de>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [RFC] nvme: set block size during namespace validation
Date: Wed, 23 Dec 2020 16:49:04 +0100 [thread overview]
Message-ID: <20201223154904.GA5967@lst.de> (raw)
In-Reply-To: <20201223150136.4221-1-minwoo.im.dev@gmail.com>
set_blocksize just sets the block sise used for buffer heads and should
not be called by the driver. blkdev_get updates the block size, so
you must already have the fd re-reading the partition table open?
I'm not entirely sure how we can work around this except by avoiding
buffer head I/O in the partition reread code. Note that this affects
all block drivers where the block size could change at runtime.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC] nvme: set block size during namespace validation
Date: Wed, 23 Dec 2020 16:49:04 +0100 [thread overview]
Message-ID: <20201223154904.GA5967@lst.de> (raw)
In-Reply-To: <20201223150136.4221-1-minwoo.im.dev@gmail.com>
set_blocksize just sets the block sise used for buffer heads and should
not be called by the driver. blkdev_get updates the block size, so
you must already have the fd re-reading the partition table open?
I'm not entirely sure how we can work around this except by avoiding
buffer head I/O in the partition reread code. Note that this affects
all block drivers where the block size could change at runtime.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-12-23 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 15:01 [RFC] nvme: set block size during namespace validation Minwoo Im
2020-12-23 15:01 ` Minwoo Im
2020-12-23 15:49 ` Christoph Hellwig [this message]
2020-12-23 15:49 ` Christoph Hellwig
2020-12-23 16:16 ` Minwoo Im
2020-12-23 16:16 ` Minwoo Im
2020-12-23 16:27 ` Christoph Hellwig
2020-12-23 16:27 ` Christoph Hellwig
2020-12-23 18:31 ` Minwoo Im
2020-12-23 18:31 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223154904.GA5967@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minwoo.im.dev@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.