From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: devicetree@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks boards with IMX8MM
Date: Thu, 24 Dec 2020 12:23:35 +0100 [thread overview]
Message-ID: <20201224112335.GA15628@kozik-lap> (raw)
In-Reply-To: <1608762196-29871-1-git-send-email-tharvey@gateworks.com>
On Wed, Dec 23, 2020 at 02:23:15PM -0800, Tim Harvey wrote:
> Add bindings for the Gateworks Venice Development kit boards with
> IMX8MM System on Module.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 1ca9dfa..705c6e8 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -405,6 +405,9 @@ properties:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
> - fsl,imx8mm-evk # i.MX8MM EVK Board
> + - gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit
> + - gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit
> + - gw,imx8mm-gw73xx-0x # i.MX8MM Gateworks Development Kit
I think you should skip the wildcards in compatible and choose one
specific compatible. What if at some point you would like to add gw,imx8mm-gw7113-0x?
Best regards,
Krzysztof
> - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
> - const: fsl,imx8mm
>
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks boards with IMX8MM
Date: Thu, 24 Dec 2020 12:23:35 +0100 [thread overview]
Message-ID: <20201224112335.GA15628@kozik-lap> (raw)
In-Reply-To: <1608762196-29871-1-git-send-email-tharvey@gateworks.com>
On Wed, Dec 23, 2020 at 02:23:15PM -0800, Tim Harvey wrote:
> Add bindings for the Gateworks Venice Development kit boards with
> IMX8MM System on Module.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 1ca9dfa..705c6e8 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -405,6 +405,9 @@ properties:
> - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit
> - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
> - fsl,imx8mm-evk # i.MX8MM EVK Board
> + - gw,imx8mm-gw71xx-0x # i.MX8MM Gateworks Development Kit
> + - gw,imx8mm-gw72xx-0x # i.MX8MM Gateworks Development Kit
> + - gw,imx8mm-gw73xx-0x # i.MX8MM Gateworks Development Kit
I think you should skip the wildcards in compatible and choose one
specific compatible. What if at some point you would like to add gw,imx8mm-gw7113-0x?
Best regards,
Krzysztof
> - variscite,var-som-mx8mm # i.MX8MM Variscite VAR-SOM-MX8MM module
> - const: fsl,imx8mm
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-12-24 11:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 22:23 [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks boards with IMX8MM Tim Harvey
2020-12-23 22:23 ` Tim Harvey
2020-12-23 22:23 ` [PATCH 2/2] arm64: dts: imx8mm: Add Gateworks IMX8MM Development Kits Tim Harvey
2020-12-23 22:23 ` Tim Harvey
2020-12-24 11:37 ` Krzysztof Kozlowski
2020-12-24 11:37 ` Krzysztof Kozlowski
2020-12-28 19:02 ` Tim Harvey
2020-12-28 19:02 ` Tim Harvey
2020-12-28 19:19 ` Krzysztof Kozlowski
2020-12-28 19:19 ` Krzysztof Kozlowski
2020-12-24 12:11 ` Krzysztof Kozlowski
2020-12-24 12:11 ` Krzysztof Kozlowski
2020-12-24 15:34 ` Sven Van Asbroeck
2020-12-28 17:55 ` Tim Harvey
2020-12-28 21:08 ` Sven Van Asbroeck
2020-12-24 11:23 ` Krzysztof Kozlowski [this message]
2020-12-24 11:23 ` [PATCH 1/2] dt-bindings: arm: fsl: Add binding for Gateworks boards with IMX8MM Krzysztof Kozlowski
2020-12-28 16:18 ` Tim Harvey
2020-12-28 16:18 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201224112335.GA15628@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.