From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Peng Fan <peng.fan@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node
Date: Tue, 29 Dec 2020 17:12:20 +0100 [thread overview]
Message-ID: <20201229161220.GA17229@kozik-lap> (raw)
In-Reply-To: <CAHCN7x+=ebLn8vrrT=fyByQDydDNfkESFZHjdUrw=OHBz_E0hw@mail.gmail.com>
On Tue, Dec 29, 2020 at 06:26:41AM -0600, Adam Ford wrote:
> On Tue, Dec 29, 2020 at 6:15 AM <peng.fan@nxp.com> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > According to RM, there is a spba bus inside aips3 and aips1, add it.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 362 +++++++++++-----------
> > 1 file changed, 189 insertions(+), 173 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index c824f2615fe8..91f85b8cee9a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -269,117 +269,125 @@ aips1: bus@30000000 {
> > #size-cells = <1>;
> > ranges = <0x30000000 0x30000000 0x400000>;
> >
> > - sai1: sai@30010000 {
> > - #sound-dai-cells = <0>;
> > - compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai";
> > - reg = <0x30010000 0x10000>;
> > - interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&clk IMX8MM_CLK_SAI1_IPG>,
> > - <&clk IMX8MM_CLK_SAI1_ROOT>,
> > - <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>;
> > - clock-names = "bus", "mclk1", "mclk2", "mclk3";
> > - dmas = <&sdma2 0 2 0>, <&sdma2 1 2 0>;
> > - dma-names = "rx", "tx";
> > - status = "disabled";
> > - };
> > + bus@30000000 {
>
> There is already a bus@30000000 (aips1), and I think the system
> doesn't like it when there are multiple busses with the same name.
>
> There was some discussion on fixing the 8mn [1], but it doesn't look
> like it went anywhere.
>
> I am guessing the Mini will need something similar to the nano.
>
> [1] - https://patchwork.kernel.org/project/linux-arm-kernel/patch/1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com/
Several replies from S.j. Wang are missing from LKML (and maybe
patchwork?) but we reached a conclusion:
https://lore.kernel.org/linux-arm-kernel/20201208090601.GA8347@kozik-lap/
Either you do some remapping of address space or just rename the "bus"
nodes (e.g. generic bus-1 or a specific spba-bus).
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] arm64: dts: imx8mn: add spba bus node
Date: Tue, 29 Dec 2020 17:12:20 +0100 [thread overview]
Message-ID: <20201229161220.GA17229@kozik-lap> (raw)
In-Reply-To: <CAHCN7x+=ebLn8vrrT=fyByQDydDNfkESFZHjdUrw=OHBz_E0hw@mail.gmail.com>
On Tue, Dec 29, 2020 at 06:26:41AM -0600, Adam Ford wrote:
> On Tue, Dec 29, 2020 at 6:15 AM <peng.fan@nxp.com> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > According to RM, there is a spba bus inside aips3 and aips1, add it.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 362 +++++++++++-----------
> > 1 file changed, 189 insertions(+), 173 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index c824f2615fe8..91f85b8cee9a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -269,117 +269,125 @@ aips1: bus@30000000 {
> > #size-cells = <1>;
> > ranges = <0x30000000 0x30000000 0x400000>;
> >
> > - sai1: sai@30010000 {
> > - #sound-dai-cells = <0>;
> > - compatible = "fsl,imx8mm-sai", "fsl,imx8mq-sai";
> > - reg = <0x30010000 0x10000>;
> > - interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&clk IMX8MM_CLK_SAI1_IPG>,
> > - <&clk IMX8MM_CLK_SAI1_ROOT>,
> > - <&clk IMX8MM_CLK_DUMMY>, <&clk IMX8MM_CLK_DUMMY>;
> > - clock-names = "bus", "mclk1", "mclk2", "mclk3";
> > - dmas = <&sdma2 0 2 0>, <&sdma2 1 2 0>;
> > - dma-names = "rx", "tx";
> > - status = "disabled";
> > - };
> > + bus@30000000 {
>
> There is already a bus@30000000 (aips1), and I think the system
> doesn't like it when there are multiple busses with the same name.
>
> There was some discussion on fixing the 8mn [1], but it doesn't look
> like it went anywhere.
>
> I am guessing the Mini will need something similar to the nano.
>
> [1] - https://patchwork.kernel.org/project/linux-arm-kernel/patch/1607324004-12960-1-git-send-email-shengjiu.wang@nxp.com/
Several replies from S.j. Wang are missing from LKML (and maybe
patchwork?) but we reached a conclusion:
https://lore.kernel.org/linux-arm-kernel/20201208090601.GA8347@kozik-lap/
Either you do some remapping of address space or just rename the "bus"
nodes (e.g. generic bus-1 or a specific spba-bus).
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-29 16:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 12:00 [PATCH 0/4] arm64: dts: imx8m: add spda bus peng.fan
2020-12-29 12:00 ` peng.fan
2020-12-29 12:00 ` [PATCH 1/4] arm64: dts: imx8mn: add spba bus node of aips3 peng.fan
2020-12-29 12:00 ` peng.fan
2020-12-29 12:00 ` [PATCH 2/4] arm64: dts: imx8mn: add spba bus node peng.fan
2020-12-29 12:00 ` peng.fan
2020-12-29 12:26 ` Adam Ford
2020-12-29 12:26 ` Adam Ford
2020-12-29 16:12 ` Krzysztof Kozlowski [this message]
2020-12-29 16:12 ` Krzysztof Kozlowski
2020-12-30 2:34 ` Peng Fan
2020-12-30 2:34 ` Peng Fan
2021-03-31 18:23 ` Adam Ford
2021-03-31 18:23 ` Adam Ford
2020-12-29 12:00 ` [PATCH 3/4] " peng.fan
2020-12-29 12:00 ` peng.fan
2020-12-29 16:13 ` Krzysztof Kozlowski
2020-12-29 16:13 ` Krzysztof Kozlowski
2020-12-30 2:32 ` Peng Fan
2020-12-30 2:32 ` Peng Fan
2020-12-29 12:00 ` [PATCH 4/4] arm64: dts: imx8mq: " peng.fan
2020-12-29 12:00 ` peng.fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229161220.GA17229@kozik-lap \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.