[PATCH 0/2] Preserve goldfish rtc

[PATCH 0/2] Preserve goldfish rtc

[Jiaxun Yang]

Link: https://lore.kernel.org/lkml/X6+wGMUCCpu2liYR@kroah.com/

Cc: chenhc@lemote.com
Cc: gregkh@linuxfoundation.org

Jiaxun Yang (2):
  rtc: goldfish: Remove GOLDFISH dependency
  MAINTAINERS: Set myself as Goldfish RTC maintainer

 MAINTAINERS         | 2 +-
 drivers/rtc/Kconfig | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

-- 
2.29.2

[PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

[Jiaxun Yang]

Goldfish platform is covered with dust.
However the goldfish-rtc had been used as virtualized RTC
in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
we can drop other parts of goldfish but leave goldfish-rtc here.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 drivers/rtc/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 65ad9d0b47ab..f784b52381b1 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
 config RTC_DRV_GOLDFISH
 	tristate "Goldfish Real Time Clock"
 	depends on OF && HAS_IOMEM
-	depends on GOLDFISH || COMPILE_TEST
 	help
 	  Say yes to enable RTC driver for the Goldfish based virtual platform.
 
-- 
2.29.2

Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

[Geert Uytterhoeven]

Hi Jiaxun,

On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> Goldfish platform is covered with dust.
> However the goldfish-rtc had been used as virtualized RTC
> in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> we can drop other parts of goldfish but leave goldfish-rtc here.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks for your patch!

> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
>  config RTC_DRV_GOLDFISH
>         tristate "Goldfish Real Time Clock"
>         depends on OF && HAS_IOMEM
> -       depends on GOLDFISH || COMPILE_TEST
>         help
>           Say yes to enable RTC driver for the Goldfish based virtual platform.

I was just looking to see if someone had already sent a patch to add
"depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
noticed your patch had removed it...

What about

    depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST

instead?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

[Alexandre Belloni]

Hi Geert,

On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote:
> Hi Jiaxun,
> 
> On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> > Goldfish platform is covered with dust.
> > However the goldfish-rtc had been used as virtualized RTC
> > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> > we can drop other parts of goldfish but leave goldfish-rtc here.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> 
> Thanks for your patch!
> 
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
> >  config RTC_DRV_GOLDFISH
> >         tristate "Goldfish Real Time Clock"
> >         depends on OF && HAS_IOMEM
> > -       depends on GOLDFISH || COMPILE_TEST
> >         help
> >           Say yes to enable RTC driver for the Goldfish based virtual platform.
> 
> I was just looking to see if someone had already sent a patch to add
> "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
> noticed your patch had removed it...
> 
> What about
> 
>     depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST
> 
> instead?
> 

But this driver also works on ARM, is it really important to restrict to
a few architectures ?

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

[Geert Uytterhoeven]

Hi Alexandre,

On Mon, Jan 4, 2021 at 3:48 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote:
> > On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> > > Goldfish platform is covered with dust.
> > > However the goldfish-rtc had been used as virtualized RTC
> > > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> > > we can drop other parts of goldfish but leave goldfish-rtc here.
> > >
> > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> >
> > Thanks for your patch!
> >
> > > --- a/drivers/rtc/Kconfig
> > > +++ b/drivers/rtc/Kconfig
> > > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
> > >  config RTC_DRV_GOLDFISH
> > >         tristate "Goldfish Real Time Clock"
> > >         depends on OF && HAS_IOMEM
> > > -       depends on GOLDFISH || COMPILE_TEST
> > >         help
> > >           Say yes to enable RTC driver for the Goldfish based virtual platform.
> >
> > I was just looking to see if someone had already sent a patch to add
> > "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
> > noticed your patch had removed it...
> >
> > What about
> >
> >     depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST
> >
> > instead?
> >
>
> But this driver also works on ARM, is it really important to restrict to
> a few architectures ?

Is it used on ARM platforms?
qemu:hw/riscv/Kconfig selects GOLDFISH_RTC, but that's it?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

[Alexandre Belloni]

On 04/01/2021 16:21:31+0100, Geert Uytterhoeven wrote:
> Hi Alexandre,
> 
> On Mon, Jan 4, 2021 at 3:48 PM Alexandre Belloni
> <alexandre.belloni@bootlin.com> wrote:
> > On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote:
> > > On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> > > > Goldfish platform is covered with dust.
> > > > However the goldfish-rtc had been used as virtualized RTC
> > > > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> > > > we can drop other parts of goldfish but leave goldfish-rtc here.
> > > >
> > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > >
> > > Thanks for your patch!
> > >
> > > > --- a/drivers/rtc/Kconfig
> > > > +++ b/drivers/rtc/Kconfig
> > > > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
> > > >  config RTC_DRV_GOLDFISH
> > > >         tristate "Goldfish Real Time Clock"
> > > >         depends on OF && HAS_IOMEM
> > > > -       depends on GOLDFISH || COMPILE_TEST
> > > >         help
> > > >           Say yes to enable RTC driver for the Goldfish based virtual platform.
> > >
> > > I was just looking to see if someone had already sent a patch to add
> > > "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
> > > noticed your patch had removed it...
> > >
> > > What about
> > >
> > >     depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST
> > >
> > > instead?
> > >
> >
> > But this driver also works on ARM, is it really important to restrict to
> > a few architectures ?
> 
> Is it used on ARM platforms?
> qemu:hw/riscv/Kconfig selects GOLDFISH_RTC, but that's it?
> 

My understanding is that this was used on the original ARM based goldfish
android emulator but I don't think this was ever upstreamed.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

[Geert Uytterhoeven]

Hi Alexandre,

On Mon, Jan 4, 2021 at 4:43 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 04/01/2021 16:21:31+0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 4, 2021 at 3:48 PM Alexandre Belloni
> > <alexandre.belloni@bootlin.com> wrote:
> > > On 04/01/2021 14:28:26+0100, Geert Uytterhoeven wrote:
> > > > On Sat, Nov 14, 2020 at 2:20 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> > > > > Goldfish platform is covered with dust.
> > > > > However the goldfish-rtc had been used as virtualized RTC
> > > > > in QEMU for RISC-V virt hw and MIPS loongson3-virt hw, thus
> > > > > we can drop other parts of goldfish but leave goldfish-rtc here.
> > > > >
> > > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > > --- a/drivers/rtc/Kconfig
> > > > > +++ b/drivers/rtc/Kconfig
> > > > > @@ -1935,7 +1935,6 @@ config RTC_DRV_HID_SENSOR_TIME
> > > > >  config RTC_DRV_GOLDFISH
> > > > >         tristate "Goldfish Real Time Clock"
> > > > >         depends on OF && HAS_IOMEM
> > > > > -       depends on GOLDFISH || COMPILE_TEST
> > > > >         help
> > > > >           Say yes to enable RTC driver for the Goldfish based virtual platform.
> > > >
> > > > I was just looking to see if someone had already sent a patch to add
> > > > "depends on GOLDFISH || COMPILE_TEST", before sending one myself, when I
> > > > noticed your patch had removed it...
> > > >
> > > > What about
> > > >
> > > >     depends on CPU_LOONGSON64 || GOLDFISH || RISCV || COMPILE_TEST
> > > >
> > > > instead?
> > > >
> > >
> > > But this driver also works on ARM, is it really important to restrict to
> > > a few architectures ?
> >
> > Is it used on ARM platforms?
> > qemu:hw/riscv/Kconfig selects GOLDFISH_RTC, but that's it?
>
> My understanding is that this was used on the original ARM based goldfish
> android emulator but I don't think this was ever upstreamed.

Upstream indeed only has GOLDFISH support in arch/x86/Kconfig.
Still, that would be handled by the dependency on GOLDFISH.

Or do you mean upstream QEMU Goldfish support?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] rtc: goldfish: Remove GOLDFISH dependency

[Alexandre Belloni]

On 04/01/2021 16:51:40+0100, Geert Uytterhoeven wrote:
> > > Is it used on ARM platforms?
> > > qemu:hw/riscv/Kconfig selects GOLDFISH_RTC, but that's it?
> >
> > My understanding is that this was used on the original ARM based goldfish
> > android emulator but I don't think this was ever upstreamed.
> 
> Upstream indeed only has GOLDFISH support in arch/x86/Kconfig.
> Still, that would be handled by the dependency on GOLDFISH.
> 
> Or do you mean upstream QEMU Goldfish support?
> 

Yes, I meant upstream in QEMU. If I refer to the doc from google:

'goldfish' is the name of a family of similar virtual hardware platforms, that
mostly differ in the virtual CPU they support. 'goldfish' started as an
ARM-specific platform, but has now been ported to x86 and MIPS virtual CPUs.

Goldfish was based on QEMU 0.8.2, they then moved to ranchu, this time
on a more upstream QEMU but I don't think this is upstream either.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH 2/2] MAINTAINERS: Set myself as Goldfish RTC maintainer

[Jiaxun Yang]

While Gildfish platform is dusted, the RTC driver remains
valuable for us.

I'm volunteering to maintain goldfish RTC driver onward.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Miodrag Dinic <Miodrag.Dinic@syrmia.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e73636b75f29..b576544264e6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1168,7 +1168,7 @@ F:	Documentation/devicetree/bindings/interrupt-controller/google,goldfish-pic.tx
 F:	drivers/irqchip/irq-goldfish-pic.c
 
 ANDROID GOLDFISH RTC DRIVER
-M:	Miodrag Dinic <miodrag.dinic@mips.com>
+M:	Jiaxun Yang <jiaxun.yang@flygoat.com>
 S:	Supported
 F:	Documentation/devicetree/bindings/rtc/google,goldfish-rtc.txt
 F:	drivers/rtc/rtc-goldfish.c
-- 
2.29.2

Re: [PATCH 2/2] MAINTAINERS: Set myself as Goldfish RTC maintainer

[Sergei Shtylyov]

Hello!

On 11/14/20 4:09 PM, Jiaxun Yang wrote:

> While Gildfish platform is dusted, the RTC driver remains

   Goldfish. :-)

> valuable for us.
> 
> I'm volunteering to maintain goldfish RTC driver onward.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Cc: Miodrag Dinic <Miodrag.Dinic@syrmia.com>
[...]

MBR, Sergei

RE: [PATCH 2/2] MAINTAINERS: Set myself as Goldfish RTC maintainer

[Miodrag Dinic]

Hi, I'm glad to see that the code is still in use. Thanks for notification, feel free to take ownership and continue development/maintenance of this code.

Kind regards,
Miodrag

-----Original Message-----
From: Sergei Shtylyov <sergei.shtylyov@gmail.com> 
Sent: Saturday, November 14, 2020 7:26 PM
To: Jiaxun Yang <jiaxun.yang@flygoat.com>; linux-mips@vger.kernel.org
Cc: Miodrag Dinic <Miodrag.Dinic@syrmia.com>; Alessandro Zummo <a.zummo@towertech.it>; Alexandre Belloni <alexandre.belloni@bootlin.com>; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org
Subject: Re: [PATCH 2/2] MAINTAINERS: Set myself as Goldfish RTC maintainer

Hello!

On 11/14/20 4:09 PM, Jiaxun Yang wrote:

> While Gildfish platform is dusted, the RTC driver remains

   Goldfish. :-)

> valuable for us.
> 
> I'm volunteering to maintain goldfish RTC driver onward.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Cc: Miodrag Dinic <Miodrag.Dinic@syrmia.com>
[...]

MBR, Sergei

Re: [PATCH 0/2] Preserve goldfish rtc

[Alexandre Belloni]

On Sat, 14 Nov 2020 21:09:19 +0800, Jiaxun Yang wrote:
> Cc: chenhc@lemote.com
> Cc: gregkh@linuxfoundation.org
> 
> Jiaxun Yang (2):
>   rtc: goldfish: Remove GOLDFISH dependency
>   MAINTAINERS: Set myself as Goldfish RTC maintainer
> 
> [...]

Applied, thanks!

[1/2] rtc: goldfish: Remove GOLDFISH dependency
      commit: 5022cfc112328e7fd489f5e3d41b7f352322880c
[2/2] MAINTAINERS: Set myself as Goldfish RTC maintainer
      commit: 9844484eac2bff09ba3fcdebcf5a41d94df6b6c1

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>