All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: devicetree@vger.kernel.org,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Li Yang <leoyang.li@nxp.com>, Michael Walle <michael@walle.cc>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: freescale: use fixed index mmcN for NXP layerscape reference boards
Date: Tue, 5 Jan 2021 10:13:08 +0800	[thread overview]
Message-ID: <20210105021307.GG4142@dragon> (raw)
In-Reply-To: <20201201032127.41681-1-yangbo.lu@nxp.com>

On Tue, Dec 01, 2020 at 11:21:27AM +0800, Yangbo Lu wrote:
> The eSDHC driver has converted to use asynchronous probe.
> Let's use fixed index mmcN for eSDHC controllers, so that
> we can ignore the effect on usage, and avoid problem on
> previous use cases with fixed index mmcblkN.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts  | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts  | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts  | 2 ++
>  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts  | 2 ++
>  arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts  | 2 ++
>  6 files changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> index 6290e2f..76b7e29 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> @@ -14,6 +14,11 @@
>  / {
>  	model = "LS1012A FRWY Board";
>  	compatible = "fsl,ls1012a-frwy", "fsl,ls1012a";
> +
> +	aliases {
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
> +	};

Are these esdhc devices enabled in the board dts?  I think that the
aliases are only needed for enabled devices.

Shawn

>  };
>  
>  &duart0 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> index 449475a..e22c5e7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> @@ -13,6 +13,11 @@
>  	model = "LS1012A QDS Board";
>  	compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
>  
> +	aliases {
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
> +	};
> +
>  	sys_mclk: clock-mclk {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> index d45c176..f939d65 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -12,6 +12,11 @@
>  / {
>  	model = "LS1012A RDB Board";
>  	compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
> +
> +	aliases {
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
> +	};
>  };
>  
>  &duart0 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> index 2d1fe6c..4ec1a4c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> @@ -15,6 +15,8 @@
>  	aliases {
>  		crypto = &crypto;
>  		serial0 = &uart0;
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
>  	};
>  
>  	chosen {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index 7723ad5..bdb3b04 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -15,6 +15,8 @@
>  	aliases {
>  		crypto = &crypto;
>  		serial0 = &uart0;
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
>  	};
>  
>  	chosen {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts
> index 9178684..69e99cb 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts
> @@ -15,6 +15,8 @@
>  	aliases {
>  		crypto = &crypto;
>  		serial0 = &uart0;
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
>  	};
>  
>  	chosen {
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Li Yang <leoyang.li@nxp.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Michael Walle <michael@walle.cc>
Subject: Re: [PATCH] arm64: dts: freescale: use fixed index mmcN for NXP layerscape reference boards
Date: Tue, 5 Jan 2021 10:13:08 +0800	[thread overview]
Message-ID: <20210105021307.GG4142@dragon> (raw)
In-Reply-To: <20201201032127.41681-1-yangbo.lu@nxp.com>

On Tue, Dec 01, 2020 at 11:21:27AM +0800, Yangbo Lu wrote:
> The eSDHC driver has converted to use asynchronous probe.
> Let's use fixed index mmcN for eSDHC controllers, so that
> we can ignore the effect on usage, and avoid problem on
> previous use cases with fixed index mmcblkN.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts  | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts  | 5 +++++
>  arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts  | 2 ++
>  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts  | 2 ++
>  arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts  | 2 ++
>  6 files changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> index 6290e2f..76b7e29 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts
> @@ -14,6 +14,11 @@
>  / {
>  	model = "LS1012A FRWY Board";
>  	compatible = "fsl,ls1012a-frwy", "fsl,ls1012a";
> +
> +	aliases {
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
> +	};

Are these esdhc devices enabled in the board dts?  I think that the
aliases are only needed for enabled devices.

Shawn

>  };
>  
>  &duart0 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> index 449475a..e22c5e7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts
> @@ -13,6 +13,11 @@
>  	model = "LS1012A QDS Board";
>  	compatible = "fsl,ls1012a-qds", "fsl,ls1012a";
>  
> +	aliases {
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
> +	};
> +
>  	sys_mclk: clock-mclk {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> index d45c176..f939d65 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -12,6 +12,11 @@
>  / {
>  	model = "LS1012A RDB Board";
>  	compatible = "fsl,ls1012a-rdb", "fsl,ls1012a";
> +
> +	aliases {
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
> +	};
>  };
>  
>  &duart0 {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> index 2d1fe6c..4ec1a4c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
> @@ -15,6 +15,8 @@
>  	aliases {
>  		crypto = &crypto;
>  		serial0 = &uart0;
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
>  	};
>  
>  	chosen {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index 7723ad5..bdb3b04 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -15,6 +15,8 @@
>  	aliases {
>  		crypto = &crypto;
>  		serial0 = &uart0;
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
>  	};
>  
>  	chosen {
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts
> index 9178684..69e99cb 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts
> @@ -15,6 +15,8 @@
>  	aliases {
>  		crypto = &crypto;
>  		serial0 = &uart0;
> +		mmc0 = &esdhc0;
> +		mmc1 = &esdhc1;
>  	};
>  
>  	chosen {
> -- 
> 2.7.4
> 

  reply	other threads:[~2021-01-05  2:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  3:21 [PATCH] arm64: dts: freescale: use fixed index mmcN for NXP layerscape reference boards Yangbo Lu
2020-12-01  3:21 ` Yangbo Lu
2021-01-05  2:13 ` Shawn Guo [this message]
2021-01-05  2:13   ` Shawn Guo
2021-01-05  3:10   ` Y.b. Lu
2021-01-05  3:10     ` Y.b. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105021307.GG4142@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.