From: Al Viro <viro@zeniv.linux.org.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Vineet Gupta <vgupta@synopsys.com>,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupts@synopsys.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH v2] fs/dax: include <asm/page.h> to fix build error on ARC
Date: Tue, 5 Jan 2021 04:17:38 +0000 [thread overview]
Message-ID: <20210105041738.GS3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20210101042914.5313-1-rdunlap@infradead.org>
On Thu, Dec 31, 2020 at 08:29:14PM -0800, Randy Dunlap wrote:
> fs/dax.c uses copy_user_page() but ARC does not provide that interface,
> resulting in a build error.
>
> Provide copy_user_page() in <asm/page.h> (beside copy_page()) and
> add <asm/page.h> to fs/dax.c to fix the build error.
>
> ../fs/dax.c: In function 'copy_cow_page_dax':
> ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration]
Could somebody explain what the force-cast is doing in there?
I mean, the call is
copy_user_page(vto, (void __force *)kaddr, vaddr, to);
kaddr is a local variable there, declared as void *; AFAICS, that
had been pure cargo-cult since
commit 7a9eb20666317794d0279843fbd091af93907780
Author: Dan Williams <dan.j.williams@intel.com>
Date: Fri Jun 3 18:06:47 2016 -0700
pmem: kill __pmem address space
I mean, it's been more than 4 years, time to bury that body...
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jan Kara <jack@suse.cz>, kernel test robot <lkp@intel.com>,
linux-nvdimm@lists.01.org, Vineet Gupta <vgupta@synopsys.com>,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Vineet Gupta <vgupts@synopsys.com>,
linux-fsdevel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-snps-arc@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] fs/dax: include <asm/page.h> to fix build error on ARC
Date: Tue, 5 Jan 2021 04:17:38 +0000 [thread overview]
Message-ID: <20210105041738.GS3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20210101042914.5313-1-rdunlap@infradead.org>
On Thu, Dec 31, 2020 at 08:29:14PM -0800, Randy Dunlap wrote:
> fs/dax.c uses copy_user_page() but ARC does not provide that interface,
> resulting in a build error.
>
> Provide copy_user_page() in <asm/page.h> (beside copy_page()) and
> add <asm/page.h> to fs/dax.c to fix the build error.
>
> ../fs/dax.c: In function 'copy_cow_page_dax':
> ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration]
Could somebody explain what the force-cast is doing in there?
I mean, the call is
copy_user_page(vto, (void __force *)kaddr, vaddr, to);
kaddr is a local variable there, declared as void *; AFAICS, that
had been pure cargo-cult since
commit 7a9eb20666317794d0279843fbd091af93907780
Author: Dan Williams <dan.j.williams@intel.com>
Date: Fri Jun 3 18:06:47 2016 -0700
pmem: kill __pmem address space
I mean, it's been more than 4 years, time to bury that body...
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Vineet Gupta <vgupta@synopsys.com>,
linux-snps-arc@lists.infradead.org,
Dan Williams <dan.j.williams@intel.com>,
Vineet Gupta <vgupts@synopsys.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH v2] fs/dax: include <asm/page.h> to fix build error on ARC
Date: Tue, 5 Jan 2021 04:17:38 +0000 [thread overview]
Message-ID: <20210105041738.GS3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20210101042914.5313-1-rdunlap@infradead.org>
On Thu, Dec 31, 2020 at 08:29:14PM -0800, Randy Dunlap wrote:
> fs/dax.c uses copy_user_page() but ARC does not provide that interface,
> resulting in a build error.
>
> Provide copy_user_page() in <asm/page.h> (beside copy_page()) and
> add <asm/page.h> to fs/dax.c to fix the build error.
>
> ../fs/dax.c: In function 'copy_cow_page_dax':
> ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration]
Could somebody explain what the force-cast is doing in there?
I mean, the call is
copy_user_page(vto, (void __force *)kaddr, vaddr, to);
kaddr is a local variable there, declared as void *; AFAICS, that
had been pure cargo-cult since
commit 7a9eb20666317794d0279843fbd091af93907780
Author: Dan Williams <dan.j.williams@intel.com>
Date: Fri Jun 3 18:06:47 2016 -0700
pmem: kill __pmem address space
I mean, it's been more than 4 years, time to bury that body...
next prev parent reply other threads:[~2021-01-05 4:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 4:29 [PATCH v2] fs/dax: include <asm/page.h> to fix build error on ARC Randy Dunlap
2021-01-01 4:29 ` Randy Dunlap
2021-01-01 4:29 ` Randy Dunlap
2021-01-04 16:12 ` Ira Weiny
2021-01-04 16:12 ` Ira Weiny
2021-01-04 16:12 ` Ira Weiny
2021-01-04 20:13 ` Dan Williams
2021-01-04 20:13 ` Dan Williams
2021-01-04 20:13 ` Dan Williams
2021-01-04 20:16 ` Matthew Wilcox
2021-01-04 20:16 ` Matthew Wilcox
2021-01-04 20:16 ` Matthew Wilcox
2021-01-05 3:41 ` Randy Dunlap
2021-01-05 3:41 ` Randy Dunlap
2021-01-05 3:41 ` Randy Dunlap
2021-01-05 3:50 ` Dan Williams
2021-01-05 3:50 ` Dan Williams
2021-01-05 3:50 ` Dan Williams
2021-01-05 4:17 ` Al Viro [this message]
2021-01-05 4:17 ` Al Viro
2021-01-05 4:17 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105041738.GS3579531@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=vgupta@synopsys.com \
--cc=vgupts@synopsys.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.