From: Dan Carpenter <dan.carpenter@oracle.com>
To: Xin Ji <xji@analogixsemi.com>
Cc: devel@driverdev.osuosl.org, Nicolas Boichat <drinkcat@google.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>, Jonas Karlman <jonas@kwiboo.se>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Vasily Khoruzhick <anarsoul@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Torsten Duwe <duwe@lst.de>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sam Ravnborg <sam@ravnborg.org>,
Sheng Pan <span@analogixsemi.com>
Subject: Re: [PATCH v2 2/2] drm/bridge: anx7625: add MIPI DPI input feature support
Date: Tue, 5 Jan 2021 17:17:01 +0300 [thread overview]
Message-ID: <20210105141701.GG2809@kadam> (raw)
In-Reply-To: <f7fce2657d3c98a4d705f88eb9684f97b646793e.1609380663.git.xji@analogixsemi.com>
On Thu, Dec 31, 2020 at 10:22:36AM +0800, Xin Ji wrote:
> static int anx7625_read_ctrl_status_p0(struct anx7625_data *ctx)
> {
> return anx7625_reg_read(ctx, ctx->i2c.rx_p0_client, AP_AUX_CTRL_STATUS);
> @@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
> AP_AUX_CTRL_STATUS);
> if (val < 0 || (val & 0x0F)) {
> DRM_DEV_ERROR(dev, "aux status %02x\n", val);
> - val = -EIO;
> + return -EIO;
> }
>
> - return val;
> + return 0;
This s/val/0/ change seems like a bug fix. Could you please send that
as a separate patch at the start of the patch set?
> +}
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Xin Ji <xji@analogixsemi.com>
Cc: Nicolas Boichat <drinkcat@google.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
devel@driverdev.osuosl.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Vasily Khoruzhick <anarsoul@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Torsten Duwe <duwe@lst.de>, Sheng Pan <span@analogixsemi.com>,
Daniel Vetter <daniel@ffwll.ch>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Sam Ravnborg <sam@ravnborg.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 2/2] drm/bridge: anx7625: add MIPI DPI input feature support
Date: Tue, 5 Jan 2021 17:17:01 +0300 [thread overview]
Message-ID: <20210105141701.GG2809@kadam> (raw)
In-Reply-To: <f7fce2657d3c98a4d705f88eb9684f97b646793e.1609380663.git.xji@analogixsemi.com>
On Thu, Dec 31, 2020 at 10:22:36AM +0800, Xin Ji wrote:
> static int anx7625_read_ctrl_status_p0(struct anx7625_data *ctx)
> {
> return anx7625_reg_read(ctx, ctx->i2c.rx_p0_client, AP_AUX_CTRL_STATUS);
> @@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
> AP_AUX_CTRL_STATUS);
> if (val < 0 || (val & 0x0F)) {
> DRM_DEV_ERROR(dev, "aux status %02x\n", val);
> - val = -EIO;
> + return -EIO;
> }
>
> - return val;
> + return 0;
This s/val/0/ change seems like a bug fix. Could you please send that
as a separate patch at the start of the patch set?
> +}
regards,
dan carpenter
next prev parent reply other threads:[~2021-01-05 14:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 2:19 [PATCH v2 0/2] Add MIPI rx DPI support Xin Ji
2020-12-31 2:19 ` Xin Ji
2020-12-31 2:21 ` [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting Xin Ji
2020-12-31 2:21 ` Xin Ji
2021-01-11 22:14 ` Rob Herring
2021-01-11 22:14 ` Rob Herring
2021-01-12 8:57 ` Xin Ji
2021-01-12 8:57 ` Xin Ji
2021-01-20 8:57 ` Nicolas Boichat
2021-01-20 8:57 ` Nicolas Boichat
2021-01-22 11:47 ` Xin Ji
2021-01-22 11:47 ` Xin Ji
2021-01-22 16:16 ` Rob Herring
2021-01-22 16:16 ` Rob Herring
2021-01-25 3:17 ` Xin Ji
2021-01-25 3:17 ` Xin Ji
2020-12-31 2:22 ` [PATCH v2 2/2] drm/bridge: anx7625: add MIPI DPI input feature support Xin Ji
2020-12-31 2:22 ` Xin Ji
2021-01-05 14:17 ` Dan Carpenter [this message]
2021-01-05 14:17 ` Dan Carpenter
2021-01-12 8:28 ` Xin Ji
2021-01-12 8:28 ` Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105141701.GG2809@kadam \
--to=dan.carpenter@oracle.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@google.com \
--cc=duwe@lst.de \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=sam@ravnborg.org \
--cc=span@analogixsemi.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.