All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Woojung Huh <woojung.huh@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Landen Chao <Landen.Chao@mediatek.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Vadym Kochan <vkochan@marvell.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Ivan Vecera <ivecera@redhat.com>
Subject: Re: [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin -> vid_end range from VLAN objects
Date: Wed, 6 Jan 2021 19:08:18 +0200	[thread overview]
Message-ID: <20210106170818.GA1080217@shredder.lan> (raw)
In-Reply-To: <20210106131006.577312-2-olteanv@gmail.com>

On Wed, Jan 06, 2021 at 03:09:57PM +0200, Vladimir Oltean wrote:
> Let's go off and finish the job of commit 29ab586c3d83 by deleting the
> bogus iteration through the VLAN ranges from the drivers. Some aspects
> of this feature never made too much sense in the first place. For
> example, what is a range of VLANs all having the BRIDGE_VLAN_INFO_PVID
> flag supposed to mean, when a port can obviously have a single pvid? The
> switchdev drivers have so far interpreted this to mean that the last
> VLAN in the range should be the only one which should get programmed
> with that attribute.

See commit 6623c60dc28e ("bridge: vlan: enforce no pvid flag in vlan
ranges")

> Of the existing switchdev pieces of hardware, it appears that only
> Mellanox Spectrum supports offloading more than one VLAN at a time.
> I have kept that code internal to the driver, because there is some more
> bookkeeping that makes use of it, but I deleted it from the switchdev
> API. But since the switchdev support for ranges has already been de
> facto deleted by a Mellanox employee and nobody noticed for 4 years, I'm
> going to assume it's not a biggie.

Which code are you referring to?

> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

For the switchdev and mlxsw parts:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

I applied the series to our queue, so I should have regression results
tomorrow

  parent reply	other threads:[~2021-01-06 17:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 13:09 [PATCH v2 net-next 00/10] Get rid of the switchdev transactional model Vladimir Oltean
2021-01-06 13:09 ` [PATCH v2 net-next 01/10] net: switchdev: remove vid_begin -> vid_end range from VLAN objects Vladimir Oltean
2021-01-06 14:12   ` kernel test robot
2021-01-06 14:12     ` kernel test robot
2021-01-06 17:08     ` Vladimir Oltean
2021-01-06 17:08   ` Ido Schimmel [this message]
2021-01-06 17:15     ` Vladimir Oltean
2021-01-06 17:26       ` Ido Schimmel
2021-01-06 13:09 ` [PATCH v2 net-next 02/10] net: switchdev: remove the transaction structure from port object notifiers Vladimir Oltean
2021-01-06 17:42   ` Ido Schimmel
2021-01-06 13:09 ` [PATCH v2 net-next 03/10] net: switchdev: delete switchdev_port_obj_add_now Vladimir Oltean
2021-01-06 17:43   ` Ido Schimmel
2021-01-06 13:10 ` [PATCH v2 net-next 04/10] net: switchdev: remove the transaction structure from port attributes Vladimir Oltean
2021-01-06 17:47   ` Ido Schimmel
2021-01-06 13:10 ` [PATCH v2 net-next 05/10] net: dsa: remove the transactional logic from ageing time notifiers Vladimir Oltean
2021-01-06 13:10 ` [PATCH v2 net-next 06/10] net: dsa: remove the transactional logic from MDB entries Vladimir Oltean
2021-01-06 13:10 ` [PATCH v2 net-next 07/10] net: dsa: remove the transactional logic from VLAN objects Vladimir Oltean
2021-01-06 13:10 ` [PATCH v2 net-next 08/10] net: dsa: remove obsolete comments about switchdev transactions Vladimir Oltean
2021-01-06 13:10 ` [PATCH v2 net-next 09/10] mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects Vladimir Oltean
2021-01-06 18:10   ` Ido Schimmel
2021-01-06 13:10 ` [PATCH v2 net-next 10/10] net: switchdev: delete the transaction object Vladimir Oltean
2021-01-06 18:11   ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106170818.GA1080217@shredder.lan \
    --to=idosch@idosch.org \
    --cc=Landen.Chao@mediatek.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hauke@hauke-m.de \
    --cc=idosch@nvidia.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=sean.wang@mediatek.com \
    --cc=tchornyi@marvell.com \
    --cc=vivien.didelot@gmail.com \
    --cc=vkochan@marvell.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.