Re: [PATCH v2 net-next 09/10] mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects

[Ido Schimmel <idosch@idosch.org>]

On Wed, Jan 06, 2021 at 03:10:05PM +0200, Vladimir Oltean wrote:
> @@ -1764,29 +1759,20 @@ static int mlxsw_sp_port_obj_add(struct net_device *dev,
>  {
>  	struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev);
>  	const struct switchdev_obj_port_vlan *vlan;
> -	struct switchdev_trans trans;
>  	int err = 0;
>  
>  	switch (obj->id) {
>  	case SWITCHDEV_OBJ_ID_PORT_VLAN:
>  		vlan = SWITCHDEV_OBJ_PORT_VLAN(obj);
>  
> -		trans.ph_prepare = true;
> -		err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, &trans,
> -					      extack);
> +		err = mlxsw_sp_port_vlans_add(mlxsw_sp_port, vlan, extack);
>  		if (err)
>  			break;
>  
> -		/* The event is emitted before the changes are actually
> -		 * applied to the bridge. Therefore schedule the respin
> -		 * call for later, so that the respin logic sees the
> +		/* Schedule the respin call, so that the respin logic sees the
>  		 * updated bridge state.
>  		 */

I would keep this comment as-is. Other than that this patch looks good
to me:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks