From: Jason Gunthorpe <jgg@nvidia.com>
To: Bernard Metzler <bmt@zurich.ibm.com>
Cc: Yi Zhang <yi.zhang@redhat.com>, kernel test robot <lkp@intel.com>,
leon@kernel.org, linux-rdma@vger.kernel.org,
linux-nvme@lists.infradead.org, Kamal Heib <kamalheib1@gmail.com>
Subject: Re: [PATCH v3] RDMA/siw: Fix handling of zero-sized Read and Receive Queues.
Date: Thu, 7 Jan 2021 15:38:38 -0400 [thread overview]
Message-ID: <20210107193838.GA921419@nvidia.com> (raw)
In-Reply-To: <20201216110000.611-1-bmt@zurich.ibm.com>
On Wed, Dec 16, 2020 at 12:00:00PM +0100, Bernard Metzler wrote:
> @@ -933,6 +937,7 @@ int siw_activate_tx(struct siw_qp *qp)
>
> goto out;
> }
> +no_irq:
> sqe = sq_get_next(qp);
> if (sqe) {
Can you please arrange this without the spaghetti goto's? goto is ok
for error unwind at the tail of the function, but should not be used
willy nilly. Move some of this into functions, use normal if
statements, etc.
Jason
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bernard Metzler <bmt@zurich.ibm.com>
Cc: <linux-rdma@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
<leon@kernel.org>, Kamal Heib <kamalheib1@gmail.com>,
Yi Zhang <yi.zhang@redhat.com>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] RDMA/siw: Fix handling of zero-sized Read and Receive Queues.
Date: Thu, 7 Jan 2021 15:38:38 -0400 [thread overview]
Message-ID: <20210107193838.GA921419@nvidia.com> (raw)
In-Reply-To: <20201216110000.611-1-bmt@zurich.ibm.com>
On Wed, Dec 16, 2020 at 12:00:00PM +0100, Bernard Metzler wrote:
> @@ -933,6 +937,7 @@ int siw_activate_tx(struct siw_qp *qp)
>
> goto out;
> }
> +no_irq:
> sqe = sq_get_next(qp);
> if (sqe) {
Can you please arrange this without the spaghetti goto's? goto is ok
for error unwind at the tail of the function, but should not be used
willy nilly. Move some of this into functions, use normal if
statements, etc.
Jason
next prev parent reply other threads:[~2021-01-07 19:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 11:00 [PATCH v3] RDMA/siw: Fix handling of zero-sized Read and Receive Queues Bernard Metzler
2020-12-16 11:00 ` Bernard Metzler
2020-12-20 15:02 ` Kamal Heib
2020-12-20 15:02 ` Kamal Heib
2021-01-07 19:38 ` Jason Gunthorpe [this message]
2021-01-07 19:38 ` Jason Gunthorpe
2021-01-08 10:51 ` Bernard Metzler
2021-01-08 10:51 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107193838.GA921419@nvidia.com \
--to=jgg@nvidia.com \
--cc=bmt@zurich.ibm.com \
--cc=kamalheib1@gmail.com \
--cc=leon@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkp@intel.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.