From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 12/13] xfs: remove a stale comment from xfs_file_aio_write_checks()
Date: Fri, 8 Jan 2021 10:15:22 +0100 [thread overview]
Message-ID: <20210108091522.GD2587@lst.de> (raw)
In-Reply-To: <20210105005452.92521-13-ebiggers@kernel.org>
On Mon, Jan 04, 2021 at 04:54:51PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The comment in xfs_file_aio_write_checks() about calling file_modified()
> after dropping the ilock doesn't make sense, because the code that
> unconditionally acquires and drops the ilock was removed by
> commit 467f78992a07 ("xfs: reduce ilock hold times in
> xfs_file_aio_write_checks").
>
> Remove this outdated comment.
Yes, this looks good, I actually have the removal included in a WIP
patch as well, but splitting it out like this look good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [f2fs-dev] [PATCH 12/13] xfs: remove a stale comment from xfs_file_aio_write_checks()
Date: Fri, 8 Jan 2021 10:15:22 +0100 [thread overview]
Message-ID: <20210108091522.GD2587@lst.de> (raw)
In-Reply-To: <20210105005452.92521-13-ebiggers@kernel.org>
On Mon, Jan 04, 2021 at 04:54:51PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The comment in xfs_file_aio_write_checks() about calling file_modified()
> after dropping the ilock doesn't make sense, because the code that
> unconditionally acquires and drops the ilock was removed by
> commit 467f78992a07 ("xfs: reduce ilock hold times in
> xfs_file_aio_write_checks").
>
> Remove this outdated comment.
Yes, this looks good, I actually have the removal included in a WIP
patch as well, but splitting it out like this look good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-01-08 9:16 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 0:54 [PATCH 00/13] lazytime fixes and cleanups Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-05 0:54 ` [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-07 14:47 ` Jan Kara
2021-01-07 14:58 ` Matthew Wilcox
2021-01-07 14:58 ` [f2fs-dev] " Matthew Wilcox
2021-01-07 21:46 ` Eric Biggers
2021-01-07 21:46 ` [f2fs-dev] " Eric Biggers
2021-01-08 8:54 ` Christoph Hellwig
2021-01-08 8:54 ` [f2fs-dev] " Christoph Hellwig
2021-01-08 9:01 ` Christoph Hellwig
2021-01-08 9:01 ` [f2fs-dev] " Christoph Hellwig
2021-01-09 17:11 ` Eric Biggers
2021-01-09 17:11 ` [f2fs-dev] " Eric Biggers
2021-01-05 0:54 ` [PATCH 02/13] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-08 8:54 ` Christoph Hellwig
2021-01-08 8:54 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 03/13] fs: only specify I_DIRTY_TIME when needed in generic_update_time() Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-08 8:57 ` Christoph Hellwig
2021-01-08 8:57 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 04/13] fat: only specify I_DIRTY_TIME when needed in fat_update_time() Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-07 13:13 ` Jan Kara
2021-01-07 13:13 ` [f2fs-dev] " Jan Kara
2021-01-07 19:10 ` Eric Biggers
2021-01-07 19:10 ` [f2fs-dev] " Eric Biggers
2021-01-05 0:54 ` [PATCH 05/13] fs: don't call ->dirty_inode for lazytime timestamp updates Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-07 13:17 ` Jan Kara
2021-01-07 13:17 ` [f2fs-dev] " Jan Kara
2021-01-07 13:18 ` Jan Kara
2021-01-07 13:18 ` [f2fs-dev] " Jan Kara
2021-01-08 9:02 ` Christoph Hellwig
2021-01-08 9:02 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 06/13] fs: pass only I_DIRTY_INODE flags to ->dirty_inode Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-08 9:02 ` Christoph Hellwig
2021-01-08 9:02 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 07/13] fs: correctly document the inode dirty flags Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-08 9:03 ` Christoph Hellwig
2021-01-08 9:03 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 08/13] ext4: simplify i_state checks in __ext4_update_other_inode_time() Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-07 13:24 ` Jan Kara
2021-01-07 13:24 ` [f2fs-dev] " Jan Kara
2021-01-07 19:06 ` Eric Biggers
2021-01-07 19:06 ` [f2fs-dev] " Eric Biggers
2021-01-05 0:54 ` [PATCH 09/13] fs: drop redundant checks from __writeback_single_inode() Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-08 9:12 ` Christoph Hellwig
2021-01-08 9:12 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 10/13] fs: clean up __mark_inode_dirty() a bit Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-08 9:10 ` Christoph Hellwig
2021-01-08 9:10 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 11/13] fs: add a lazytime_expired method Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-07 14:02 ` Jan Kara
2021-01-07 14:02 ` [f2fs-dev] " Jan Kara
2021-01-07 22:05 ` Eric Biggers
2021-01-07 22:05 ` [f2fs-dev] " Eric Biggers
2021-01-08 9:14 ` Christoph Hellwig
2021-01-08 9:14 ` [f2fs-dev] " Christoph Hellwig
2021-01-05 0:54 ` [PATCH 12/13] xfs: remove a stale comment from xfs_file_aio_write_checks() Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
2021-01-08 9:15 ` Christoph Hellwig [this message]
2021-01-08 9:15 ` Christoph Hellwig
2021-01-05 0:54 ` [PATCH 13/13] xfs: implement lazytime_expired Eric Biggers
2021-01-05 0:54 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108091522.GD2587@lst.de \
--to=hch@lst.de \
--cc=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.