All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warnings
Date: Sun, 10 Jan 2021 07:30:18 +0800	[thread overview]
Message-ID: <20210109233018.GA60187@04e996a7a407> (raw)
In-Reply-To: <202101100734.VJS04oDD-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Samuel Holland <samuel@sholland.org>
CC: Sebastian Reichel <sre@kernel.org>
CC: "Chen-Yu Tsai" <wens@csie.org>
CC: linux-pm(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: ca4c77bb4315 ("power: supply: axp20x_ac_power: Add wakeup control")
CC: Samuel Holland <samuel@sholland.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2ff90100ace886895e4fbb2850b8d5e49d931ed6
commit: ca4c77bb43151e6569e7aae689a69b65a48c85f0 power: supply: axp20x_ac_power: Add wakeup control
:::::: branch date: 4 hours ago
:::::: commit date: 12 months ago

Please take the patch only if it's a positive warning. Thanks!

 axp20x_ac_power.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/power/supply/axp20x_ac_power.c
+++ b/drivers/power/supply/axp20x_ac_power.c
@@ -378,8 +378,6 @@ static int axp20x_ac_power_probe(struct
 	for (i = 0; i < axp_data->num_irq_names; i++) {
 		irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
 		if (irq < 0) {
-			dev_err(&pdev->dev, "No IRQ for %s: %d\n",
-				axp_data->irq_names[i], irq);
 			return irq;
 		}
 		power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);

  reply	other threads:[~2021-01-09 23:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 23:30 drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error kernel test robot
2021-01-09 23:30 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-07-05 22:14 kernel test robot
2020-07-05 22:14 ` [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warnings kernel test robot
2020-06-14  7:55 drivers/power/supply/axp20x_ac_power.c:381:3-10: line 381 is redundant because platform_get_irq() already prints an error kernel test robot
2020-06-14  7:55 ` [PATCH] power: supply: axp20x_ac_power: fix platform_get_irq.cocci warnings kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210109233018.GA60187@04e996a7a407 \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.