All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: kernel@puri.sm, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, krzk@kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description
Date: Mon, 11 Jan 2021 08:29:45 +0800	[thread overview]
Message-ID: <20210111002942.GR28365@dragon> (raw)
In-Reply-To: <20201222151347.7886-3-martin.kepplinger@puri.sm>

On Tue, Dec 22, 2020 at 04:13:45PM +0100, Martin Kepplinger wrote:
> In order for the touchscreen interrupt line to work, describe it properly.
> Otherwise it can work if defaults are ok, but we cannot be sure.
> 
> Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index 55268fc0622e..a60df09d90f7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -459,6 +459,13 @@
>  		>;
>  	};
>  
> +	pinctrl_touch: touchgrp {
> +		fsl,pins = <
> +		/* TP_INT */
> +		MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27	0x80

Miss indentation for these two lines.

I fixed it up and applied the series.

Shawn

> +		>;
> +	};
> +
>  	pinctrl_typec: typecgrp {
>  		fsl,pins = <
>  			/* TYPEC_MUX_EN */
> @@ -880,6 +887,8 @@
>  	touchscreen@38 {
>  		compatible = "edt,edt-ft5506";
>  		reg = <0x38>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touch>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
>  		touchscreen-size-x = <720>;
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, festevam@gmail.com, kernel@pengutronix.de,
	linux-imx@nxp.com, krzk@kernel.org, kernel@puri.sm,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description
Date: Mon, 11 Jan 2021 08:29:45 +0800	[thread overview]
Message-ID: <20210111002942.GR28365@dragon> (raw)
In-Reply-To: <20201222151347.7886-3-martin.kepplinger@puri.sm>

On Tue, Dec 22, 2020 at 04:13:45PM +0100, Martin Kepplinger wrote:
> In order for the touchscreen interrupt line to work, describe it properly.
> Otherwise it can work if defaults are ok, but we cannot be sure.
> 
> Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index 55268fc0622e..a60df09d90f7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -459,6 +459,13 @@
>  		>;
>  	};
>  
> +	pinctrl_touch: touchgrp {
> +		fsl,pins = <
> +		/* TP_INT */
> +		MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27	0x80

Miss indentation for these two lines.

I fixed it up and applied the series.

Shawn

> +		>;
> +	};
> +
>  	pinctrl_typec: typecgrp {
>  		fsl,pins = <
>  			/* TYPEC_MUX_EN */
> @@ -880,6 +887,8 @@
>  	touchscreen@38 {
>  		compatible = "edt,edt-ft5506";
>  		reg = <0x38>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_touch>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
>  		touchscreen-size-x = <720>;
> -- 
> 2.20.1
> 

  parent reply	other threads:[~2021-01-11  0:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 15:13 [PATCH v2 0/4] small Librem 5 phone dts updates Martin Kepplinger
2020-12-22 15:13 ` Martin Kepplinger
2020-12-22 15:13 ` [PATCH v2 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 Martin Kepplinger
2020-12-22 15:13   ` Martin Kepplinger
2020-12-22 15:13 ` [PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description Martin Kepplinger
2020-12-22 15:13   ` Martin Kepplinger
2020-12-23  9:58   ` Krzysztof Kozlowski
2020-12-23  9:58     ` Krzysztof Kozlowski
2021-01-11  0:29   ` Shawn Guo [this message]
2021-01-11  0:29     ` Shawn Guo
2021-01-11  8:24     ` Martin Kepplinger
2021-01-11  8:24       ` Martin Kepplinger
2020-12-22 15:13 ` [PATCH v2 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT Martin Kepplinger
2020-12-22 15:13   ` Martin Kepplinger
2020-12-23  9:58   ` Krzysztof Kozlowski
2020-12-23  9:58     ` Krzysztof Kozlowski
2020-12-22 15:13 ` [PATCH v2 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage Martin Kepplinger
2020-12-22 15:13   ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111002942.GR28365@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.