All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"HAGIO KAZUHITO(萩尾 一仁)" <k-hagio-ab@nec.com>
Cc: "lijiang@redhat.com" <lijiang@redhat.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alexander Egorenkov <egorenar@linux.ibm.com>,
	"ktkhai@virtuozzo.com" <ktkhai@virtuozzo.com>,
	"ebiederm@xmission.com" <ebiederm@xmission.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"dyoung@redhat.com" <dyoung@redhat.com>,
	"christian.brauner@ubuntu.com" <christian.brauner@ubuntu.com>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>,
	"keescook@chromium.org" <keescook@chromium.org>
Subject: Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO
Date: Mon, 11 Jan 2021 18:03:44 +0800	[thread overview]
Message-ID: <20210111100344.GF4959@MiWiFi-R3L-srv> (raw)
In-Reply-To: <X/wXU9G/+AJhb4HP@kroah.com>

On 01/11/21 at 10:16am, gregkh@linuxfoundation.org wrote:
> On Fri, Jan 08, 2021 at 06:22:24PM +0800, Baoquan He wrote:
> > On 01/08/21 at 10:07am, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > > Hi Baoquan,
> > > 
> > > -----Original Message-----
> > > > On 09/30/20 at 12:23pm, Alexander Egorenkov wrote:
> > > > > The offset of the field 'init_uts_ns.name' has changed
> > > > > since commit 9a56493f6942 ("uts: Use generic ns_common::count").
> > > > 
> > > > This patch is merged into 5.11-rc1, but we met the makedumpfile failure
> > > > of kdump test case in 5.10.0 kernel. Should affect 5.9 too since
> > > > commit 9a56493f6942 is merged into 5.9-rc2.
> > > 
> > > Hmm, commit 9a56493f6942 should have been merged into 5.11-rc1
> > > together with commit ca4a9241cc5e.
> > 
> > Checked on master branch of mainline kernel, commit 9a56493f6942 is in
> > 5.9-rc1.
> 
> 
> No, that commit is in 5.11-rc1, not 5.9-rc1:
> 	$ git describe --contains 9a56493f6942
> 	v5.11-rc1~182^2~9

Oh, then I was wrong about it. I add linux-next repo in my linux kernel
folder, so I can't get it with the above command on master branch of
mainline kernel:

[bhe@~ linux]$ git describe --contains 9a56493f6942
next-20200820~107^2~8

I just use 'git log --oneline' and found out commit 9a56493f6942 is
added before 5.9-rc1. Seems this is not right way to get the kernel
release. So please ignore the back porting request of stable tree.
Sorry about the confusion.

Thanks
Baoquan

> 
> > commit ca4a9241cc5e is merged into 5.11-rc1.
> > 
> > commit 9a56493f6942c0e2df1579986128721da96e00d8
> > Author: Kirill Tkhai <ktkhai@virtuozzo.com>
> > Date:   Mon Aug 3 13:16:21 2020 +0300
> > 
> >     uts: Use generic ns_common::count
> > 
> > 
> > commit ca4a9241cc5e718de86a34afd41972869546a5e3
> > Author: Alexander Egorenkov <egorenar@linux.ibm.com>
> > Date:   Tue Dec 15 20:45:31 2020 -0800
> > 
> >     kdump: append uts_namespace.name offset to VMCOREINFO
> 
> 
> Are you all sure this is needed in 5.10.y?
> 
> thanks,
> 
> greg k-h
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"HAGIO KAZUHITO(萩尾 一仁)" <k-hagio-ab@nec.com>
Cc: "lijiang@redhat.com" <lijiang@redhat.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Alexander Egorenkov <egorenar@linux.ibm.com>,
	"ktkhai@virtuozzo.com" <ktkhai@virtuozzo.com>,
	"ebiederm@xmission.com" <ebiederm@xmission.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"dyoung@redhat.com" <dyoung@redhat.com>,
	"christian.brauner@ubuntu.com" <christian.brauner@ubuntu.com>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>,
	"keescook@chromium.org" <keescook@chromium.org>
Subject: Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO
Date: Mon, 11 Jan 2021 18:03:44 +0800	[thread overview]
Message-ID: <20210111100344.GF4959@MiWiFi-R3L-srv> (raw)
In-Reply-To: <X/wXU9G/+AJhb4HP@kroah.com>

On 01/11/21 at 10:16am, gregkh@linuxfoundation.org wrote:
> On Fri, Jan 08, 2021 at 06:22:24PM +0800, Baoquan He wrote:
> > On 01/08/21 at 10:07am, HAGIO KAZUHITO(萩尾 一仁) wrote:
> > > Hi Baoquan,
> > > 
> > > -----Original Message-----
> > > > On 09/30/20 at 12:23pm, Alexander Egorenkov wrote:
> > > > > The offset of the field 'init_uts_ns.name' has changed
> > > > > since commit 9a56493f6942 ("uts: Use generic ns_common::count").
> > > > 
> > > > This patch is merged into 5.11-rc1, but we met the makedumpfile failure
> > > > of kdump test case in 5.10.0 kernel. Should affect 5.9 too since
> > > > commit 9a56493f6942 is merged into 5.9-rc2.
> > > 
> > > Hmm, commit 9a56493f6942 should have been merged into 5.11-rc1
> > > together with commit ca4a9241cc5e.
> > 
> > Checked on master branch of mainline kernel, commit 9a56493f6942 is in
> > 5.9-rc1.
> 
> 
> No, that commit is in 5.11-rc1, not 5.9-rc1:
> 	$ git describe --contains 9a56493f6942
> 	v5.11-rc1~182^2~9

Oh, then I was wrong about it. I add linux-next repo in my linux kernel
folder, so I can't get it with the above command on master branch of
mainline kernel:

[bhe@~ linux]$ git describe --contains 9a56493f6942
next-20200820~107^2~8

I just use 'git log --oneline' and found out commit 9a56493f6942 is
added before 5.9-rc1. Seems this is not right way to get the kernel
release. So please ignore the back porting request of stable tree.
Sorry about the confusion.

Thanks
Baoquan

> 
> > commit ca4a9241cc5e is merged into 5.11-rc1.
> > 
> > commit 9a56493f6942c0e2df1579986128721da96e00d8
> > Author: Kirill Tkhai <ktkhai@virtuozzo.com>
> > Date:   Mon Aug 3 13:16:21 2020 +0300
> > 
> >     uts: Use generic ns_common::count
> > 
> > 
> > commit ca4a9241cc5e718de86a34afd41972869546a5e3
> > Author: Alexander Egorenkov <egorenar@linux.ibm.com>
> > Date:   Tue Dec 15 20:45:31 2020 -0800
> > 
> >     kdump: append uts_namespace.name offset to VMCOREINFO
> 
> 
> Are you all sure this is needed in 5.10.y?
> 
> thanks,
> 
> greg k-h
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec


  reply	other threads:[~2021-01-11 10:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 10:23 [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO Alexander Egorenkov
2020-09-30 10:23 ` Alexander Egorenkov
2020-10-02  2:38 ` lijiang
2020-10-02  2:38   ` lijiang
2020-10-20  2:28 ` Baoquan He
2020-10-20  2:28   ` Baoquan He
2021-01-08  3:32 ` Baoquan He
2021-01-08  3:32   ` Baoquan He
2021-01-08  8:12   ` Greg KH
2021-01-08  8:12     ` Greg KH
2021-01-08  8:48     ` Baoquan He
2021-01-08  8:48       ` Baoquan He
2021-01-08 10:07   ` HAGIO KAZUHITO(萩尾 一仁)
2021-01-08 10:07     ` HAGIO KAZUHITO(萩尾 一仁)
2021-01-08 10:22     ` Baoquan He
2021-01-08 10:22       ` Baoquan He
2021-01-11  9:16       ` gregkh
2021-01-11  9:16         ` gregkh
2021-01-11 10:03         ` Baoquan He [this message]
2021-01-11 10:03           ` Baoquan He
2021-01-11  9:13   ` Greg KH
2021-01-11  9:13     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111100344.GF4959@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=egorenar@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=k-hagio-ab@nec.com \
    --cc=keescook@chromium.org \
    --cc=kexec@lists.infradead.org \
    --cc=ktkhai@virtuozzo.com \
    --cc=lijiang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.