From: Rob Herring <robh@kernel.org>
To: Timon Baetz <timon.baetz@protonmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes
Date: Mon, 11 Jan 2021 15:50:01 -0600 [thread overview]
Message-ID: <20210111215001.GA3111856@robh.at.kernel.org> (raw)
In-Reply-To: <20201230205139.1812366-2-timon.baetz@protonmail.com>
On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote:
> Add maxim,max8997-battery and maxim,max8997-muic optional nodes.
>
> Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> v6: No change.
> v5: No change.
> v4: Make extcon and charger-supply optional.
> v3: Reorder patch, no change.
> v2: Add patch.
>
> .../bindings/regulator/max8997-regulator.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
This exceeds my threshold of changes for please convert this to schema
first. However, I agree with what Mark has said already, so maybe some
of this isn't needed.
>
> diff --git a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt
> index 6fe825b8ac1b..faaf2bbf0272 100644
> --- a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt
> @@ -53,6 +53,18 @@ Additional properties required if either of the optional properties are used:
> - max8997,pmic-buck125-dvs-gpios: GPIO specifiers for three host gpio's used
> for dvs. The format of the gpio specifier depends in the gpio controller.
>
> +Optional nodes:
> +- charger: Node for configuring the charger driver.
> + Required properties:
> + - compatible: "maxim,max8997-battery"
> + Optional properties:
> + - extcon: extcon specifier for charging events
Don't use 'extcon' for new bindings. Define a connector node. USB I
suppose?
> + - charger-supply: regulator node for charging current
> +
> +- muic: Node used only by extcon consumers.
> + Required properties:
> + - compatible: "maxim,max8997-muic"
> +
> Regulators: The regulators of max8997 that have to be instantiated should be
> included in a sub-node named 'regulators'. Regulator nodes included in this
> sub-node should be of the format as listed below.
> --
> 2.25.1
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Timon Baetz <timon.baetz@protonmail.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
~postmarketos/upstreaming@lists.sr.ht,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes
Date: Mon, 11 Jan 2021 15:50:01 -0600 [thread overview]
Message-ID: <20210111215001.GA3111856@robh.at.kernel.org> (raw)
In-Reply-To: <20201230205139.1812366-2-timon.baetz@protonmail.com>
On Wed, Dec 30, 2020 at 08:52:07PM +0000, Timon Baetz wrote:
> Add maxim,max8997-battery and maxim,max8997-muic optional nodes.
>
> Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> v6: No change.
> v5: No change.
> v4: Make extcon and charger-supply optional.
> v3: Reorder patch, no change.
> v2: Add patch.
>
> .../bindings/regulator/max8997-regulator.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
This exceeds my threshold of changes for please convert this to schema
first. However, I agree with what Mark has said already, so maybe some
of this isn't needed.
>
> diff --git a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt
> index 6fe825b8ac1b..faaf2bbf0272 100644
> --- a/Documentation/devicetree/bindings/regulator/max8997-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/max8997-regulator.txt
> @@ -53,6 +53,18 @@ Additional properties required if either of the optional properties are used:
> - max8997,pmic-buck125-dvs-gpios: GPIO specifiers for three host gpio's used
> for dvs. The format of the gpio specifier depends in the gpio controller.
>
> +Optional nodes:
> +- charger: Node for configuring the charger driver.
> + Required properties:
> + - compatible: "maxim,max8997-battery"
> + Optional properties:
> + - extcon: extcon specifier for charging events
Don't use 'extcon' for new bindings. Define a connector node. USB I
suppose?
> + - charger-supply: regulator node for charging current
> +
> +- muic: Node used only by extcon consumers.
> + Required properties:
> + - compatible: "maxim,max8997-muic"
> +
> Regulators: The regulators of max8997 that have to be instantiated should be
> included in a sub-node named 'regulators'. Regulator nodes included in this
> sub-node should be of the format as listed below.
> --
> 2.25.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-11 21:51 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 20:51 [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling Timon Baetz
2020-12-30 20:51 ` Timon Baetz
2020-12-30 20:52 ` [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Timon Baetz
2020-12-30 20:52 ` Timon Baetz
2021-01-04 13:51 ` Mark Brown
2021-01-04 13:51 ` Mark Brown
2021-01-04 18:18 ` Krzysztof Kozlowski
2021-01-04 18:18 ` Krzysztof Kozlowski
2021-01-04 18:27 ` Mark Brown
2021-01-04 18:27 ` Mark Brown
2021-01-04 18:38 ` Krzysztof Kozlowski
2021-01-04 18:38 ` Krzysztof Kozlowski
2021-01-04 21:24 ` Mark Brown
2021-01-04 21:24 ` Mark Brown
2021-01-05 16:55 ` Krzysztof Kozlowski
2021-01-05 16:55 ` Krzysztof Kozlowski
2021-01-06 14:59 ` Mark Brown
2021-01-06 14:59 ` Mark Brown
2021-01-08 15:16 ` Timon Baetz
2021-01-08 15:16 ` Timon Baetz
2021-01-08 16:16 ` Mark Brown
2021-01-08 16:16 ` Mark Brown
2021-01-15 6:19 ` Timon Baetz
2021-01-15 6:19 ` Timon Baetz
2021-01-15 13:42 ` Mark Brown
2021-01-15 13:42 ` Mark Brown
2021-01-16 8:03 ` Timon Baetz
2021-01-16 8:03 ` Timon Baetz
2021-01-18 12:45 ` Mark Brown
2021-01-18 12:45 ` Mark Brown
2021-01-11 21:50 ` Rob Herring [this message]
2021-01-11 21:50 ` Rob Herring
2020-12-30 20:52 ` [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER current limit Timon Baetz
2020-12-30 20:52 ` Timon Baetz
2020-12-30 23:22 ` kernel test robot
2020-12-30 23:22 ` kernel test robot
2020-12-31 7:19 ` Timon Baetz
2020-12-31 8:23 ` Krzysztof Kozlowski
2020-12-31 8:23 ` Krzysztof Kozlowski
2020-12-31 8:55 ` Krzysztof Kozlowski
2020-12-31 8:55 ` Krzysztof Kozlowski
2021-01-03 1:53 ` Sebastian Reichel
2021-01-03 1:53 ` Sebastian Reichel
2020-12-30 20:52 ` [PATCH v6 4/8] ARM: dts: exynos: Add muic and charger nodes for I9100 Timon Baetz
2020-12-30 20:52 ` Timon Baetz
2020-12-30 20:52 ` [PATCH v6 5/8] ARM: dts: exynos: Add muic and charger nodes for Origen Timon Baetz
2020-12-30 20:52 ` Timon Baetz
2020-12-30 20:52 ` [PATCH v6 6/8] ARM: dts: exynos: Add muic and charger nodes for Trats Timon Baetz
2020-12-30 20:52 ` Timon Baetz
2020-12-30 20:53 ` [PATCH v6 7/8] ARM: dts: exynos: Fix charging regulator voltage and current for I9100 Timon Baetz
2020-12-30 20:53 ` Timon Baetz
2020-12-30 20:53 ` [PATCH v6 8/8] ARM: dts: exynos: Add top-off charging regulator node " Timon Baetz
2020-12-30 20:53 ` Timon Baetz
2021-01-03 16:32 ` (subset) [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling Krzysztof Kozlowski
2021-01-03 16:32 ` Krzysztof Kozlowski
2021-01-03 16:34 ` Krzysztof Kozlowski
2021-01-03 16:34 ` Krzysztof Kozlowski
2021-01-04 10:26 ` Chanwoo Choi
2021-01-04 10:26 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111215001.GA3111856@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
--cc=timon.baetz@protonmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.