All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Jens Axboe <axboe@fb.com>, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/3] nvme: support command retry delay for admin command
Date: Tue, 12 Jan 2021 09:06:00 +0100	[thread overview]
Message-ID: <20210112080600.GA24949@lst.de> (raw)
In-Reply-To: <20210110013316.GA4369@localhost.localdomain>

On Sun, Jan 10, 2021 at 10:33:16AM +0900, Minwoo Im wrote:
> Hello,
> 
> On 21-01-09 20:34:11, Chaitanya Kulkarni wrote:
> > On 1/8/21 06:54, Minwoo Im wrote:
> > > This feature can be applied not only I/O queue commands, but also admin
> > > queue commands.  Admin command during the initialization may fail due to
> > > some un-ready state of a controller, so it would be better to have this
> > > feature for admin commands also.
> > What is some un-ready state ?
> 
> State that controller is unable to process successfully command as
> "Command Interrupt" status code represents.

Given that controller ready has a specific meaning in NVMe I think a
different wording here would be useful.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-01-12  8:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 14:46 [PATCH 0/3] nvme: fixes for command retry Minwoo Im
2021-01-08 14:46 ` [PATCH 1/3] nvme: support command retry delay for admin command Minwoo Im
2021-01-09 20:34   ` Chaitanya Kulkarni
2021-01-10  1:33     ` Minwoo Im
2021-01-12  8:06       ` Christoph Hellwig [this message]
2021-01-12  8:06   ` Christoph Hellwig
2021-01-12  8:47     ` Minwoo Im
2021-01-14  7:22     ` Christoph Hellwig
2021-01-15 18:40       ` Minwoo Im
2021-01-08 14:46 ` [PATCH 2/3] nvme: check all retry delay times in Identify Controller Minwoo Im
2021-01-12  8:08   ` Christoph Hellwig
2021-01-12  8:40     ` Minwoo Im
2021-01-08 14:46 ` [PATCH 3/3] nvme: add parameter command_retry to enable retry Minwoo Im
2021-01-11  3:47   ` Chao Leng
2021-01-11 12:27     ` Minwoo Im
2021-01-12  9:34       ` Chao Leng
2021-01-12 11:28         ` Minwoo Im
2021-01-12  8:09   ` Christoph Hellwig
2021-01-12  8:44     ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112080600.GA24949@lst.de \
    --to=hch@lst.de \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@fb.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=minwoo.im.dev@gmail.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.