All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 3/3] nvme: add parameter command_retry to enable retry
Date: Tue, 12 Jan 2021 09:09:26 +0100	[thread overview]
Message-ID: <20210112080926.GD24949@lst.de> (raw)
In-Reply-To: <20210108144659.7126-4-minwoo.im.dev@gmail.com>

On Fri, Jan 08, 2021 at 11:46:59PM +0900, Minwoo Im wrote:
> This patch added a module parameter named command_retry to turn on the
> command retry feature in this driver.  If turning it on,
> REQ3_FAILFAST_DRIVER will not be set to requests so that retry can be
> reached out to nvme_retry_req() based on the module parameter.

Why would we want to do that, and if so why only conditional on a module
parameter?

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2021-01-12  8:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 14:46 [PATCH 0/3] nvme: fixes for command retry Minwoo Im
2021-01-08 14:46 ` [PATCH 1/3] nvme: support command retry delay for admin command Minwoo Im
2021-01-09 20:34   ` Chaitanya Kulkarni
2021-01-10  1:33     ` Minwoo Im
2021-01-12  8:06       ` Christoph Hellwig
2021-01-12  8:06   ` Christoph Hellwig
2021-01-12  8:47     ` Minwoo Im
2021-01-14  7:22     ` Christoph Hellwig
2021-01-15 18:40       ` Minwoo Im
2021-01-08 14:46 ` [PATCH 2/3] nvme: check all retry delay times in Identify Controller Minwoo Im
2021-01-12  8:08   ` Christoph Hellwig
2021-01-12  8:40     ` Minwoo Im
2021-01-08 14:46 ` [PATCH 3/3] nvme: add parameter command_retry to enable retry Minwoo Im
2021-01-11  3:47   ` Chao Leng
2021-01-11 12:27     ` Minwoo Im
2021-01-12  9:34       ` Chao Leng
2021-01-12 11:28         ` Minwoo Im
2021-01-12  8:09   ` Christoph Hellwig [this message]
2021-01-12  8:44     ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112080926.GD24949@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=minwoo.im.dev@gmail.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.