From: Rob Herring <robh@kernel.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: devicetree@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>,
linux-kernel@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
Date: Tue, 12 Jan 2021 21:20:31 -0600 [thread overview]
Message-ID: <20210113032031.GA1460993@robh.at.kernel.org> (raw)
In-Reply-To: <20210107052206.2599844-2-hsinyi@chromium.org>
On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote:
> Similar to krane-sku176 but using a different panel source.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> Change:
> v2: move compatible to board dts
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 1 +
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++
> 3 files changed, 25 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 53f0d4e3ea982..3276f7a2ce672 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -120,6 +120,7 @@ properties:
> - const: mediatek,mt8183
> - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> items:
> + - const: google,krane-sku0
> - const: google,krane-sku176
> - const: google,krane
> - const: mediatek,mt8183
This says you must have all 4 compatible strings in the order listed.
That doesn't match your dts. I assume you want the first 2 under an
'enum' so there's 3 strings with the first one being sku0 or sku176?
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: devicetree@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>,
linux-kernel@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
Date: Tue, 12 Jan 2021 21:20:31 -0600 [thread overview]
Message-ID: <20210113032031.GA1460993@robh.at.kernel.org> (raw)
In-Reply-To: <20210107052206.2599844-2-hsinyi@chromium.org>
On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote:
> Similar to krane-sku176 but using a different panel source.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> Change:
> v2: move compatible to board dts
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 1 +
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++
> 3 files changed, 25 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 53f0d4e3ea982..3276f7a2ce672 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -120,6 +120,7 @@ properties:
> - const: mediatek,mt8183
> - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> items:
> + - const: google,krane-sku0
> - const: google,krane-sku176
> - const: google,krane
> - const: mediatek,mt8183
This says you must have all 4 compatible strings in the order listed.
That doesn't match your dts. I assume you want the first 2 under an
'enum' so there's 3 strings with the first one being sku0 or sku176?
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Nicolas Boichat <drinkcat@chromium.org>,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
Date: Tue, 12 Jan 2021 21:20:31 -0600 [thread overview]
Message-ID: <20210113032031.GA1460993@robh.at.kernel.org> (raw)
In-Reply-To: <20210107052206.2599844-2-hsinyi@chromium.org>
On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote:
> Similar to krane-sku176 but using a different panel source.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> Change:
> v2: move compatible to board dts
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 1 +
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++
> 3 files changed, 25 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 53f0d4e3ea982..3276f7a2ce672 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -120,6 +120,7 @@ properties:
> - const: mediatek,mt8183
> - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> items:
> + - const: google,krane-sku0
> - const: google,krane-sku176
> - const: google,krane
> - const: mediatek,mt8183
This says you must have all 4 compatible strings in the order listed.
That doesn't match your dts. I assume you want the first 2 under an
'enum' so there's 3 strings with the first one being sku0 or sku176?
Rob
next prev parent reply other threads:[~2021-01-13 3:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 5:22 [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Hsin-Yi Wang
2021-01-07 5:22 ` Hsin-Yi Wang
2021-01-07 5:22 ` Hsin-Yi Wang
2021-01-07 5:22 ` [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board Hsin-Yi Wang
2021-01-07 5:22 ` Hsin-Yi Wang
2021-01-07 5:22 ` Hsin-Yi Wang
2021-01-13 3:20 ` Rob Herring [this message]
2021-01-13 3:20 ` Rob Herring
2021-01-13 3:20 ` Rob Herring
2021-01-13 6:23 ` Hsin-Yi Wang
2021-01-13 6:23 ` Hsin-Yi Wang
2021-01-13 6:23 ` Hsin-Yi Wang
2021-01-07 5:26 ` [PATCH v2 1/2] arm64: dts: mt8183: config dsi node Nicolas Boichat
2021-01-07 5:26 ` Nicolas Boichat
2021-01-07 5:26 ` Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113032031.GA1460993@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.