All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Piyush Mehta <piyush.mehta@xilinx.com>
Cc: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
	Michal Simek <monstr@monstr.eu>,
	kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org
Subject: [xlnx:xlnx_rebase_v5.4 935/1697] drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset'
Date: Wed, 13 Jan 2021 06:43:10 +0800	[thread overview]
Message-ID: <202101130659.0KSOvbdF-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 7629 bytes --]

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head:   629150468791671b5fde21363e643e87c5815b17
commit: 128feece434d1c02d2dfac7e4103b2c73b6afb27 [935/1697] usb: dwc3: Add support for masking phy reset signal
config: m68k-randconfig-r013-20210112 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/128feece434d1c02d2dfac7e4103b2c73b6afb27
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx xlnx_rebase_v5.4
        git checkout 128feece434d1c02d2dfac7e4103b2c73b6afb27
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/ioport.h:13,
                    from include/linux/device.h:15,
                    from include/linux/platform_device.h:13,
                    from drivers/usb/dwc3/host.c:10:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
      33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                  ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/host.c:14:
   drivers/usb/dwc3/core.h: At top level:
   drivers/usb/dwc3/core.h:1451:6: warning: no previous prototype for 'dwc3_simple_wakeup_capable' [-Wmissing-prototypes]
    1451 | void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1453:6: warning: no previous prototype for 'dwc3_set_simple_data' [-Wmissing-prototypes]
    1453 | void dwc3_set_simple_data(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1455:6: warning: no previous prototype for 'dwc3_simple_check_quirks' [-Wmissing-prototypes]
    1455 | void dwc3_simple_check_quirks(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1457:5: warning: no previous prototype for 'dwc3_set_usb_core_power' [-Wmissing-prototypes]
    1457 | int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
         |     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' [-Wmissing-prototypes]
    1459 | void dwc3_mask_phy_reset(struct device *dev, bool mask)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h: In function 'dwc3_set_usb_core_power':
   drivers/usb/dwc3/core.h:1458:1: warning: control reaches end of non-void function [-Wreturn-type]
    1458 | { ; }
         | ^
--
   In file included from include/linux/err.h:5,
                    from include/linux/clk.h:12,
                    from drivers/usb/dwc3/core.c:11:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
      33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                  ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/core.c:36:
   drivers/usb/dwc3/core.h: At top level:
   drivers/usb/dwc3/core.h:1451:6: warning: no previous prototype for 'dwc3_simple_wakeup_capable' [-Wmissing-prototypes]
    1451 | void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1453:6: warning: no previous prototype for 'dwc3_set_simple_data' [-Wmissing-prototypes]
    1453 | void dwc3_set_simple_data(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1455:6: warning: no previous prototype for 'dwc3_simple_check_quirks' [-Wmissing-prototypes]
    1455 | void dwc3_simple_check_quirks(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1457:5: warning: no previous prototype for 'dwc3_set_usb_core_power' [-Wmissing-prototypes]
    1457 | int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
         |     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' [-Wmissing-prototypes]
    1459 | void dwc3_mask_phy_reset(struct device *dev, bool mask)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:386:6: warning: no previous prototype for 'dwc3_free_event_buffers' [-Wmissing-prototypes]
     386 | void dwc3_free_event_buffers(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:403:5: warning: no previous prototype for 'dwc3_alloc_event_buffers' [-Wmissing-prototypes]
     403 | int dwc3_alloc_event_buffers(struct dwc3 *dwc, unsigned length)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:977:5: warning: no previous prototype for 'dwc3_core_init' [-Wmissing-prototypes]
     977 | int dwc3_core_init(struct dwc3 *dwc)
         |     ^~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/core.c:36:
   drivers/usb/dwc3/core.h: In function 'dwc3_set_usb_core_power':
   drivers/usb/dwc3/core.h:1458:1: warning: control reaches end of non-void function [-Wreturn-type]
    1458 | { ; }
         | ^


vim +/dwc3_mask_phy_reset +1459 drivers/usb/dwc3/core.h

  1440	
  1441	#if IS_ENABLED(CONFIG_USB_DWC3_OF_SIMPLE)
  1442	int dwc3_enable_hw_coherency(struct device *dev);
  1443	void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup);
  1444	void dwc3_set_simple_data(struct dwc3 *dwc);
  1445	void dwc3_simple_check_quirks(struct dwc3 *dwc);
  1446	int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on);
  1447	void dwc3_mask_phy_reset(struct device *dev, bool mask);
  1448	#else
  1449	static inline int dwc3_enable_hw_coherency(struct device *dev)
  1450	{ return 1; }
  1451	void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
  1452	{ ; }
  1453	void dwc3_set_simple_data(struct dwc3 *dwc)
  1454	{ ; }
  1455	void dwc3_simple_check_quirks(struct dwc3 *dwc)
  1456	{ ; }
  1457	int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
  1458	{ ; }
> 1459	void dwc3_mask_phy_reset(struct device *dev, bool mask)
  1460	{ ; }
  1461	#endif
  1462	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23103 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [xlnx:xlnx_rebase_v5.4 935/1697] drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset'
Date: Wed, 13 Jan 2021 06:43:10 +0800	[thread overview]
Message-ID: <202101130659.0KSOvbdF-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 7768 bytes --]

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head:   629150468791671b5fde21363e643e87c5815b17
commit: 128feece434d1c02d2dfac7e4103b2c73b6afb27 [935/1697] usb: dwc3: Add support for masking phy reset signal
config: m68k-randconfig-r013-20210112 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/Xilinx/linux-xlnx/commit/128feece434d1c02d2dfac7e4103b2c73b6afb27
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx xlnx_rebase_v5.4
        git checkout 128feece434d1c02d2dfac7e4103b2c73b6afb27
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/ioport.h:13,
                    from include/linux/device.h:15,
                    from include/linux/platform_device.h:13,
                    from drivers/usb/dwc3/host.c:10:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
      33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                  ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/host.c:14:
   drivers/usb/dwc3/core.h: At top level:
   drivers/usb/dwc3/core.h:1451:6: warning: no previous prototype for 'dwc3_simple_wakeup_capable' [-Wmissing-prototypes]
    1451 | void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1453:6: warning: no previous prototype for 'dwc3_set_simple_data' [-Wmissing-prototypes]
    1453 | void dwc3_set_simple_data(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1455:6: warning: no previous prototype for 'dwc3_simple_check_quirks' [-Wmissing-prototypes]
    1455 | void dwc3_simple_check_quirks(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1457:5: warning: no previous prototype for 'dwc3_set_usb_core_power' [-Wmissing-prototypes]
    1457 | int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
         |     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' [-Wmissing-prototypes]
    1459 | void dwc3_mask_phy_reset(struct device *dev, bool mask)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h: In function 'dwc3_set_usb_core_power':
   drivers/usb/dwc3/core.h:1458:1: warning: control reaches end of non-void function [-Wreturn-type]
    1458 | { ; }
         | ^
--
   In file included from include/linux/err.h:5,
                    from include/linux/clk.h:12,
                    from drivers/usb/dwc3/core.c:11:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra]
      33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                  ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/core.c:36:
   drivers/usb/dwc3/core.h: At top level:
   drivers/usb/dwc3/core.h:1451:6: warning: no previous prototype for 'dwc3_simple_wakeup_capable' [-Wmissing-prototypes]
    1451 | void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1453:6: warning: no previous prototype for 'dwc3_set_simple_data' [-Wmissing-prototypes]
    1453 | void dwc3_set_simple_data(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1455:6: warning: no previous prototype for 'dwc3_simple_check_quirks' [-Wmissing-prototypes]
    1455 | void dwc3_simple_check_quirks(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.h:1457:5: warning: no previous prototype for 'dwc3_set_usb_core_power' [-Wmissing-prototypes]
    1457 | int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
         |     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' [-Wmissing-prototypes]
    1459 | void dwc3_mask_phy_reset(struct device *dev, bool mask)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:386:6: warning: no previous prototype for 'dwc3_free_event_buffers' [-Wmissing-prototypes]
     386 | void dwc3_free_event_buffers(struct dwc3 *dwc)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:403:5: warning: no previous prototype for 'dwc3_alloc_event_buffers' [-Wmissing-prototypes]
     403 | int dwc3_alloc_event_buffers(struct dwc3 *dwc, unsigned length)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/usb/dwc3/core.c:977:5: warning: no previous prototype for 'dwc3_core_init' [-Wmissing-prototypes]
     977 | int dwc3_core_init(struct dwc3 *dwc)
         |     ^~~~~~~~~~~~~~
   In file included from drivers/usb/dwc3/core.c:36:
   drivers/usb/dwc3/core.h: In function 'dwc3_set_usb_core_power':
   drivers/usb/dwc3/core.h:1458:1: warning: control reaches end of non-void function [-Wreturn-type]
    1458 | { ; }
         | ^


vim +/dwc3_mask_phy_reset +1459 drivers/usb/dwc3/core.h

  1440	
  1441	#if IS_ENABLED(CONFIG_USB_DWC3_OF_SIMPLE)
  1442	int dwc3_enable_hw_coherency(struct device *dev);
  1443	void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup);
  1444	void dwc3_set_simple_data(struct dwc3 *dwc);
  1445	void dwc3_simple_check_quirks(struct dwc3 *dwc);
  1446	int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on);
  1447	void dwc3_mask_phy_reset(struct device *dev, bool mask);
  1448	#else
  1449	static inline int dwc3_enable_hw_coherency(struct device *dev)
  1450	{ return 1; }
  1451	void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
  1452	{ ; }
  1453	void dwc3_set_simple_data(struct dwc3 *dwc)
  1454	{ ; }
  1455	void dwc3_simple_check_quirks(struct dwc3 *dwc)
  1456	{ ; }
  1457	int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
  1458	{ ; }
> 1459	void dwc3_mask_phy_reset(struct device *dev, bool mask)
  1460	{ ; }
  1461	#endif
  1462	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 23103 bytes --]

             reply	other threads:[~2021-01-12 22:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 22:43 kernel test robot [this message]
2021-01-12 22:43 ` [xlnx:xlnx_rebase_v5.4 935/1697] drivers/usb/dwc3/core.h:1459:6: warning: no previous prototype for 'dwc3_mask_phy_reset' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202101130659.0KSOvbdF-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=anurag.kumar.vulisha@xilinx.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=monstr@monstr.eu \
    --cc=piyush.mehta@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.