All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-kernel@vger.kernel.org, "Lee Jones" <lee.jones@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Heiko Stuebner" <heiko.stuebner@theobroma-systems.com>,
	"Stephan Gerhold" <stephan@gerhold.net>,
	"Lubomir Rintel" <lkundrak@v3.sk>,
	"Mark Brown" <broonie@kernel.org>, allen <allen.chen@ite.com.tw>,
	"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
	linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Josua Mayer" <josua.mayer@jm0.eu>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Daniel Palmer" <daniel@0x0f.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC
Date: Wed, 13 Jan 2021 23:46:45 +0100	[thread overview]
Message-ID: <20210113234645.52fcf73c@aktux> (raw)
In-Reply-To: <20210112203902.4e196d11@aktux>

On Tue, 12 Jan 2021 20:39:02 +0100
Andreas Kemnade <andreas@kemnade.info> wrote:

[...]
> > +static int ntxec_pwm_probe(struct platform_device *pdev)
> > +{
> > +	struct ntxec *ec = dev_get_drvdata(pdev->dev.parent);
> > +	struct ntxec_pwm *priv;
> > +	struct pwm_chip *chip;
> > +
> > +	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> > +	if (!priv)
> > +		return -ENOMEM;
> > +
> > +	priv->ec = ec;
> > +	priv->dev = &pdev->dev;
> > +
> > +	platform_set_drvdata(pdev, priv);
> > +
> > +	chip = &priv->chip;
> > +	chip->dev = &pdev->dev;  
> 
> Hmm, I needed
> chip->dev = &pdev->dev.parent to use the backlight example
> in patch 2/7.
> Not sure what the correct solution is. Maybe the pwm deserves its own
> devicetree node.
> 
probably just assigning the node from the parent.

   pdev->dev.of_node = pdev->dev.parent->of_node;

Regards,
Andreas

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Kemnade <andreas@kemnade.info>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	linux-pwm@vger.kernel.org,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	linux-rtc@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
	"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Daniel Palmer" <daniel@0x0f.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	devicetree@vger.kernel.org,
	"Stephan Gerhold" <stephan@gerhold.net>,
	allen <allen.chen@ite.com.tw>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Lubomir Rintel" <lkundrak@v3.sk>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	linux-kernel@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Heiko Stuebner" <heiko.stuebner@theobroma-systems.com>,
	"Josua Mayer" <josua.mayer@jm0.eu>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC
Date: Wed, 13 Jan 2021 23:46:45 +0100	[thread overview]
Message-ID: <20210113234645.52fcf73c@aktux> (raw)
In-Reply-To: <20210112203902.4e196d11@aktux>

On Tue, 12 Jan 2021 20:39:02 +0100
Andreas Kemnade <andreas@kemnade.info> wrote:

[...]
> > +static int ntxec_pwm_probe(struct platform_device *pdev)
> > +{
> > +	struct ntxec *ec = dev_get_drvdata(pdev->dev.parent);
> > +	struct ntxec_pwm *priv;
> > +	struct pwm_chip *chip;
> > +
> > +	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> > +	if (!priv)
> > +		return -ENOMEM;
> > +
> > +	priv->ec = ec;
> > +	priv->dev = &pdev->dev;
> > +
> > +	platform_set_drvdata(pdev, priv);
> > +
> > +	chip = &priv->chip;
> > +	chip->dev = &pdev->dev;  
> 
> Hmm, I needed
> chip->dev = &pdev->dev.parent to use the backlight example
> in patch 2/7.
> Not sure what the correct solution is. Maybe the pwm deserves its own
> devicetree node.
> 
probably just assigning the node from the parent.

   pdev->dev.of_node = pdev->dev.parent->of_node;

Regards,
Andreas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-14  2:02 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 18:02 [PATCH v7 0/7] Netronix embedded controller driver for Kobo and Tolino ebook readers Jonathan Neuschäfer
2021-01-09 18:02 ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 1/7] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
2021-01-09 18:02   ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 2/7] dt-bindings: mfd: Add binding for Netronix embedded controller Jonathan Neuschäfer
2021-01-09 18:02   ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 3/7] mfd: Add base driver " Jonathan Neuschäfer
2021-01-09 18:02   ` Jonathan Neuschäfer
2021-01-12 19:36   ` Andreas Kemnade
2021-01-12 19:36     ` Andreas Kemnade
2021-01-13  8:03     ` Lee Jones
2021-01-13  8:03       ` Lee Jones
2021-01-14 18:56     ` Jonathan Neuschäfer
2021-01-14 18:56       ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC Jonathan Neuschäfer
2021-01-09 18:02   ` Jonathan Neuschäfer
2021-01-11  9:13   ` Uwe Kleine-König
2021-01-11  9:13     ` Uwe Kleine-König
2021-01-11 12:53   ` Thierry Reding
2021-01-11 12:53     ` Thierry Reding
2021-01-11 16:42     ` Lee Jones
2021-01-11 16:42       ` Lee Jones
2021-01-12 19:39   ` Andreas Kemnade
2021-01-12 19:39     ` Andreas Kemnade
2021-01-13 22:46     ` Andreas Kemnade [this message]
2021-01-13 22:46       ` Andreas Kemnade
2021-01-14 22:31       ` Jonathan Neuschäfer
2021-01-14 22:31         ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 5/7] rtc: New driver for RTC in Netronix embedded controller Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 6/7] MAINTAINERS: Add entry for " Jonathan Neuschäfer
2021-01-09 18:02   ` Jonathan Neuschäfer
2021-01-09 18:02 ` [PATCH v7 7/7] ARM: dts: imx50-kobo-aura: Add " Jonathan Neuschäfer
2021-01-09 18:02   ` Jonathan Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113234645.52fcf73c@aktux \
    --to=andreas@kemnade.info \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allen.chen@ite.com.tw \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=daniel@0x0f.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=heiko.stuebner@theobroma-systems.com \
    --cc=heiko@sntech.de \
    --cc=j.neuschaefer@gmx.net \
    --cc=josua.mayer@jm0.eu \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=shawnguo@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.