From: Mike Rapoport <rppt@kernel.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm: memblock: remove return value of memblock_free_all()
Date: Thu, 14 Jan 2021 13:38:07 +0000 [thread overview]
Message-ID: <20210114133807.GK1106298@kernel.org> (raw)
In-Reply-To: <20210114070817.GA2868715@AD01715016>
On Thu, Jan 14, 2021 at 04:08:17PM +0900, Daeseok Youn wrote:
> No one checks the return value of memblock_free_all().
> Make the return value void.
>
> memblock_free_all() is used on mem_init() for each
> architecture, and the total count of freed pages will be added
> to _totalram_pages variable by calling totalram_pages_add().
>
> so do not need to return total count of freed pages.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Applied to memblock/for-next, thanks!
--
Sincerely yours,
Mike.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm: memblock: remove return value of memblock_free_all()
Date: Thu, 14 Jan 2021 15:38:07 +0200 [thread overview]
Message-ID: <20210114133807.GK1106298@kernel.org> (raw)
In-Reply-To: <20210114070817.GA2868715@AD01715016>
On Thu, Jan 14, 2021 at 04:08:17PM +0900, Daeseok Youn wrote:
> No one checks the return value of memblock_free_all().
> Make the return value void.
>
> memblock_free_all() is used on mem_init() for each
> architecture, and the total count of freed pages will be added
> to _totalram_pages variable by calling totalram_pages_add().
>
> so do not need to return total count of freed pages.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Applied to memblock/for-next, thanks!
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-01-14 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 7:08 [PATCH] mm: memblock: remove return value of memblock_free_all() Daeseok Youn
2021-01-14 7:08 ` Daeseok Youn
2021-01-14 9:21 ` David Hildenbrand
2021-01-14 9:21 ` David Hildenbrand
2021-01-14 13:38 ` Mike Rapoport [this message]
2021-01-14 13:38 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114133807.GK1106298@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=daeseok.youn@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.