* [PATCH] x86/mm/mtrr: remove definition of DEBUG
@ 2021-01-14 16:27 trix
2021-01-14 18:46 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2021-01-14 16:27 UTC (permalink / raw)
To: tglx, mingo, bp, hpa, ying-tsun.huang, peterz; +Cc: x86, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
Defining DEBUG should only be done in development.
So remove DEBUG.
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/x86/kernel/cpu/mtrr/generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index a29997e6cf9e..b90f3f437765 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -3,7 +3,6 @@
* This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
* because MTRRs can span up to 40 bits (36bits on most modern x86)
*/
-#define DEBUG
#include <linux/export.h>
#include <linux/init.h>
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/mm/mtrr: remove definition of DEBUG
2021-01-14 16:27 [PATCH] x86/mm/mtrr: remove definition of DEBUG trix
@ 2021-01-14 18:46 ` Borislav Petkov
2021-01-14 19:25 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2021-01-14 18:46 UTC (permalink / raw)
To: trix; +Cc: tglx, mingo, hpa, ying-tsun.huang, peterz, x86, linux-kernel
On Thu, Jan 14, 2021 at 08:27:43AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Defining DEBUG should only be done in development.
> So remove DEBUG.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> arch/x86/kernel/cpu/mtrr/generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
> index a29997e6cf9e..b90f3f437765 100644
> --- a/arch/x86/kernel/cpu/mtrr/generic.c
> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -3,7 +3,6 @@
> * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
> * because MTRRs can span up to 40 bits (36bits on most modern x86)
> */
> -#define DEBUG
>
> #include <linux/export.h>
> #include <linux/init.h>
Wanna merge all 4 in arch/x86/
arch/x86/kernel/cpu/mtrr/generic.c:6:#define DEBUG
arch/x86/kernel/cpu/mtrr/mtrr.c:34:#define DEBUG
arch/x86/kernel/pci-iommu_table.c:8:#define DEBUG 1
arch/x86/mm/mmio-mod.c:13:#define DEBUG 1
into a single patch?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/mm/mtrr: remove definition of DEBUG
2021-01-14 18:46 ` Borislav Petkov
@ 2021-01-14 19:25 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2021-01-14 19:25 UTC (permalink / raw)
To: Borislav Petkov
Cc: tglx, mingo, hpa, ying-tsun.huang, peterz, x86, linux-kernel
On 1/14/21 10:46 AM, Borislav Petkov wrote:
> On Thu, Jan 14, 2021 at 08:27:43AM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> Defining DEBUG should only be done in development.
>> So remove DEBUG.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> arch/x86/kernel/cpu/mtrr/generic.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
>> index a29997e6cf9e..b90f3f437765 100644
>> --- a/arch/x86/kernel/cpu/mtrr/generic.c
>> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
>> @@ -3,7 +3,6 @@
>> * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
>> * because MTRRs can span up to 40 bits (36bits on most modern x86)
>> */
>> -#define DEBUG
>>
>> #include <linux/export.h>
>> #include <linux/init.h>
> Wanna merge all 4 in arch/x86/
>
> arch/x86/kernel/cpu/mtrr/generic.c:6:#define DEBUG
> arch/x86/kernel/cpu/mtrr/mtrr.c:34:#define DEBUG
> arch/x86/kernel/pci-iommu_table.c:8:#define DEBUG 1
> arch/x86/mm/mmio-mod.c:13:#define DEBUG 1
>
> into a single patch?
Yes, i'll take care of that.
Tom
> Thx.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-14 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-14 16:27 [PATCH] x86/mm/mtrr: remove definition of DEBUG trix
2021-01-14 18:46 ` Borislav Petkov
2021-01-14 19:25 ` Tom Rix
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.