* [Buildroot] [PATCH] uboot: fix binman with a new dependency
@ 2021-01-12 9:18 Francois Perrad
2021-01-14 21:49 ` Yann E. MORIN
2021-01-14 22:11 ` Michael Walle
0 siblings, 2 replies; 4+ messages in thread
From: Francois Perrad @ 2021-01-12 9:18 UTC (permalink / raw)
To: buildroot
since 2021.01, tools/binman is broken.
tools/binman/control.py imports pkg_resources
the module pkg_resources is supplied by setuptools,
so this new dependency is required.
binman is used only for building SPL
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
boot/uboot/uboot.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index d2b4e8dc6..a3d949a55 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -167,8 +167,14 @@ endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
UBOOT_DEPENDENCIES += host-python
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python-setuptools
+endif
else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
UBOOT_DEPENDENCIES += host-python3
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python3-setuptools
+endif
endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] uboot: fix binman with a new dependency
2021-01-12 9:18 [Buildroot] [PATCH] uboot: fix binman with a new dependency Francois Perrad
@ 2021-01-14 21:49 ` Yann E. MORIN
2021-01-14 22:11 ` Michael Walle
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-01-14 21:49 UTC (permalink / raw)
To: buildroot
Fran?ois, All,
On 2021-01-12 10:18 +0100, Francois Perrad spake thusly:
> since 2021.01, tools/binman is broken.
> tools/binman/control.py imports pkg_resources
> the module pkg_resources is supplied by setuptools,
> so this new dependency is required.
>
> binman is used only for building SPL
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Cross-referencing the actual bump-patch:
boot/uboot: bump to version 2021.01
https://patchwork.ozlabs.org/project/buildroot/patch/20210111213312.6375-1-michael at walle.cc/
Could you guys work on a single patch doing the bump with associated
fixes if need be, please?
Regards,
Yann E. MORIN.
> ---
> boot/uboot/uboot.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index d2b4e8dc6..a3d949a55 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -167,8 +167,14 @@ endif
>
> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
> UBOOT_DEPENDENCIES += host-python
> +ifeq ($(BR2_TARGET_UBOOT_SPL),y)
> +UBOOT_DEPENDENCIES += host-python-setuptools
> +endif
> else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
> UBOOT_DEPENDENCIES += host-python3
> +ifeq ($(BR2_TARGET_UBOOT_SPL),y)
> +UBOOT_DEPENDENCIES += host-python3-setuptools
> +endif
> endif
>
> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
> --
> 2.27.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] uboot: fix binman with a new dependency
2021-01-12 9:18 [Buildroot] [PATCH] uboot: fix binman with a new dependency Francois Perrad
2021-01-14 21:49 ` Yann E. MORIN
@ 2021-01-14 22:11 ` Michael Walle
2021-01-15 17:01 ` François Perrad
1 sibling, 1 reply; 4+ messages in thread
From: Michael Walle @ 2021-01-14 22:11 UTC (permalink / raw)
To: buildroot
Hi Francois,
Am 2021-01-12 10:18, schrieb Francois Perrad:
> since 2021.01, tools/binman is broken.
> tools/binman/control.py imports pkg_resources
> the module pkg_resources is supplied by setuptools,
> so this new dependency is required.
>
> binman is used only for building SPL
is it? AFAIK binman is just for generating images and can as
well be used without SPL. There is also a CONFIG_BINMAN.
I don't know if we could check the u-boot config for that.
Otherwise, I guess we'd need yet another "u-boot uses binman"
config option. I don't think checking of SPL is enough.
-michael
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> boot/uboot/uboot.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index d2b4e8dc6..a3d949a55 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -167,8 +167,14 @@ endif
>
> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
> UBOOT_DEPENDENCIES += host-python
> +ifeq ($(BR2_TARGET_UBOOT_SPL),y)
> +UBOOT_DEPENDENCIES += host-python-setuptools
> +endif
> else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
> UBOOT_DEPENDENCIES += host-python3
> +ifeq ($(BR2_TARGET_UBOOT_SPL),y)
> +UBOOT_DEPENDENCIES += host-python3-setuptools
> +endif
> endif
>
> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] uboot: fix binman with a new dependency
2021-01-14 22:11 ` Michael Walle
@ 2021-01-15 17:01 ` François Perrad
0 siblings, 0 replies; 4+ messages in thread
From: François Perrad @ 2021-01-15 17:01 UTC (permalink / raw)
To: buildroot
Le ven. 15 janv. 2021 ? 16:36, Michael Walle <michael@walle.cc> a ?crit :
> Hi Francois,
>
> Am 2021-01-12 10:18, schrieb Francois Perrad:
> > since 2021.01, tools/binman is broken.
> > tools/binman/control.py imports pkg_resources
> > the module pkg_resources is supplied by setuptools,
> > so this new dependency is required.
> >
> > binman is used only for building SPL
>
> is it? AFAIK binman is just for generating images and can as
> well be used without SPL. There is also a CONFIG_BINMAN.
> I don't know if we could check the u-boot config for that.
> Otherwise, I guess we'd need yet another "u-boot uses binman"
> config option. I don't think checking of SPL is enough.
>
>
setuptools is a very small package (compared to python itself).
so, I will added it unconditionally with python.
Fran?ois
-michael
>
> >
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> > ---
> > boot/uboot/uboot.mk | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> > index d2b4e8dc6..a3d949a55 100644
> > --- a/boot/uboot/uboot.mk
> > +++ b/boot/uboot/uboot.mk
> > @@ -167,8 +167,14 @@ endif
> >
> > ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
> > UBOOT_DEPENDENCIES += host-python
> > +ifeq ($(BR2_TARGET_UBOOT_SPL),y)
> > +UBOOT_DEPENDENCIES += host-python-setuptools
> > +endif
> > else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
> > UBOOT_DEPENDENCIES += host-python3
> > +ifeq ($(BR2_TARGET_UBOOT_SPL),y)
> > +UBOOT_DEPENDENCIES += host-python3-setuptools
> > +endif
> > endif
> >
> > ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210115/278437a9/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-15 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-12 9:18 [Buildroot] [PATCH] uboot: fix binman with a new dependency Francois Perrad
2021-01-14 21:49 ` Yann E. MORIN
2021-01-14 22:11 ` Michael Walle
2021-01-15 17:01 ` François Perrad
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.