All of lore.kernel.org
 help / color / mirror / Atom feed
* [rdma:wip/jgg-for-next 13/14] drivers/infiniband/sw/rxe/rxe_pool.c:360:21-31: ERROR: function rxe_alloc_nl called on line 385 inside lock on line 384 but uses GFP_KERNEL
@ 2021-01-14 15:58 kernel test robot
  2021-01-14 15:58 ` [PATCH] RDMA/rxe: fix call_kern.cocci warnings kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-01-14 15:58 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Doug Ledford <dledford@redhat.com>
CC: Jason Gunthorpe <jgg+lists@ziepe.ca>
CC: linux-rdma(a)vger.kernel.org
TO: Bob Pearson <rpearsonhpe@gmail.com>
CC: Jason Gunthorpe <jgg@nvidia.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head:   8a48ac7f6c24973863b42d03156d5e34c46c2971
commit: 3853c35e243d56238159e8365b6aca410bdd4576 [13/14] RDMA/rxe: Add unlocked versions of pool APIs
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-c002-20210114 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/infiniband/sw/rxe/rxe_pool.c:360:21-31: ERROR: function rxe_alloc_nl called on line 385 inside lock on line 384 but uses GFP_KERNEL

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36942 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] RDMA/rxe: fix call_kern.cocci warnings
  2021-01-14 15:58 [rdma:wip/jgg-for-next 13/14] drivers/infiniband/sw/rxe/rxe_pool.c:360:21-31: ERROR: function rxe_alloc_nl called on line 385 inside lock on line 384 but uses GFP_KERNEL kernel test robot
@ 2021-01-14 15:58 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-01-14 15:58 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Doug Ledford <dledford@redhat.com>
CC: Jason Gunthorpe <jgg+lists@ziepe.ca>
CC: linux-rdma(a)vger.kernel.org
TO: Bob Pearson <rpearsonhpe@gmail.com>
CC: Jason Gunthorpe <jgg@nvidia.com>
CC: Zhu Yanjun <zyjzyj2000@gmail.com>
CC: Doug Ledford <dledford@redhat.com>
CC: linux-rdma(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/infiniband/sw/rxe/rxe_pool.c:360:21-31: ERROR: function rxe_alloc_nl called on line 385 inside lock on line 384 but uses GFP_KERNEL

 Find functions that refer to GFP_KERNEL but are called with locks held.

Semantic patch information:
 The proposed change of converting the GFP_KERNEL is not necessarily the
 correct one.  It may be desired to unlock the lock, or to not call the
 function under the lock in the first place.

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: 3853c35e243d ("RDMA/rxe: Add unlocked versions of pool APIs")
CC: Bob Pearson <rpearsonhpe@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head:   8a48ac7f6c24973863b42d03156d5e34c46c2971
commit: 3853c35e243d56238159e8365b6aca410bdd4576 [13/14] RDMA/rxe: Add unlocked versions of pool APIs
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago

Please take the patch only if it's a positive warning. Thanks!

 rxe_pool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/infiniband/sw/rxe/rxe_pool.c
+++ b/drivers/infiniband/sw/rxe/rxe_pool.c
@@ -357,7 +357,7 @@ void *rxe_alloc_nl(struct rxe_pool *pool
 		goto out_cnt;
 
 	obj = kzalloc(info->size, (pool->flags & RXE_POOL_ATOMIC) ?
-		      GFP_ATOMIC : GFP_KERNEL);
+		      GFP_ATOMIC : GFP_ATOMIC);
 	if (!obj)
 		goto out_cnt;
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-14 15:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-14 15:58 [rdma:wip/jgg-for-next 13/14] drivers/infiniband/sw/rxe/rxe_pool.c:360:21-31: ERROR: function rxe_alloc_nl called on line 385 inside lock on line 384 but uses GFP_KERNEL kernel test robot
2021-01-14 15:58 ` [PATCH] RDMA/rxe: fix call_kern.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.