All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, festevam@gmail.com, catalin.marinas@arm.com,
	will@kernel.org, georgi.djakov@linaro.org, cdleonard@gmail.com,
	gregkh@linuxfoundation.org, kernel@pengutronix.de,
	linux-imx@nxp.com, kernel@puri.sm, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif
Date: Fri, 15 Jan 2021 17:47:39 +0800	[thread overview]
Message-ID: <20210115094738.GL28365@dragon> (raw)
In-Reply-To: <20210107121754.3295-5-martin.kepplinger@puri.sm>

On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 89e7de2e7f7a..9300be8c9b53 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>  #include "dt-bindings/input/input.h"
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/interconnect/imx8mq.h>
>  #include "imx8mq-pinfunc.h"
>  
>  / {
> @@ -522,6 +523,8 @@
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> +				interconnect-names = "dram";

Hmm, two interconnect phandles but only one name?

Shawn

>  				status = "disabled";
>  
>  				port@0 {
> -- 
> 2.20.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: kernel@puri.sm, cdleonard@gmail.com, gregkh@linuxfoundation.org,
	will@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	catalin.marinas@arm.com, festevam@gmail.com,
	georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif
Date: Fri, 15 Jan 2021 17:47:39 +0800	[thread overview]
Message-ID: <20210115094738.GL28365@dragon> (raw)
In-Reply-To: <20210107121754.3295-5-martin.kepplinger@puri.sm>

On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 89e7de2e7f7a..9300be8c9b53 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>  #include "dt-bindings/input/input.h"
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/interconnect/imx8mq.h>
>  #include "imx8mq-pinfunc.h"
>  
>  / {
> @@ -522,6 +523,8 @@
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> +				interconnect-names = "dram";

Hmm, two interconnect phandles but only one name?

Shawn

>  				status = "disabled";
>  
>  				port@0 {
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-15  9:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 12:17 [PATCH v4 0/5] imx8mq: updates for the interconnect fabric Martin Kepplinger
2021-01-07 12:17 ` Martin Kepplinger
2021-01-07 12:17 ` [PATCH v4 1/5] arm64: dts: imx8mq: Add NOC node Martin Kepplinger
2021-01-07 12:17   ` Martin Kepplinger
2021-01-15 10:47   ` Shawn Guo
2021-01-15 10:47     ` Shawn Guo
2021-01-07 12:17 ` [PATCH v4 2/5] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2021-01-07 12:17   ` Martin Kepplinger
2021-01-07 12:17 ` [PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2021-01-07 12:17   ` Martin Kepplinger
2021-01-07 12:17 ` [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2021-01-07 12:17   ` Martin Kepplinger
2021-01-15  9:47   ` Shawn Guo [this message]
2021-01-15  9:47     ` Shawn Guo
2021-01-15  9:57     ` Martin Kepplinger
2021-01-15  9:57       ` Martin Kepplinger
2021-01-15 10:01       ` Shawn Guo
2021-01-15 10:01         ` Shawn Guo
2021-01-15 10:48   ` Shawn Guo
2021-01-15 10:48     ` Shawn Guo
2021-01-07 12:17 ` [PATCH v4 5/5] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2021-01-07 12:17   ` Martin Kepplinger
2021-01-15 10:49   ` Shawn Guo
2021-01-15 10:49     ` Shawn Guo
2021-01-11  4:51 ` [PATCH v4 0/5] imx8mq: updates for the interconnect fabric Shawn Guo
2021-01-11  4:51   ` Shawn Guo
2021-01-11  7:26   ` Martin Kepplinger
2021-01-11  7:26     ` Martin Kepplinger
2021-01-11  8:21   ` [PATCH v4 2/5] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2021-01-11  8:21     ` Martin Kepplinger
2021-01-15 10:48     ` Shawn Guo
2021-01-15 10:48       ` Shawn Guo
2021-01-11  8:22   ` [PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2021-01-11  8:22     ` Martin Kepplinger
2021-01-14 19:14     ` Rob Herring
2021-01-14 19:14       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210115094738.GL28365@dragon \
    --to=shawnguo@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cdleonard@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=georgi.djakov@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.