All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	Yangbo Lu <yangbo.lu@nxp.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: fsl-ls1012a-rdb: add i2c devices
Date: Mon, 18 Jan 2021 15:36:09 +0800	[thread overview]
Message-ID: <20210118073609.GQ28365@dragon> (raw)
In-Reply-To: <20210115101613.1490837-1-paweldembicki@gmail.com>

On Fri, Jan 15, 2021 at 11:16:12AM +0100, Pawel Dembicki wrote:
> LS1012A-RDB equipped in some i2c devices:
>   - 3x GPIO Expander: PCAL9555A (NXP)
>   - Gyro: FXAS21002 (NXP)
>   - Accelerometer: FXOS8700 (NXP)
>   - Current & Power Monitor: INA220 (TI)
> 
> This patch add listed devices to dts.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
> ---
>  .../boot/dts/freescale/fsl-ls1012a-rdb.dts    | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> index d45c17620b98..12117a973eb6 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -7,6 +7,7 @@
>   */
>  /dts-v1/;
>  
> +#include <dt-bindings/interrupt-controller/irq.h>
>  #include "fsl-ls1012a.dtsi"
>  
>  / {
> @@ -33,6 +34,50 @@ &esdhc1 {
>  
>  &i2c0 {
>  	status = "okay";
> +
> +	accelerometer@1e {
> +		compatible = "nxp,fxos8700";
> +		reg = <0x1e>;
> +		interrupt-parent = <&gpio26>;
> +		interrupts = <13 IRQ_TYPE_EDGE_RISING>;
> +		interrupt-names = "INT1";
> +	};
> +
> +	gyroscope@20 {

Please sort these device node in unit-address.

Shawn

> +		compatible = "nxp,fxas21002c";
> +		reg = <0x20>;
> +	};
> +
> +	gpio@24 {
> +		compatible = "nxp,pcal9555a";
> +		reg = <0x24>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	gpio@25 {
> +		compatible = "nxp,pcal9555a";
> +		reg = <0x25>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	gpio26: gpio@26 {
> +		compatible = "nxp,pcal9555a";
> +		reg = <0x26>;
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	current-sensor@40 {
> +		compatible = "ti,ina220";
> +		reg = <0x40>;
> +		shunt-resistor = <2000>;
> +	};
>  };
>  
>  &qspi {
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Yangbo Lu <yangbo.lu@nxp.com>, Li Yang <leoyang.li@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: fsl-ls1012a-rdb: add i2c devices
Date: Mon, 18 Jan 2021 15:36:09 +0800	[thread overview]
Message-ID: <20210118073609.GQ28365@dragon> (raw)
In-Reply-To: <20210115101613.1490837-1-paweldembicki@gmail.com>

On Fri, Jan 15, 2021 at 11:16:12AM +0100, Pawel Dembicki wrote:
> LS1012A-RDB equipped in some i2c devices:
>   - 3x GPIO Expander: PCAL9555A (NXP)
>   - Gyro: FXAS21002 (NXP)
>   - Accelerometer: FXOS8700 (NXP)
>   - Current & Power Monitor: INA220 (TI)
> 
> This patch add listed devices to dts.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
> ---
>  .../boot/dts/freescale/fsl-ls1012a-rdb.dts    | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> index d45c17620b98..12117a973eb6 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts
> @@ -7,6 +7,7 @@
>   */
>  /dts-v1/;
>  
> +#include <dt-bindings/interrupt-controller/irq.h>
>  #include "fsl-ls1012a.dtsi"
>  
>  / {
> @@ -33,6 +34,50 @@ &esdhc1 {
>  
>  &i2c0 {
>  	status = "okay";
> +
> +	accelerometer@1e {
> +		compatible = "nxp,fxos8700";
> +		reg = <0x1e>;
> +		interrupt-parent = <&gpio26>;
> +		interrupts = <13 IRQ_TYPE_EDGE_RISING>;
> +		interrupt-names = "INT1";
> +	};
> +
> +	gyroscope@20 {

Please sort these device node in unit-address.

Shawn

> +		compatible = "nxp,fxas21002c";
> +		reg = <0x20>;
> +	};
> +
> +	gpio@24 {
> +		compatible = "nxp,pcal9555a";
> +		reg = <0x24>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	gpio@25 {
> +		compatible = "nxp,pcal9555a";
> +		reg = <0x25>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	gpio26: gpio@26 {
> +		compatible = "nxp,pcal9555a";
> +		reg = <0x26>;
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
> +	current-sensor@40 {
> +		compatible = "ti,ina220";
> +		reg = <0x40>;
> +		shunt-resistor = <2000>;
> +	};
>  };
>  
>  &qspi {
> -- 
> 2.25.1
> 

  parent reply	other threads:[~2021-01-18  7:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 10:16 [PATCH 1/2] arm64: dts: fsl-ls1012a-rdb: add i2c devices Pawel Dembicki
2021-01-15 10:16 ` Pawel Dembicki
2021-01-15 10:16 ` [PATCH 2/2] arm64: dts: fsl-ls1012a-frdm: add spi-uart device Pawel Dembicki
2021-01-15 10:16   ` Pawel Dembicki
2021-01-18  7:38   ` Shawn Guo
2021-01-18  7:38     ` Shawn Guo
2021-01-18  7:36 ` Shawn Guo [this message]
2021-01-18  7:36   ` [PATCH 1/2] arm64: dts: fsl-ls1012a-rdb: add i2c devices Shawn Guo
2021-01-18 10:08   ` Paweł Dembicki
2021-01-18 10:08     ` Paweł Dembicki
2021-01-19  9:03     ` Shawn Guo
2021-01-19  9:03       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118073609.GQ28365@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paweldembicki@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yangbo.lu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.