All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/grpc: drop host gcc 4.8 workaround
@ 2021-01-18  9:46 Michael Nosthoff
  2021-01-18 21:23 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Nosthoff @ 2021-01-18  9:46 UTC (permalink / raw)
  To: buildroot

Due to libabseil dependencies the host gcc is at least 4.9.
So the fix for host gcc 4.8 is no longer needed.

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
 package/grpc/grpc.mk | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/package/grpc/grpc.mk b/package/grpc/grpc.mk
index 8585b6bdc3..f7ddffd386 100644
--- a/package/grpc/grpc.mk
+++ b/package/grpc/grpc.mk
@@ -72,13 +72,5 @@ HOST_GRPC_CONF_OPTS = \
 	-DgRPC_SSL_PROVIDER=package \
 	-DgRPC_ZLIB_PROVIDER=package
 
-# With gcc 4.8 (at least on ubuntu) there is a bug in LTO which breaks
-# the linkage of the grpc_cpp_plugin with libprotobuf and pthread. This
-# additional flag fixes this.
-ifeq ($(BR2_HOST_GCC_AT_LEAST_4_9),)
-HOST_GRPC_CONF_OPTS += \
-	-DCMAKE_EXE_LINKER_FLAGS="$(HOST_LDFLAGS) -Wl,--no-as-needed"
-endif
-
 $(eval $(cmake-package))
 $(eval $(host-cmake-package))
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/grpc: drop host gcc 4.8 workaround
  2021-01-18  9:46 [Buildroot] [PATCH] package/grpc: drop host gcc 4.8 workaround Michael Nosthoff
@ 2021-01-18 21:23 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-01-18 21:23 UTC (permalink / raw)
  To: buildroot

On Mon, 18 Jan 2021 10:46:33 +0100
Michael Nosthoff via buildroot <buildroot@busybox.net> wrote:

> Due to libabseil dependencies the host gcc is at least 4.9.
> So the fix for host gcc 4.8 is no longer needed.
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
>  package/grpc/grpc.mk | 8 --------
>  1 file changed, 8 deletions(-)

Well spotted, applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-18 21:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-18  9:46 [Buildroot] [PATCH] package/grpc: drop host gcc 4.8 workaround Michael Nosthoff
2021-01-18 21:23 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.