From: kernel test robot <lkp@intel.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Ming Lei <ming.lei@redhat.com>, Omar Sandoval <osandov@fb.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumanesh Samanta <sumanesh.samanta@broadcom.com>,
"Ewan D . Milne" <emilne@redhat.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH V6 02/13] sbitmap: maintain allocation round_robin in sbitmap
Date: Mon, 18 Jan 2021 12:42:07 +0800 [thread overview]
Message-ID: <202101181225.2uTanVzh-lkp@intel.com> (raw)
In-Reply-To: <20210118004921.202545-3-ming.lei@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 6849 bytes --]
Hi Ming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next v5.11-rc4 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20210118-085444
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-randconfig-r001-20210118 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 95d146182fdf2315e74943b93fb3bb0cbafc5d89)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/0day-ci/linux/commit/16943bc0fa2683fd8d8554745fffe62394a42ec9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20210118-085444
git checkout 16943bc0fa2683fd8d8554745fffe62394a42ec9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/vhost/scsi.c:617:40: error: too many arguments to function call, expected 2, have 3
tag = sbitmap_get(&svq->scsi_tags, 0, false);
~~~~~~~~~~~ ^~~~~
include/linux/sbitmap.h:185:5: note: 'sbitmap_get' declared here
int sbitmap_get(struct sbitmap *sb, unsigned int alloc_hint);
^
>> drivers/vhost/scsi.c:1515:22: error: too few arguments to function call, expected 6, have 5
NUMA_NO_NODE))
^
include/linux/sbitmap.h:153:5: note: 'sbitmap_init_node' declared here
int sbitmap_init_node(struct sbitmap *sb, unsigned int depth, int shift,
^
2 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for HOTPLUG_CPU
Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE
Selected by
- PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP
vim +1515 drivers/vhost/scsi.c
25b98b64e28423b0 Mike Christie 2020-11-09 1503
25b98b64e28423b0 Mike Christie 2020-11-09 1504 static int vhost_scsi_setup_vq_cmds(struct vhost_virtqueue *vq, int max_cmds)
25b98b64e28423b0 Mike Christie 2020-11-09 1505 {
25b98b64e28423b0 Mike Christie 2020-11-09 1506 struct vhost_scsi_virtqueue *svq = container_of(vq,
25b98b64e28423b0 Mike Christie 2020-11-09 1507 struct vhost_scsi_virtqueue, vq);
25b98b64e28423b0 Mike Christie 2020-11-09 1508 struct vhost_scsi_cmd *tv_cmd;
25b98b64e28423b0 Mike Christie 2020-11-09 1509 unsigned int i;
25b98b64e28423b0 Mike Christie 2020-11-09 1510
25b98b64e28423b0 Mike Christie 2020-11-09 1511 if (svq->scsi_cmds)
25b98b64e28423b0 Mike Christie 2020-11-09 1512 return 0;
25b98b64e28423b0 Mike Christie 2020-11-09 1513
25b98b64e28423b0 Mike Christie 2020-11-09 1514 if (sbitmap_init_node(&svq->scsi_tags, max_cmds, -1, GFP_KERNEL,
25b98b64e28423b0 Mike Christie 2020-11-09 @1515 NUMA_NO_NODE))
25b98b64e28423b0 Mike Christie 2020-11-09 1516 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1517 svq->max_cmds = max_cmds;
25b98b64e28423b0 Mike Christie 2020-11-09 1518
25b98b64e28423b0 Mike Christie 2020-11-09 1519 svq->scsi_cmds = kcalloc(max_cmds, sizeof(*tv_cmd), GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1520 if (!svq->scsi_cmds) {
25b98b64e28423b0 Mike Christie 2020-11-09 1521 sbitmap_free(&svq->scsi_tags);
25b98b64e28423b0 Mike Christie 2020-11-09 1522 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1523 }
25b98b64e28423b0 Mike Christie 2020-11-09 1524
25b98b64e28423b0 Mike Christie 2020-11-09 1525 for (i = 0; i < max_cmds; i++) {
25b98b64e28423b0 Mike Christie 2020-11-09 1526 tv_cmd = &svq->scsi_cmds[i];
25b98b64e28423b0 Mike Christie 2020-11-09 1527
25b98b64e28423b0 Mike Christie 2020-11-09 1528 tv_cmd->tvc_sgl = kcalloc(VHOST_SCSI_PREALLOC_SGLS,
25b98b64e28423b0 Mike Christie 2020-11-09 1529 sizeof(struct scatterlist),
25b98b64e28423b0 Mike Christie 2020-11-09 1530 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1531 if (!tv_cmd->tvc_sgl) {
25b98b64e28423b0 Mike Christie 2020-11-09 1532 pr_err("Unable to allocate tv_cmd->tvc_sgl\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1533 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1534 }
25b98b64e28423b0 Mike Christie 2020-11-09 1535
25b98b64e28423b0 Mike Christie 2020-11-09 1536 tv_cmd->tvc_upages = kcalloc(VHOST_SCSI_PREALLOC_UPAGES,
25b98b64e28423b0 Mike Christie 2020-11-09 1537 sizeof(struct page *),
25b98b64e28423b0 Mike Christie 2020-11-09 1538 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1539 if (!tv_cmd->tvc_upages) {
25b98b64e28423b0 Mike Christie 2020-11-09 1540 pr_err("Unable to allocate tv_cmd->tvc_upages\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1541 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1542 }
25b98b64e28423b0 Mike Christie 2020-11-09 1543
25b98b64e28423b0 Mike Christie 2020-11-09 1544 tv_cmd->tvc_prot_sgl = kcalloc(VHOST_SCSI_PREALLOC_PROT_SGLS,
25b98b64e28423b0 Mike Christie 2020-11-09 1545 sizeof(struct scatterlist),
25b98b64e28423b0 Mike Christie 2020-11-09 1546 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1547 if (!tv_cmd->tvc_prot_sgl) {
25b98b64e28423b0 Mike Christie 2020-11-09 1548 pr_err("Unable to allocate tv_cmd->tvc_prot_sgl\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1549 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1550 }
25b98b64e28423b0 Mike Christie 2020-11-09 1551 }
25b98b64e28423b0 Mike Christie 2020-11-09 1552 return 0;
25b98b64e28423b0 Mike Christie 2020-11-09 1553 out:
25b98b64e28423b0 Mike Christie 2020-11-09 1554 vhost_scsi_destroy_vq_cmds(vq);
25b98b64e28423b0 Mike Christie 2020-11-09 1555 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1556 }
25b98b64e28423b0 Mike Christie 2020-11-09 1557
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44539 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH V6 02/13] sbitmap: maintain allocation round_robin in sbitmap
Date: Mon, 18 Jan 2021 12:42:07 +0800 [thread overview]
Message-ID: <202101181225.2uTanVzh-lkp@intel.com> (raw)
In-Reply-To: <20210118004921.202545-3-ming.lei@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 6964 bytes --]
Hi Ming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next v5.11-rc4 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20210118-085444
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-randconfig-r001-20210118 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 95d146182fdf2315e74943b93fb3bb0cbafc5d89)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://github.com/0day-ci/linux/commit/16943bc0fa2683fd8d8554745fffe62394a42ec9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20210118-085444
git checkout 16943bc0fa2683fd8d8554745fffe62394a42ec9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/vhost/scsi.c:617:40: error: too many arguments to function call, expected 2, have 3
tag = sbitmap_get(&svq->scsi_tags, 0, false);
~~~~~~~~~~~ ^~~~~
include/linux/sbitmap.h:185:5: note: 'sbitmap_get' declared here
int sbitmap_get(struct sbitmap *sb, unsigned int alloc_hint);
^
>> drivers/vhost/scsi.c:1515:22: error: too few arguments to function call, expected 6, have 5
NUMA_NO_NODE))
^
include/linux/sbitmap.h:153:5: note: 'sbitmap_init_node' declared here
int sbitmap_init_node(struct sbitmap *sb, unsigned int depth, int shift,
^
2 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for HOTPLUG_CPU
Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE
Selected by
- PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP
vim +1515 drivers/vhost/scsi.c
25b98b64e28423b0 Mike Christie 2020-11-09 1503
25b98b64e28423b0 Mike Christie 2020-11-09 1504 static int vhost_scsi_setup_vq_cmds(struct vhost_virtqueue *vq, int max_cmds)
25b98b64e28423b0 Mike Christie 2020-11-09 1505 {
25b98b64e28423b0 Mike Christie 2020-11-09 1506 struct vhost_scsi_virtqueue *svq = container_of(vq,
25b98b64e28423b0 Mike Christie 2020-11-09 1507 struct vhost_scsi_virtqueue, vq);
25b98b64e28423b0 Mike Christie 2020-11-09 1508 struct vhost_scsi_cmd *tv_cmd;
25b98b64e28423b0 Mike Christie 2020-11-09 1509 unsigned int i;
25b98b64e28423b0 Mike Christie 2020-11-09 1510
25b98b64e28423b0 Mike Christie 2020-11-09 1511 if (svq->scsi_cmds)
25b98b64e28423b0 Mike Christie 2020-11-09 1512 return 0;
25b98b64e28423b0 Mike Christie 2020-11-09 1513
25b98b64e28423b0 Mike Christie 2020-11-09 1514 if (sbitmap_init_node(&svq->scsi_tags, max_cmds, -1, GFP_KERNEL,
25b98b64e28423b0 Mike Christie 2020-11-09 @1515 NUMA_NO_NODE))
25b98b64e28423b0 Mike Christie 2020-11-09 1516 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1517 svq->max_cmds = max_cmds;
25b98b64e28423b0 Mike Christie 2020-11-09 1518
25b98b64e28423b0 Mike Christie 2020-11-09 1519 svq->scsi_cmds = kcalloc(max_cmds, sizeof(*tv_cmd), GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1520 if (!svq->scsi_cmds) {
25b98b64e28423b0 Mike Christie 2020-11-09 1521 sbitmap_free(&svq->scsi_tags);
25b98b64e28423b0 Mike Christie 2020-11-09 1522 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1523 }
25b98b64e28423b0 Mike Christie 2020-11-09 1524
25b98b64e28423b0 Mike Christie 2020-11-09 1525 for (i = 0; i < max_cmds; i++) {
25b98b64e28423b0 Mike Christie 2020-11-09 1526 tv_cmd = &svq->scsi_cmds[i];
25b98b64e28423b0 Mike Christie 2020-11-09 1527
25b98b64e28423b0 Mike Christie 2020-11-09 1528 tv_cmd->tvc_sgl = kcalloc(VHOST_SCSI_PREALLOC_SGLS,
25b98b64e28423b0 Mike Christie 2020-11-09 1529 sizeof(struct scatterlist),
25b98b64e28423b0 Mike Christie 2020-11-09 1530 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1531 if (!tv_cmd->tvc_sgl) {
25b98b64e28423b0 Mike Christie 2020-11-09 1532 pr_err("Unable to allocate tv_cmd->tvc_sgl\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1533 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1534 }
25b98b64e28423b0 Mike Christie 2020-11-09 1535
25b98b64e28423b0 Mike Christie 2020-11-09 1536 tv_cmd->tvc_upages = kcalloc(VHOST_SCSI_PREALLOC_UPAGES,
25b98b64e28423b0 Mike Christie 2020-11-09 1537 sizeof(struct page *),
25b98b64e28423b0 Mike Christie 2020-11-09 1538 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1539 if (!tv_cmd->tvc_upages) {
25b98b64e28423b0 Mike Christie 2020-11-09 1540 pr_err("Unable to allocate tv_cmd->tvc_upages\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1541 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1542 }
25b98b64e28423b0 Mike Christie 2020-11-09 1543
25b98b64e28423b0 Mike Christie 2020-11-09 1544 tv_cmd->tvc_prot_sgl = kcalloc(VHOST_SCSI_PREALLOC_PROT_SGLS,
25b98b64e28423b0 Mike Christie 2020-11-09 1545 sizeof(struct scatterlist),
25b98b64e28423b0 Mike Christie 2020-11-09 1546 GFP_KERNEL);
25b98b64e28423b0 Mike Christie 2020-11-09 1547 if (!tv_cmd->tvc_prot_sgl) {
25b98b64e28423b0 Mike Christie 2020-11-09 1548 pr_err("Unable to allocate tv_cmd->tvc_prot_sgl\n");
25b98b64e28423b0 Mike Christie 2020-11-09 1549 goto out;
25b98b64e28423b0 Mike Christie 2020-11-09 1550 }
25b98b64e28423b0 Mike Christie 2020-11-09 1551 }
25b98b64e28423b0 Mike Christie 2020-11-09 1552 return 0;
25b98b64e28423b0 Mike Christie 2020-11-09 1553 out:
25b98b64e28423b0 Mike Christie 2020-11-09 1554 vhost_scsi_destroy_vq_cmds(vq);
25b98b64e28423b0 Mike Christie 2020-11-09 1555 return -ENOMEM;
25b98b64e28423b0 Mike Christie 2020-11-09 1556 }
25b98b64e28423b0 Mike Christie 2020-11-09 1557
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44539 bytes --]
next prev parent reply other threads:[~2021-01-18 4:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 0:49 [PATCH V6 00/13] blk-mq/scsi: tracking device queue depth via sbitmap Ming Lei
2021-01-18 0:49 ` [PATCH V6 01/13] sbitmap: remove sbitmap_clear_bit_unlock Ming Lei
2021-01-18 0:49 ` [PATCH V6 02/13] sbitmap: maintain allocation round_robin in sbitmap Ming Lei
2021-01-18 4:28 ` kernel test robot
2021-01-18 4:28 ` kernel test robot
2021-01-18 4:42 ` kernel test robot [this message]
2021-01-18 4:42 ` kernel test robot
2021-01-22 2:38 ` Ming Lei
2021-01-22 2:38 ` Ming Lei
2021-01-18 0:49 ` [PATCH V6 03/13] sbitmap: add helpers for updating allocation hint Ming Lei
2021-01-18 0:49 ` [PATCH V6 04/13] sbitmap: move allocation hint into sbitmap Ming Lei
2021-01-18 0:49 ` [PATCH V6 05/13] sbitmap: export sbitmap_weight Ming Lei
2021-01-18 0:49 ` [PATCH V6 06/13] sbitmap: add helper of sbitmap_calculate_shift Ming Lei
2021-01-18 0:49 ` [PATCH V6 07/13] blk-mq: add callbacks for storing & retrieving budget token Ming Lei
2021-01-18 0:49 ` [PATCH V6 08/13] blk-mq: return budget token from .get_budget callback Ming Lei
2021-01-18 0:49 ` [PATCH V6 09/13] scsi: put hot fields of scsi_host_template into one cacheline Ming Lei
2021-01-18 0:49 ` [PATCH V6 10/13] megaraid_sas: v2 replace sdev_busy with local counter Ming Lei
2021-01-18 0:49 ` [PATCH V6 11/13] scsi: add scsi_device_busy() to read sdev->device_busy Ming Lei
2021-01-18 0:49 ` [PATCH V6 12/13] scsi: make sure sdev->queue_depth is <= max(shost->can_queue, 1024) Ming Lei
2021-01-18 0:49 ` [PATCH V6 13/13] scsi: replace sdev->device_busy with sbitmap Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101181225.2uTanVzh-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=clang-built-linux@googlegroups.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=kashyap.desai@broadcom.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=sumanesh.samanta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.