* [PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD
@ 2020-11-05 0:29 Heinrich Schuchardt
2020-11-11 14:32 ` Simon Glass
2021-01-18 12:59 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2020-11-05 0:29 UTC (permalink / raw)
To: u-boot
The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y.
Add a build dependency.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
test/lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/lib/Makefile b/test/lib/Makefile
index 98a9abf40e..97c11e35a8 100644
--- a/test/lib/Makefile
+++ b/test/lib/Makefile
@@ -7,7 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o
obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o
obj-y += hexdump.o
obj-y += lmb.o
-obj-y += test_print.o
+obj-$(CONFIG_CONSOLE_RECORD) += test_print.o
obj-$(CONFIG_SSCANF) += sscanf.o
obj-y += string.o
obj-$(CONFIG_ERRNO_STR) += test_errno_str.o
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD
2020-11-05 0:29 [PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD Heinrich Schuchardt
@ 2020-11-11 14:32 ` Simon Glass
2021-01-18 12:59 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2020-11-11 14:32 UTC (permalink / raw)
To: u-boot
Hi Heinrich,
On Wed, 4 Nov 2020 at 17:29, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y.
>
> Add a build dependency.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> test/lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
But this is a strange thing to depend on. I wonder if we should add a
Kconfig for this test? I haven't done it so far as I was worried about
a proliferation of Kconfigs.
>
> diff --git a/test/lib/Makefile b/test/lib/Makefile
> index 98a9abf40e..97c11e35a8 100644
> --- a/test/lib/Makefile
> +++ b/test/lib/Makefile
> @@ -7,7 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o
> obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o
> obj-y += hexdump.o
> obj-y += lmb.o
> -obj-y += test_print.o
> +obj-$(CONFIG_CONSOLE_RECORD) += test_print.o
> obj-$(CONFIG_SSCANF) += sscanf.o
> obj-y += string.o
> obj-$(CONFIG_ERRNO_STR) += test_errno_str.o
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD
2020-11-05 0:29 [PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD Heinrich Schuchardt
2020-11-11 14:32 ` Simon Glass
@ 2021-01-18 12:59 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-01-18 12:59 UTC (permalink / raw)
To: u-boot
On Thu, Nov 05, 2020 at 01:29:06AM +0100, Heinrich Schuchardt wrote:
> The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y.
>
> Add a build dependency.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/95511253/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 12:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-05 0:29 [PATCH 1/1] test: test/lib/test_print.c depends on CONSOLE_RECORD Heinrich Schuchardt
2020-11-11 14:32 ` Simon Glass
2021-01-18 12:59 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.