* [PATCH 1/1] mtd: misplaced log.h and dm/devres.h
@ 2021-01-03 15:10 Heinrich Schuchardt
2021-01-07 12:36 ` Simon Glass
2021-01-18 13:02 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-01-03 15:10 UTC (permalink / raw)
To: u-boot
log.h and dm/devres.h are U-Boot includes. So placing them
behind #ifndef __UBOOT__ does not make any sense.
Fixes: f7ae49fc4f36 ("common: Drop log.h from common header")
Fixes: 61b29b826838 ("dm: core: Require users of devres to include the header")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/mtd/mtdcore.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 1a4dec34d9..0d1f94c6cb 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -9,8 +9,6 @@
*/
#ifndef __UBOOT__
-#include <log.h>
-#include <dm/devres.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/ptrace.h>
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] mtd: misplaced log.h and dm/devres.h
2021-01-03 15:10 [PATCH 1/1] mtd: misplaced log.h and dm/devres.h Heinrich Schuchardt
@ 2021-01-07 12:36 ` Simon Glass
2021-01-18 13:02 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-01-07 12:36 UTC (permalink / raw)
To: u-boot
On Sun, 3 Jan 2021 at 08:10, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> log.h and dm/devres.h are U-Boot includes. So placing them
> behind #ifndef __UBOOT__ does not make any sense.
>
> Fixes: f7ae49fc4f36 ("common: Drop log.h from common header")
> Fixes: 61b29b826838 ("dm: core: Require users of devres to include the header")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/mtd/mtdcore.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] mtd: misplaced log.h and dm/devres.h
2021-01-03 15:10 [PATCH 1/1] mtd: misplaced log.h and dm/devres.h Heinrich Schuchardt
2021-01-07 12:36 ` Simon Glass
@ 2021-01-18 13:02 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-01-18 13:02 UTC (permalink / raw)
To: u-boot
On Sun, Jan 03, 2021 at 04:10:45PM +0100, Heinrich Schuchardt wrote:
> log.h and dm/devres.h are U-Boot includes. So placing them
> behind #ifndef __UBOOT__ does not make any sense.
>
> Fixes: f7ae49fc4f36 ("common: Drop log.h from common header")
> Fixes: 61b29b826838 ("dm: core: Require users of devres to include the header")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/315967eb/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-18 13:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-03 15:10 [PATCH 1/1] mtd: misplaced log.h and dm/devres.h Heinrich Schuchardt
2021-01-07 12:36 ` Simon Glass
2021-01-18 13:02 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.