All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Tian Tao <tiantao6@hisilicon.com>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
Date: Wed, 20 Jan 2021 04:57:46 -0500	[thread overview]
Message-ID: <20210120045736-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <81a1817d-a1f5-dfca-550c-3e3f62cf3a9d@redhat.com>

On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
> On 20.01.21 08:50, Jiapeng Zhong wrote:
> > Fix the following coccicheck warnings:
> > 
> > ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> > of 0/1 to bool variable.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> > ---
> >  drivers/virtio/virtio_mem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> > index 9fc9ec4..85a272c 100644
> > --- a/drivers/virtio/virtio_mem.c
> > +++ b/drivers/virtio/virtio_mem.c
> > @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> >  	 * actually in use (e.g., trying to reload the driver).
> >  	 */
> >  	if (vm->plugged_size) {
> > -		vm->unplug_all_required = 1;
> > +		vm->unplug_all_required = true;
> >  		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> >  	}
> >  
> > 
> 
> Hi,
> 
> we already had a fix on the list for quite a while:
> 
> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com

Can't find that one.

> However, looks like Michael queued your patch on the vhost tree instead.
> 
> -- 
> Thanks,
> 
> David / dhildenb

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>,
	jasowang@redhat.com, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, Tian Tao <tiantao6@hisilicon.com>
Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable
Date: Wed, 20 Jan 2021 04:57:46 -0500	[thread overview]
Message-ID: <20210120045736-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <81a1817d-a1f5-dfca-550c-3e3f62cf3a9d@redhat.com>

On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote:
> On 20.01.21 08:50, Jiapeng Zhong wrote:
> > Fix the following coccicheck warnings:
> > 
> > ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment
> > of 0/1 to bool variable.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> > ---
> >  drivers/virtio/virtio_mem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> > index 9fc9ec4..85a272c 100644
> > --- a/drivers/virtio/virtio_mem.c
> > +++ b/drivers/virtio/virtio_mem.c
> > @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> >  	 * actually in use (e.g., trying to reload the driver).
> >  	 */
> >  	if (vm->plugged_size) {
> > -		vm->unplug_all_required = 1;
> > +		vm->unplug_all_required = true;
> >  		dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> >  	}
> >  
> > 
> 
> Hi,
> 
> we already had a fix on the list for quite a while:
> 
> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com

Can't find that one.

> However, looks like Michael queued your patch on the vhost tree instead.
> 
> -- 
> Thanks,
> 
> David / dhildenb


  reply	other threads:[~2021-01-20  9:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  7:50 [PATCH] virtio-mem: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-20  9:40 ` David Hildenbrand
2021-01-20  9:40   ` David Hildenbrand
2021-01-20  9:57   ` Michael S. Tsirkin [this message]
2021-01-20  9:57     ` Michael S. Tsirkin
2021-01-20 10:04     ` David Hildenbrand
2021-01-20 10:04       ` David Hildenbrand
2021-01-20 11:03       ` Michael S. Tsirkin
2021-01-20 11:03         ` Michael S. Tsirkin
2021-01-20 11:14         ` David Hildenbrand
2021-01-20 11:14           ` David Hildenbrand
2021-01-20 11:33           ` Michael S. Tsirkin
2021-01-20 11:33             ` Michael S. Tsirkin
2021-01-20 11:33             ` David Hildenbrand
2021-01-20 11:33               ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120045736-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=abaci-bugfix@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiantao6@hisilicon.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.