All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Keith Busch <Keith.Busch@wdc.com>
Subject: Re: [PATCH v2 1/2] block: introduce zone_write_granularity limit
Date: Wed, 20 Jan 2021 13:36:49 +0100	[thread overview]
Message-ID: <20210120123649.GA3870@lst.de> (raw)
In-Reply-To: <BL0PR04MB65144D0B02939681617B61A8E7A20@BL0PR04MB6514.namprd04.prod.outlook.com>

On Wed, Jan 20, 2021 at 11:00:29AM +0000, Damien Le Moal wrote:
> Hmm. I wanted to keep this limit to 0 for regular devices. If we default to 512,
> regular devices will see that value. They can ignore it of course, but having it
> as 0 makes it clear that it should be ignored.

Hmm.  Maybe we should keep the 0 default and only set it in sd.c.  Then the
query helper can default to the logical block size instead.  That'll just d
o the right thing without changes to most drivers.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <Keith.Busch@wdc.com>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/2] block: introduce zone_write_granularity limit
Date: Wed, 20 Jan 2021 13:36:49 +0100	[thread overview]
Message-ID: <20210120123649.GA3870@lst.de> (raw)
In-Reply-To: <BL0PR04MB65144D0B02939681617B61A8E7A20@BL0PR04MB6514.namprd04.prod.outlook.com>

On Wed, Jan 20, 2021 at 11:00:29AM +0000, Damien Le Moal wrote:
> Hmm. I wanted to keep this limit to 0 for regular devices. If we default to 512,
> regular devices will see that value. They can ignore it of course, but having it
> as 0 makes it clear that it should be ignored.

Hmm.  Maybe we should keep the 0 default and only set it in sd.c.  Then the
query helper can default to the logical block size instead.  That'll just d
o the right thing without changes to most drivers.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-01-20 13:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 13:17 [PATCH v2 0/2] block: add zone write granularity limit Damien Le Moal
2021-01-19 13:17 ` Damien Le Moal
2021-01-19 13:17 ` [PATCH v2 1/2] block: introduce zone_write_granularity limit Damien Le Moal
2021-01-19 13:17   ` Damien Le Moal
2021-01-20 10:10   ` Christoph Hellwig
2021-01-20 10:10     ` Christoph Hellwig
2021-01-20 11:00     ` Damien Le Moal
2021-01-20 11:00       ` Damien Le Moal
2021-01-20 12:36       ` Christoph Hellwig [this message]
2021-01-20 12:36         ` Christoph Hellwig
2021-01-19 13:17 ` [PATCH v2 2/2] block: document zone_append_max_bytes attribute Damien Le Moal
2021-01-19 13:17   ` Damien Le Moal
2021-01-20 10:10   ` Christoph Hellwig
2021-01-20 10:10     ` Christoph Hellwig
2021-01-20 10:07 ` [PATCH v2 0/2] block: add zone write granularity limit Christoph Hellwig
2021-01-20 10:07   ` Christoph Hellwig
2021-01-20 10:42   ` Damien Le Moal
2021-01-20 10:42     ` Damien Le Moal
2021-01-20 10:46   ` Damien Le Moal
2021-01-20 10:46     ` Damien Le Moal
  -- strict thread matches above, loose matches on Subject: below --
2021-01-19  9:38 Damien Le Moal
2021-01-19  9:38 ` [PATCH v2 1/2] block: introduce zone_write_granularity limit Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120123649.GA3870@lst.de \
    --to=hch@lst.de \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=Keith.Busch@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.