All of lore.kernel.org
 help / color / mirror / Atom feed
* [drm-intel:drm-intel-gt-next 29/29] drivers/gpu/drm/i915/gem/i915_gem_wait.c:136 i915_gem_fence_wait_priority() warn: ignoring unreachable code.
@ 2021-01-20  7:39 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-01-20  7:39 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 3566 bytes --]

CC: kbuild-all(a)lists.01.org
CC: intel-gfx(a)lists.freedesktop.org
CC: dri-devel(a)lists.freedesktop.org
TO: Chris Wilson <chris@chris-wilson.co.uk>
CC: "Ville Syrjälä" <ville.syrjala@linux.intel.com>

tree:   git://anongit.freedesktop.org/drm-intel drm-intel-gt-next
head:   f99e67f1b929635655ff8419e36751f3bf44f1ae
commit: f99e67f1b929635655ff8419e36751f3bf44f1ae [29/29] drm/i915/display: Apply interactive priority to explicit flip fences
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
config: x86_64-randconfig-m001-20210120 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_wait.c:136 i915_gem_fence_wait_priority() warn: ignoring unreachable code.

Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_wait.c:205 nsecs_to_jiffies_timeout() warn: should this be a bitwise op?

vim +136 drivers/gpu/drm/i915/gem/i915_gem_wait.c

f99e67f1b92963 Chris Wilson 2021-01-19  116  
f99e67f1b92963 Chris Wilson 2021-01-19  117  void i915_gem_fence_wait_priority(struct dma_fence *fence,
d45a1a533499d3 Chris Wilson 2019-05-28  118  				  const struct i915_sched_attr *attr)
d45a1a533499d3 Chris Wilson 2019-05-28  119  {
f99e67f1b92963 Chris Wilson 2021-01-19  120  	if (dma_fence_is_signaled(fence))
f99e67f1b92963 Chris Wilson 2021-01-19  121  		return;
f99e67f1b92963 Chris Wilson 2021-01-19  122  
f99e67f1b92963 Chris Wilson 2021-01-19  123  	local_bh_disable();
f99e67f1b92963 Chris Wilson 2021-01-19  124  
d45a1a533499d3 Chris Wilson 2019-05-28  125  	/* Recurse once into a fence-array */
d45a1a533499d3 Chris Wilson 2019-05-28  126  	if (dma_fence_is_array(fence)) {
d45a1a533499d3 Chris Wilson 2019-05-28  127  		struct dma_fence_array *array = to_dma_fence_array(fence);
d45a1a533499d3 Chris Wilson 2019-05-28  128  		int i;
d45a1a533499d3 Chris Wilson 2019-05-28  129  
d45a1a533499d3 Chris Wilson 2019-05-28  130  		for (i = 0; i < array->num_fences; i++)
f99e67f1b92963 Chris Wilson 2021-01-19  131  			fence_set_priority(array->fences[i], attr);
f99e67f1b92963 Chris Wilson 2021-01-19  132  	} else if (__dma_fence_is_chain(fence)) {
f99e67f1b92963 Chris Wilson 2021-01-19  133  		struct dma_fence *iter;
f99e67f1b92963 Chris Wilson 2021-01-19  134  
f99e67f1b92963 Chris Wilson 2021-01-19  135  		/* The chain is ordered; if we boost the last, we boost all */
f99e67f1b92963 Chris Wilson 2021-01-19 @136  		dma_fence_chain_for_each(iter, fence) {
f99e67f1b92963 Chris Wilson 2021-01-19  137  			fence_set_priority(to_dma_fence_chain(iter)->fence,
f99e67f1b92963 Chris Wilson 2021-01-19  138  					   attr);
f99e67f1b92963 Chris Wilson 2021-01-19  139  			break;
f99e67f1b92963 Chris Wilson 2021-01-19  140  		}
f99e67f1b92963 Chris Wilson 2021-01-19  141  		dma_fence_put(iter);
d45a1a533499d3 Chris Wilson 2019-05-28  142  	} else {
f99e67f1b92963 Chris Wilson 2021-01-19  143  		fence_set_priority(fence, attr);
d45a1a533499d3 Chris Wilson 2019-05-28  144  	}
f99e67f1b92963 Chris Wilson 2021-01-19  145  
f99e67f1b92963 Chris Wilson 2021-01-19  146  	local_bh_enable(); /* kick the tasklets if queues were reprioritised */
d45a1a533499d3 Chris Wilson 2019-05-28  147  }
d45a1a533499d3 Chris Wilson 2019-05-28  148  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34310 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-20  7:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-20  7:39 [drm-intel:drm-intel-gt-next 29/29] drivers/gpu/drm/i915/gem/i915_gem_wait.c:136 i915_gem_fence_wait_priority() warn: ignoring unreachable code kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.