From: Christoph Hellwig <hch@lst.de>
To: Rick Edgecombe <rick.p.edgecombe@intel.com>
Cc: akpm@linux-foundation.org, hch@lst.de, dja@axtens.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmalloc: Separate put pages and flush VM flags
Date: Thu, 21 Jan 2021 08:08:35 +0100 [thread overview]
Message-ID: <20210121070835.GA23327@lst.de> (raw)
In-Reply-To: <20210121014118.31922-1-rick.p.edgecombe@intel.com>
On Wed, Jan 20, 2021 at 05:41:18PM -0800, Rick Edgecombe wrote:
> When VM_MAP_PUT_PAGES was added, it was defined with the same value as
> VM_FLUSH_RESET_PERMS. This doesn't seem like it will cause any big
> functional problems other than some excess flushing for VM_MAP_PUT_PAGES
> allocations.
>
> Redefine VM_MAP_PUT_PAGES to have its own value. Also, move the comment
> and remove whitespace for VM_KASAN such that the flags lower down are less
> likely to be missed in the future.
>
> Fixes: b944afc9d64d ("mm: add a VM_MAP_PUT_PAGES flag for vmap")
> Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
Ooops. Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-01-21 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 1:41 [PATCH] mm/vmalloc: Separate put pages and flush VM flags Rick Edgecombe
2021-01-21 2:44 ` Miaohe Lin
2021-01-21 7:08 ` Christoph Hellwig [this message]
2021-01-21 13:19 ` Matthew Wilcox
2021-01-21 23:57 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121070835.GA23327@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rick.p.edgecombe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.