All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org,
	Carl Huang <cjhuang@codeaurora.org>,
	ath11k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mhi: use irq_flags if controller driver configures it
Date: Thu, 21 Jan 2021 13:22:42 +0530	[thread overview]
Message-ID: <20210121075242.GB30041@thinkpad> (raw)
In-Reply-To: <87o8hti8t8.fsf@codeaurora.org>

On Wed, Jan 13, 2021 at 09:40:19AM +0200, Kalle Valo wrote:
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> 
> > On Mon, Jan 04, 2021 at 06:11:28PM +0800, Carl Huang wrote:
> >> If controller driver has specified the irq_flags, mhi uses this specified
> >> irq_flags. Otherwise, mhi uses default irq_flags.
> >> 
> >> The purpose of this change is to support one MSI vector for QCA6390.
> >> MHI will use one same MSI vector too in this scenario.
> >> 
> >> In case of one MSI vector, IRQ_NO_BALANCING is needed when irq handler
> >> is requested. The reason is if irq migration happens, the msi_data may
> >> change too. However, the msi_data is already programmed to QCA6390
> >> hardware during initialization phase. This msi_data inconsistence will
> >> result in crash in kernel.
> >> 
> >> Another issue is in case of one MSI vector, IRQF_NO_SUSPEND will trigger
> >> WARNINGS because QCA6390 wants to disable the IRQ during the suspend.
> >> 
> >> To avoid above two issues, QCA6390 driver specifies the irq_flags in case
> >> of one MSI vector when mhi_register_controller is called.
> >> 
> >> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>
> >> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > Applied to mhi-next!
> 
> Would it be possible again to have an immutable branch for this commit?
> We need it for implementing one MHI support to ath11k[1] required by
> Dell XPS 13 9310 laptops, which a lot of people are waiting. Otherwise I
> can only apply the feature for v5.13, which will be released on July.
> 

Dropped this patch from mhi-next and applied to mhi-ath11k-immutable branch:
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-ath11k-immutable

This branch will also be merged into mhi-next.

Thanks,
Mani

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Carl Huang <cjhuang@codeaurora.org>,
	hemantk@codeaurora.org, ath11k@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3] mhi: use irq_flags if controller driver configures it
Date: Thu, 21 Jan 2021 13:22:42 +0530	[thread overview]
Message-ID: <20210121075242.GB30041@thinkpad> (raw)
In-Reply-To: <87o8hti8t8.fsf@codeaurora.org>

On Wed, Jan 13, 2021 at 09:40:19AM +0200, Kalle Valo wrote:
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> 
> > On Mon, Jan 04, 2021 at 06:11:28PM +0800, Carl Huang wrote:
> >> If controller driver has specified the irq_flags, mhi uses this specified
> >> irq_flags. Otherwise, mhi uses default irq_flags.
> >> 
> >> The purpose of this change is to support one MSI vector for QCA6390.
> >> MHI will use one same MSI vector too in this scenario.
> >> 
> >> In case of one MSI vector, IRQ_NO_BALANCING is needed when irq handler
> >> is requested. The reason is if irq migration happens, the msi_data may
> >> change too. However, the msi_data is already programmed to QCA6390
> >> hardware during initialization phase. This msi_data inconsistence will
> >> result in crash in kernel.
> >> 
> >> Another issue is in case of one MSI vector, IRQF_NO_SUSPEND will trigger
> >> WARNINGS because QCA6390 wants to disable the IRQ during the suspend.
> >> 
> >> To avoid above two issues, QCA6390 driver specifies the irq_flags in case
> >> of one MSI vector when mhi_register_controller is called.
> >> 
> >> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>
> >> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > Applied to mhi-next!
> 
> Would it be possible again to have an immutable branch for this commit?
> We need it for implementing one MHI support to ath11k[1] required by
> Dell XPS 13 9310 laptops, which a lot of people are waiting. Otherwise I
> can only apply the feature for v5.13, which will be released on July.
> 

Dropped this patch from mhi-next and applied to mhi-ath11k-immutable branch:
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-ath11k-immutable

This branch will also be merged into mhi-next.

Thanks,
Mani

  reply	other threads:[~2021-01-21  7:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 10:11 [PATCH v3] mhi: use irq_flags if controller driver configures it Carl Huang
2021-01-04 10:11 ` Carl Huang
2021-01-04 17:03 ` Manivannan Sadhasivam
2021-01-04 17:03   ` Manivannan Sadhasivam
2021-01-13  7:40   ` Kalle Valo
2021-01-13  7:40     ` Kalle Valo
2021-01-21  7:52     ` Manivannan Sadhasivam [this message]
2021-01-21  7:52       ` Manivannan Sadhasivam
2021-01-26 10:14       ` Kalle Valo
2021-01-26 10:14         ` Kalle Valo
2021-01-26 15:42         ` Manivannan Sadhasivam
2021-01-26 15:42           ` Manivannan Sadhasivam
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121075242.GB30041@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=ath11k@lists.infradead.org \
    --cc=cjhuang@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.