From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
David Miller <davem@davemloft.net>,
Dinh Nguyen <dinguyen@kernel.org>,
Brandon Streiff <brandon.streiff@ni.com>,
Marc Zyngier <maz@kernel.org>, Olof Johansson <olof@lixom.net>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.
Date: Thu, 21 Jan 2021 10:27:54 +0000 [thread overview]
Message-ID: <20210121102753.GO1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <1069fecd4b7e13485839e1c66696c5a6c70f6144.1611198584.git.richardcochran@gmail.com>
On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> The mvpp2 is an Ethernet driver, and it implements MAC style time
> stamping of PTP frames. It has no need of the expensive option to
> enable PHY time stamping. Remove the incorrect dependency.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")
NAK.
> ---
> drivers/net/ethernet/marvell/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index 41815b609569..7fe15a3286f4 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -94,7 +94,6 @@ config MVPP2
>
> config MVPP2_PTP
> bool "Marvell Armada 8K Enable PTP support"
> - depends on NETWORK_PHY_TIMESTAMPING
> depends on (PTP_1588_CLOCK = y && MVPP2 = y) || \
> (PTP_1588_CLOCK && MVPP2 = m)
>
> --
> 2.20.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Marc Zyngier <maz@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Brandon Streiff <brandon.streiff@ni.com>,
Olof Johansson <olof@lixom.net>, Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.
Date: Thu, 21 Jan 2021 10:27:54 +0000 [thread overview]
Message-ID: <20210121102753.GO1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <1069fecd4b7e13485839e1c66696c5a6c70f6144.1611198584.git.richardcochran@gmail.com>
On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:
> The mvpp2 is an Ethernet driver, and it implements MAC style time
> stamping of PTP frames. It has no need of the expensive option to
> enable PHY time stamping. Remove the incorrect dependency.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")
NAK.
> ---
> drivers/net/ethernet/marvell/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index 41815b609569..7fe15a3286f4 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -94,7 +94,6 @@ config MVPP2
>
> config MVPP2_PTP
> bool "Marvell Armada 8K Enable PTP support"
> - depends on NETWORK_PHY_TIMESTAMPING
> depends on (PTP_1588_CLOCK = y && MVPP2 = y) || \
> (PTP_1588_CLOCK && MVPP2 = m)
>
> --
> 2.20.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-01-21 10:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 4:05 [PATCH net 0/4] Remove unneeded PHY time stamping option Richard Cochran
2021-01-21 4:05 ` Richard Cochran
2021-01-21 4:06 ` [PATCH net 1/4] net: dsa: mv88e6xxx: Remove bogus Kconfig dependency Richard Cochran
2021-01-21 4:06 ` Richard Cochran
2021-01-21 19:59 ` Brandon Streiff
2021-01-21 19:59 ` Brandon Streiff
2021-01-21 4:06 ` [PATCH net 2/4] net: mvpp2: Remove unneeded " Richard Cochran
2021-01-21 4:06 ` Richard Cochran
2021-01-21 10:27 ` Russell King - ARM Linux admin [this message]
2021-01-21 10:27 ` Russell King - ARM Linux admin
2021-01-21 15:08 ` Richard Cochran
2021-01-21 15:08 ` Richard Cochran
2021-01-23 2:14 ` Jakub Kicinski
2021-01-23 2:14 ` Jakub Kicinski
2021-01-23 9:39 ` Russell King - ARM Linux admin
2021-01-23 9:39 ` Russell King - ARM Linux admin
2021-01-23 13:26 ` Richard Cochran
2021-01-23 13:26 ` Richard Cochran
2021-01-23 20:12 ` Jakub Kicinski
2021-01-23 20:12 ` Jakub Kicinski
2021-01-23 21:14 ` Richard Cochran
2021-01-23 21:14 ` Richard Cochran
2021-01-23 21:38 ` Jakub Kicinski
2021-01-23 21:38 ` Jakub Kicinski
2021-01-21 4:06 ` [PATCH net 3/4] ARM: socfpga_defconfig: Disable PHY time stamping by default Richard Cochran
2021-01-21 4:06 ` Richard Cochran
2021-01-21 4:06 ` [PATCH net 4/4] ARM: axm55xx_defconfig: " Richard Cochran
2021-01-21 4:06 ` Richard Cochran
2021-01-21 15:10 ` [PATCH net 0/4] Remove unneeded PHY time stamping option Richard Cochran
2021-01-21 15:10 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121102753.GO1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=brandon.streiff@ni.com \
--cc=davem@davemloft.net \
--cc=dinguyen@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.