All of lore.kernel.org
 help / color / mirror / Atom feed
* [drm-drm-misc:drm-misc-next 1/1] drivers/gpu/drm/ttm/ttm_device.c:39:1: sparse: sparse: symbol 'ttm_global_mutex' was not declared. Should it be
@ 2021-01-21 17:53 kernel test robot
  2021-01-21 17:53 ` [RFC PATCH drm-drm-misc] drm/ttm: ttm_global_mutex can be static kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-01-21 17:53 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

tree:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
head:   8af8a109b34fa88b8b91f25d11485b37d37549c3
commit: 8af8a109b34fa88b8b91f25d11485b37d37549c3 [1/1] drm/ttm: device naming cleanup
config: x86_64-randconfig-s022-20210121 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        git remote add drm-drm-misc git://anongit.freedesktop.org/drm/drm-misc
        git fetch --no-tags drm-drm-misc drm-misc-next
        git checkout 8af8a109b34fa88b8b91f25d11485b37d37549c3
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/ttm/ttm_device.c:39:1: sparse: sparse: symbol 'ttm_global_mutex' was not declared. Should it be static?
>> drivers/gpu/drm/ttm/ttm_device.c:40:10: sparse: sparse: symbol 'ttm_glob_use_count' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35301 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH drm-drm-misc] drm/ttm: ttm_global_mutex can be static
  2021-01-21 17:53 [drm-drm-misc:drm-misc-next 1/1] drivers/gpu/drm/ttm/ttm_device.c:39:1: sparse: sparse: symbol 'ttm_global_mutex' was not declared. Should it be kernel test robot
@ 2021-01-21 17:53 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-01-21 17:53 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]


Fixes: 8af8a109b34f ("drm/ttm: device naming cleanup")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 ttm_device.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c
index ac0903c9e60ae79..9dee362390f7ed2 100644
--- a/drivers/gpu/drm/ttm/ttm_device.c
+++ b/drivers/gpu/drm/ttm/ttm_device.c
@@ -36,8 +36,8 @@
 /**
  * ttm_global_mutex - protecting the global state
  */
-DEFINE_MUTEX(ttm_global_mutex);
-unsigned ttm_glob_use_count;
+static DEFINE_MUTEX(ttm_global_mutex);
+static unsigned ttm_glob_use_count;
 struct ttm_global ttm_glob;
 EXPORT_SYMBOL(ttm_glob);
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-21 17:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-21 17:53 [drm-drm-misc:drm-misc-next 1/1] drivers/gpu/drm/ttm/ttm_device.c:39:1: sparse: sparse: symbol 'ttm_global_mutex' was not declared. Should it be kernel test robot
2021-01-21 17:53 ` [RFC PATCH drm-drm-misc] drm/ttm: ttm_global_mutex can be static kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.