All of lore.kernel.org
 help / color / mirror / Atom feed
From: Troy Lee <troy_lee@aspeedtech.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer
Date: Mon, 25 Jan 2021 10:01:19 +0000	[thread overview]
Message-ID: <20210125100119.GA2349720@aspeedtech.com> (raw)
In-Reply-To: <20210123161405.GA50622@roeck-us.net>

Hi Guenter,

The 01/24/2021 00:14, Guenter Roeck wrote:
> On Wed, Jan 13, 2021 at 07:08:48AM +0000, Troy Lee wrote:
> > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
> > 16 FAN tacho channel.
> > 
> > Changes since v1:
> > - fixed review comments
> > - fixed double-looped calculation of div_h and div_l
> > - moving configuration to device tree
> > - register hwmon driver with devm_hwmon_device_register_with_info()
> > 
> > Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> 
> checkpatch says:
> 
> total: 0 errors, 9 warnings, 26 checks, 779 lines checked
> 
> This is a bit much. Please run checkpatch --strict and fix the issues
> it reports. Please also fix the issues reported by 0-day as well as
> the issues reported by the bindings robot, and resubmit.
> 
> Thanks,
> Guenter

I'll fix the WARNINGs and CHECKs.

Thanks,
Troy Lee

WARNING: multiple messages have this Message-ID (diff)
From: Troy Lee <troy_lee@aspeedtech.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>,
	Jonathan Corbet <corbet@lwn.net>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Ryan Chen <ryan_chen@aspeedtech.com>,
	"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT" 
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT" 
	<linux-aspeed@lists.ozlabs.org>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	ChiaWei Wang <chiawei_wang@aspeedtech.com>,
	"leetroy@gmail.com" <leetroy@gmail.com>
Subject: Re: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer
Date: Mon, 25 Jan 2021 10:01:19 +0000	[thread overview]
Message-ID: <20210125100119.GA2349720@aspeedtech.com> (raw)
In-Reply-To: <20210123161405.GA50622@roeck-us.net>

Hi Guenter,

The 01/24/2021 00:14, Guenter Roeck wrote:
> On Wed, Jan 13, 2021 at 07:08:48AM +0000, Troy Lee wrote:
> > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
> > 16 FAN tacho channel.
> > 
> > Changes since v1:
> > - fixed review comments
> > - fixed double-looped calculation of div_h and div_l
> > - moving configuration to device tree
> > - register hwmon driver with devm_hwmon_device_register_with_info()
> > 
> > Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> 
> checkpatch says:
> 
> total: 0 errors, 9 warnings, 26 checks, 779 lines checked
> 
> This is a bit much. Please run checkpatch --strict and fix the issues
> it reports. Please also fix the issues reported by 0-day as well as
> the issues reported by the bindings robot, and resubmit.
> 
> Thanks,
> Guenter

I'll fix the WARNINGs and CHECKs.

Thanks,
Troy Lee

WARNING: multiple messages have this Message-ID (diff)
From: Troy Lee <troy_lee@aspeedtech.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Jean Delvare <jdelvare@suse.com>,
	Ryan Chen <ryan_chen@aspeedtech.com>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-aspeed@lists.ozlabs.org>, Jonathan Corbet <corbet@lwn.net>,
	Andrew Jeffery <andrew@aj.id.au>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"leetroy@gmail.com" <leetroy@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	ChiaWei Wang <chiawei_wang@aspeedtech.com>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer
Date: Mon, 25 Jan 2021 10:01:19 +0000	[thread overview]
Message-ID: <20210125100119.GA2349720@aspeedtech.com> (raw)
In-Reply-To: <20210123161405.GA50622@roeck-us.net>

Hi Guenter,

The 01/24/2021 00:14, Guenter Roeck wrote:
> On Wed, Jan 13, 2021 at 07:08:48AM +0000, Troy Lee wrote:
> > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
> > 16 FAN tacho channel.
> > 
> > Changes since v1:
> > - fixed review comments
> > - fixed double-looped calculation of div_h and div_l
> > - moving configuration to device tree
> > - register hwmon driver with devm_hwmon_device_register_with_info()
> > 
> > Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> 
> checkpatch says:
> 
> total: 0 errors, 9 warnings, 26 checks, 779 lines checked
> 
> This is a bit much. Please run checkpatch --strict and fix the issues
> it reports. Please also fix the issues reported by 0-day as well as
> the issues reported by the bindings robot, and resubmit.
> 
> Thanks,
> Guenter

I'll fix the WARNINGs and CHECKs.

Thanks,
Troy Lee

WARNING: multiple messages have this Message-ID (diff)
From: Troy Lee <troy_lee@aspeedtech.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Jean Delvare <jdelvare@suse.com>,
	Ryan Chen <ryan_chen@aspeedtech.com>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-aspeed@lists.ozlabs.org>, Jonathan Corbet <corbet@lwn.net>,
	Andrew Jeffery <andrew@aj.id.au>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"leetroy@gmail.com" <leetroy@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	ChiaWei Wang <chiawei_wang@aspeedtech.com>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer
Date: Mon, 25 Jan 2021 10:01:19 +0000	[thread overview]
Message-ID: <20210125100119.GA2349720@aspeedtech.com> (raw)
In-Reply-To: <20210123161405.GA50622@roeck-us.net>

Hi Guenter,

The 01/24/2021 00:14, Guenter Roeck wrote:
> On Wed, Jan 13, 2021 at 07:08:48AM +0000, Troy Lee wrote:
> > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and
> > 16 FAN tacho channel.
> > 
> > Changes since v1:
> > - fixed review comments
> > - fixed double-looped calculation of div_h and div_l
> > - moving configuration to device tree
> > - register hwmon driver with devm_hwmon_device_register_with_info()
> > 
> > Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> 
> checkpatch says:
> 
> total: 0 errors, 9 warnings, 26 checks, 779 lines checked
> 
> This is a bit much. Please run checkpatch --strict and fix the issues
> it reports. Please also fix the issues reported by 0-day as well as
> the issues reported by the bindings robot, and resubmit.
> 
> Thanks,
> Guenter

I'll fix the WARNINGs and CHECKs.

Thanks,
Troy Lee

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-25 10:01 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  7:08 [PATCH v2 0/4] hwmon: aspeed2600-pwm-tacho: Add driver support Troy Lee
2021-01-13  7:08 ` Troy Lee
2021-01-13  7:08 ` Troy Lee
2021-01-13  7:08 ` [PATCH v2 1/4] dt-bindings: hwmon: Add Aspeed AST2600 PWM/Fan Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13 15:45   ` Rob Herring
2021-01-13 15:45     ` Rob Herring
2021-01-13 15:45     ` Rob Herring
2021-01-13 15:45     ` Rob Herring
2021-01-14  1:35     ` Troy Lee
2021-01-14  1:35       ` Troy Lee
2021-01-14  1:35       ` Troy Lee
2021-01-14 14:13   ` Rob Herring
2021-01-14 14:13     ` Rob Herring
2021-01-14 14:13     ` Rob Herring
2021-01-14 14:13     ` Rob Herring
2021-01-15  1:46     ` Troy Lee
2021-01-15  1:46       ` Troy Lee
2021-01-15  1:46       ` Troy Lee
2021-01-15  1:46       ` Troy Lee
2021-01-13  7:08 ` [PATCH v2 2/4] hwmon: Add Aspeed AST2600 support Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13  7:08 ` [PATCH v2 3/4] ARM: dts: aspeed: Add Aspeed AST2600 PWM/Fan node in devicetree Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13  7:08 ` [PATCH v2 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13  7:08   ` Troy Lee
2021-01-13  9:46   ` kernel test robot
2021-01-13  9:46     ` kernel test robot
2021-01-13  9:46     ` kernel test robot
2021-01-13  9:48   ` kernel test robot
2021-01-13  9:48     ` kernel test robot
2021-01-14  1:27     ` Troy Lee
2021-01-14  1:27       ` Troy Lee
2021-01-23 16:14   ` Guenter Roeck
2021-01-23 16:14     ` Guenter Roeck
2021-01-23 16:14     ` Guenter Roeck
2021-01-23 16:14     ` Guenter Roeck
2021-01-25 10:01     ` Troy Lee [this message]
2021-01-25 10:01       ` Troy Lee
2021-01-25 10:01       ` Troy Lee
2021-01-25 10:01       ` Troy Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125100119.GA2349720@aspeedtech.com \
    --to=troy_lee@aspeedtech.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.