From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: dsterba@suse.cz, matthias.bgg@kernel.org,
Marek Behun <marek.behun@nic.cz>,
u-boot@lists.denx.de, linux-btrfs@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
Date: Wed, 27 Jan 2021 14:47:58 +0100 [thread overview]
Message-ID: <20210127134758.GA1993@twin.jikos.cz> (raw)
In-Reply-To: <5ae76d50-a52d-6f0e-1f23-335cb32f0371@suse.com>
On Wed, Jan 27, 2021 at 08:14:31PM +0800, Qu Wenruo wrote:
>
>
> On 2021/1/27 下午8:01, David Sterba wrote:
> > On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg@kernel.org wrote:
> >> From: Matthias Brugger <mbrugger@suse.com>
> >>
> >> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> >> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> >> it. This leads to compilation errors:
> >> fs/built-in.o: In function `hash_sha256':
> >> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> >> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> >> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
> >>
> >> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> >
> > So this is a fix for u-boot, got me confused and not for the first time
> > as there's Kconfig and the same fs/btrfs/ directory structure.
> >
> Well, sometimes too unified file structure/code base can also be a problem.
>
> Considering I'm also going to continue cross-porting more code to
> U-boot, any recommendation on this?
> Using different prefix?
If it's a series then please mention u-boot in the cover letter, no need
to change the patches, I'll go check CC if I'm too confused about the
patch.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: u-boot@lists.denx.de
Subject: [PATCH] fs: btrfs: Select SHA256 in Kconfig
Date: Wed, 27 Jan 2021 14:47:58 +0100 [thread overview]
Message-ID: <20210127134758.GA1993@twin.jikos.cz> (raw)
In-Reply-To: <5ae76d50-a52d-6f0e-1f23-335cb32f0371@suse.com>
On Wed, Jan 27, 2021 at 08:14:31PM +0800, Qu Wenruo wrote:
>
>
> On 2021/1/27 ??8:01, David Sterba wrote:
> > On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg at kernel.org wrote:
> >> From: Matthias Brugger <mbrugger@suse.com>
> >>
> >> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> >> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> >> it. This leads to compilation errors:
> >> fs/built-in.o: In function `hash_sha256':
> >> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> >> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> >> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
> >>
> >> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> >
> > So this is a fix for u-boot, got me confused and not for the first time
> > as there's Kconfig and the same fs/btrfs/ directory structure.
> >
> Well, sometimes too unified file structure/code base can also be a problem.
>
> Considering I'm also going to continue cross-porting more code to
> U-boot, any recommendation on this?
> Using different prefix?
If it's a series then please mention u-boot in the cover letter, no need
to change the patches, I'll go check CC if I'm too confused about the
patch.
next prev parent reply other threads:[~2021-01-27 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 9:42 [PATCH] fs: btrfs: Select SHA256 in Kconfig matthias.bgg
2021-01-27 9:42 ` matthias.bgg at kernel.org
2021-01-27 9:46 ` Qu Wenruo
2021-01-27 9:46 ` Qu Wenruo
2021-01-27 12:01 ` David Sterba
2021-01-27 12:01 ` David Sterba
2021-01-27 12:14 ` Qu Wenruo
2021-01-27 12:14 ` Qu Wenruo
2021-01-27 13:47 ` David Sterba [this message]
2021-01-27 13:47 ` David Sterba
2021-01-27 13:57 ` Marek Behun
2021-01-27 13:57 ` Marek Behun
2021-01-30 19:21 ` Tom Rini
2021-01-30 19:21 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127134758.GA1993@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.