All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Carlis <zhangxuezhi3@gmail.com>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
	Deepak R Varma <mh12gx2825@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	oliver.graute@kococonnector.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Stefano Brivio <sbrivio@redhat.com>,
	Colin King <colin.king@canonical.com>,
	zhangxuezhi1@yulong.com
Subject: Re: [PATCH v12] staging: fbtft: add tearing signal detect
Date: Thu, 28 Jan 2021 18:23:52 +0300	[thread overview]
Message-ID: <20210128152352.GH2696@kadam> (raw)
In-Reply-To: <CAHp75Vd=ijxnamuSYuxNLeyhGMCod=HaXWrQ0W0+3QCsQAychg@mail.gmail.com>

On Thu, Jan 28, 2021 at 04:33:02PM +0200, Andy Shevchenko wrote:
> > +               init_completion(&spi_panel_te);
> > +               rc = devm_request_irq(dev,
> 
> > +                                     gpiod_to_irq(par->gpio.te),
> 
> ...and here simply use irq.
> 
> > +                                    spi_panel_te_handler, IRQF_TRIGGER_RISING,
> > +                                    "TE_GPIO", par);
> 
> > +               if (IS_ERR(rc))
> 
> This is wrong. rc is integer no IS_ERR() is required. Ditto for
> PTR_ERR(). Have you even looked for these macros implementations?
> 

Yeah...  It leads to a compile warning:

	warning: passing argument 1 of ‘IS_ERR’ makes pointer from integer without a cast [-Wint-conversion]

regards,
dan carpenter


WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
	Deepak R Varma <mh12gx2825@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	oliver.graute@kococonnector.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Stefano Brivio <sbrivio@redhat.com>,
	Carlis <zhangxuezhi3@gmail.com>,
	Colin King <colin.king@canonical.com>,
	zhangxuezhi1@yulong.com
Subject: Re: [PATCH v12] staging: fbtft: add tearing signal detect
Date: Thu, 28 Jan 2021 18:23:52 +0300	[thread overview]
Message-ID: <20210128152352.GH2696@kadam> (raw)
In-Reply-To: <CAHp75Vd=ijxnamuSYuxNLeyhGMCod=HaXWrQ0W0+3QCsQAychg@mail.gmail.com>

On Thu, Jan 28, 2021 at 04:33:02PM +0200, Andy Shevchenko wrote:
> > +               init_completion(&spi_panel_te);
> > +               rc = devm_request_irq(dev,
> 
> > +                                     gpiod_to_irq(par->gpio.te),
> 
> ...and here simply use irq.
> 
> > +                                    spi_panel_te_handler, IRQF_TRIGGER_RISING,
> > +                                    "TE_GPIO", par);
> 
> > +               if (IS_ERR(rc))
> 
> This is wrong. rc is integer no IS_ERR() is required. Ditto for
> PTR_ERR(). Have you even looked for these macros implementations?
> 

Yeah...  It leads to a compile warning:

	warning: passing argument 1 of ‘IS_ERR’ makes pointer from integer without a cast [-Wint-conversion]

regards,
dan carpenter

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-01-28 15:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 12:53 [PATCH v12] staging: fbtft: add tearing signal detect Carlis
2021-01-28 12:53 ` Carlis
2021-01-28 12:58 ` Greg KH
2021-01-28 12:58   ` Greg KH
2021-01-28 14:33 ` Andy Shevchenko
2021-01-28 14:33   ` Andy Shevchenko
2021-01-28 14:44   ` Andy Shevchenko
2021-01-28 14:44     ` Andy Shevchenko
2021-01-28 15:23   ` Dan Carpenter [this message]
2021-01-28 15:23     ` Dan Carpenter
2021-01-29  5:01   ` carlis
2021-01-29  5:01     ` carlis
2021-01-29 10:23     ` Andy Shevchenko
2021-01-29 10:45       ` Greg Kroah-Hartman
2021-01-29 12:47       ` carlis
2021-01-29 14:01         ` Andy Shevchenko
2021-01-29 12:54       ` carlis
2021-01-29 14:04         ` Andy Shevchenko
2021-01-29 13:56       ` carlis
2021-01-29 14:26         ` Andy Shevchenko
2021-01-30  6:39           ` carlis
2021-01-30  6:39             ` carlis
2021-02-01 17:40             ` Andy Shevchenko
2021-02-01 17:40               ` Andy Shevchenko
2021-02-02  1:52               ` Carlis
2021-02-02  1:52                 ` Carlis
2021-02-15 15:30                 ` Andy Shevchenko
2021-02-15 15:30                   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128152352.GH2696@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mh12gx2825@gmail.com \
    --cc=oliver.graute@kococonnector.com \
    --cc=sbrivio@redhat.com \
    --cc=zhangxuezhi1@yulong.com \
    --cc=zhangxuezhi3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.