All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	devicetree <devicetree@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 4/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller
Date: Fri, 29 Jan 2021 10:12:42 +0000	[thread overview]
Message-ID: <20210129101242.GV1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20dac713-25b7-cddf-cc42-69a834487c71@huawei.com>

On Fri, Jan 29, 2021 at 03:23:27PM +0800, Leizhen (ThunderTown) wrote:
> On 2021/1/28 22:24, Arnd Bergmann wrote:
> > I see that cache-l2x0 uses raw_spin_lock_irqsave() instead of
> > spin_lock_irqsave(), to avoid preemption in the middle of a cache
> > operation. This is probably a good idea here as well.
> 
> I don't think there's any essential difference between the two! I don't know
> if the compiler or tool will do anything extra. I checked the git log of the
> l2x0 driver and it used raw_spin_lock_irqsave() at the beginning. Maybe
> there's a description in 2.6. Since you mentioned this potential risk, I'll
> change it to raw_spin_lock_irqsave.

See bd31b85960a7 ("locking, ARM: Annotate low level hw locks as raw")

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-29 10:14 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16  3:27 [PATCH v5 0/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller Zhen Lei
2021-01-16  3:27 ` Zhen Lei
2021-01-16  3:27 ` [PATCH v5 1/4] ARM: LPAE: Use phys_addr_t instead of unsigned long in outercache hooks Zhen Lei
2021-01-16  3:27   ` Zhen Lei
2021-01-28 14:29   ` Arnd Bergmann
2021-01-28 14:29     ` Arnd Bergmann
2021-01-16  3:27 ` [PATCH v5 2/4] ARM: hisi: add support for Kunpeng50x SoC Zhen Lei
2021-01-16  3:27   ` Zhen Lei
2021-01-28 14:28   ` Arnd Bergmann
2021-01-28 14:28     ` Arnd Bergmann
2021-01-29  8:09     ` Leizhen (ThunderTown)
2021-01-16  3:27 ` [PATCH v5 3/4] dt-bindings: arm: hisilicon: Add binding for Kunpeng L3 cache controller Zhen Lei
2021-01-16  3:27   ` Zhen Lei
2021-01-28 14:25   ` Arnd Bergmann
2021-01-28 14:25     ` Arnd Bergmann
2021-01-16  3:27 ` [PATCH v5 4/4] ARM: Add support for Hisilicon " Zhen Lei
2021-01-16  3:27   ` Zhen Lei
2021-01-28 14:24   ` Arnd Bergmann
2021-01-28 14:24     ` Arnd Bergmann
2021-01-29  7:23     ` Leizhen (ThunderTown)
2021-01-29  7:23       ` Leizhen (ThunderTown)
2021-01-29  8:16       ` Arnd Bergmann
2021-01-29 10:26         ` Arnd Bergmann
2021-01-29 10:33           ` Russell King - ARM Linux admin
2021-01-29 10:33             ` Russell King - ARM Linux admin
2021-01-29 10:53             ` Arnd Bergmann
2021-01-29 11:11               ` Russell King - ARM Linux admin
2021-01-30  2:51             ` Leizhen (ThunderTown)
2021-01-30  2:51               ` Leizhen (ThunderTown)
2021-01-29 13:54           ` Leizhen (ThunderTown)
2021-01-30  3:00             ` Leizhen (ThunderTown)
2021-01-30  3:00               ` Leizhen (ThunderTown)
2021-01-29 13:33         ` Leizhen (ThunderTown)
2021-01-29 10:12       ` Russell King - ARM Linux admin [this message]
2021-01-29 13:33         ` Leizhen (ThunderTown)
2021-01-28  1:30 ` [PATCH v5 0/4] " Leizhen (ThunderTown)
2021-01-28  1:30   ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210129101242.GV1551@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    --cc=will.deacon@arm.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.