Re: [Virtio-fs] [PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Vivek Goyal <vgoyal@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: mst@redhat.com, qemu-devel@nongnu.org, virtio-fs@redhat.com,
	marcandre.lureau@redhat.com
Subject: Re: [Virtio-fs] [PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit
Date: Fri, 29 Jan 2021 10:04:15 -0500	[thread overview]
Message-ID: <20210129150415.GC3146@redhat.com> (raw)
In-Reply-To: <20210129130309.1e769bdc@bahia.lan>

On Fri, Jan 29, 2021 at 01:03:09PM +0100, Greg Kurz wrote:
> On Tue, 26 Jan 2021 13:33:36 -0500
> Vivek Goyal <vgoyal@redhat.com> wrote:
> 
> [...]
>  
> > > 
> > > Also, since pthread_rwlock_wrlock() can fail, I think we should
> > > always check it's return value, at least with an assert() like
> > > already done elsewhere.
> > 
> > Will check return code of pthread_rwlock_wrlock() and probably use
> > assert().
> > 
> 
> It turns out that pthread_rwlock_rdlock() and pthread_rwlock_unlock() can
> also fail for various reasons that would likely indicate a programming
> error, but their return values are never checked anywhere.
> 
> I have a patch to address this globally in this file. Should I post it
> now or you prefer this series goes first ?

Please go ahead and post your patch. Your patch can go first and I can
rebase my patches on top of yours.

Vivek

WARNING: multiple messages have this Message-ID (diff)

From: Vivek Goyal <vgoyal@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: mst@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com,
	virtio-fs@redhat.com, stefanha@redhat.com,
	marcandre.lureau@redhat.com
Subject: Re: [PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit
Date: Fri, 29 Jan 2021 10:04:15 -0500	[thread overview]
Message-ID: <20210129150415.GC3146@redhat.com> (raw)
In-Reply-To: <20210129130309.1e769bdc@bahia.lan>

On Fri, Jan 29, 2021 at 01:03:09PM +0100, Greg Kurz wrote:
> On Tue, 26 Jan 2021 13:33:36 -0500
> Vivek Goyal <vgoyal@redhat.com> wrote:
> 
> [...]
>  
> > > 
> > > Also, since pthread_rwlock_wrlock() can fail, I think we should
> > > always check it's return value, at least with an assert() like
> > > already done elsewhere.
> > 
> > Will check return code of pthread_rwlock_wrlock() and probably use
> > assert().
> > 
> 
> It turns out that pthread_rwlock_rdlock() and pthread_rwlock_unlock() can
> also fail for various reasons that would likely indicate a programming
> error, but their return values are never checked anywhere.
> 
> I have a patch to address this globally in this file. Should I post it
> now or you prefer this series goes first ?

Please go ahead and post your patch. Your patch can go first and I can
rebase my patches on top of yours.

Vivek

next prev parent reply	other threads:[~2021-01-29 15:04 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 18:01 [Virtio-fs] [RFC PATCH 0/6] vhost-user: Shutdown/Flush slave channel properly Vivek Goyal
2021-01-25 18:01 ` Vivek Goyal
2021-01-25 18:01 ` [Virtio-fs] [PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit Vivek Goyal
2021-01-25 18:01   ` Vivek Goyal
2021-01-26 15:56   ` [Virtio-fs] " Greg Kurz
2021-01-26 15:56     ` Greg Kurz
2021-01-26 18:33     ` [Virtio-fs] " Vivek Goyal
2021-01-26 18:33       ` Vivek Goyal
2021-01-29 12:03       ` [Virtio-fs] " Greg Kurz
2021-01-29 12:03         ` Greg Kurz
2021-01-29 15:04         ` Vivek Goyal [this message]
2021-01-29 15:04           ` Vivek Goyal
2021-01-25 18:01 ` [Virtio-fs] [PATCH 2/6] libvhost-user: Use slave_mutex in all slave messages Vivek Goyal
2021-01-25 18:01   ` Vivek Goyal
2021-01-28 14:31   ` [Virtio-fs] " Greg Kurz
2021-01-28 14:31     ` Greg Kurz
2021-01-28 14:48     ` [Virtio-fs] " Vivek Goyal
2021-01-28 14:48       ` Vivek Goyal
2021-01-28 15:06       ` [Virtio-fs] " Greg Kurz
2021-01-28 15:06         ` Greg Kurz
2021-01-25 18:01 ` [Virtio-fs] [PATCH 3/6] vhost-user: Return error code from slave_read() Vivek Goyal
2021-01-25 18:01   ` Vivek Goyal
2021-01-29  9:45   ` [Virtio-fs] " Greg Kurz
2021-01-29  9:45     ` Greg Kurz
2021-01-29 15:02     ` [Virtio-fs] " Vivek Goyal
2021-01-29 15:02       ` Vivek Goyal
2021-01-25 18:01 ` [Virtio-fs] [PATCH 4/6] qemu, vhost-user: Extend protocol to start/stop/flush slave channel Vivek Goyal
2021-01-25 18:01   ` Vivek Goyal
2021-01-28 16:52   ` [Virtio-fs] " Stefan Hajnoczi
2021-01-28 16:52     ` Stefan Hajnoczi
2021-01-29 14:16     ` [Virtio-fs] " Vivek Goyal
2021-01-29 14:16       ` Vivek Goyal
2021-01-29 15:11       ` [Virtio-fs] " Vivek Goyal
2021-01-29 15:11         ` Vivek Goyal
2021-02-08 17:41         ` [Virtio-fs] " Stefan Hajnoczi
2021-02-08 17:41           ` Stefan Hajnoczi
2021-01-25 18:01 ` [Virtio-fs] [PATCH 5/6] libvhost-user: Add support " Vivek Goyal
2021-01-25 18:01   ` Vivek Goyal
2021-01-25 18:01 ` [Virtio-fs] [PATCH 6/6] virtiofsd: Opt in for slave start/stop/shutdown functionality Vivek Goyal
2021-01-25 18:01   ` Vivek Goyal
2021-02-10 21:39 ` [Virtio-fs] [RFC PATCH 0/6] vhost-user: Shutdown/Flush slave channel properly Michael S. Tsirkin
2021-02-10 21:39   ` Michael S. Tsirkin
2021-02-10 22:15   ` [Virtio-fs] " Vivek Goyal
2021-02-10 22:15     ` Vivek Goyal
2021-02-23 14:14 ` [Virtio-fs] " Michael S. Tsirkin
2021-02-23 14:14   ` Michael S. Tsirkin
2021-02-23 14:23   ` [Virtio-fs] " Vivek Goyal
2021-02-23 14:23     ` Vivek Goyal
2021-03-14 22:21 ` [Virtio-fs] " Michael S. Tsirkin
2021-03-14 22:21   ` Michael S. Tsirkin
2021-03-14 22:26   ` [Virtio-fs] " Vivek Goyal
2021-03-14 22:26     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210129150415.GC3146@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=groug@kaod.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.