From: Mike Rapoport <rppt@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
Michal Hocko <mhocko@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>, Qian Cai <cai@lca.pw>,
Thomas Gleixner <tglx@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org
Subject: Re: [PATCH v3 2/2] mm: fix initialization of struct page for holes in memory layout
Date: Mon, 1 Feb 2021 16:12:22 +0200 [thread overview]
Message-ID: <20210201141222.GH242749@kernel.org> (raw)
In-Reply-To: <20210201093958.GD28734@MiWiFi-R3L-srv>
On Mon, Feb 01, 2021 at 05:39:58PM +0800, Baoquan He wrote:
> On 02/01/21 at 10:14am, David Hildenbrand wrote:
> > On 11.01.21 20:40, Mike Rapoport wrote:
> > > +
> > > +static void __init init_unavailable_mem(void)
> > > +{
> > > + int zone;
> > > +
> > > + for (zone = 0; zone < ZONE_MOVABLE; zone++)
> > > + init_zone_unavailable_mem(zone);
> >
> > Why < ZONE_MOVABLE?
> >
> > I remember we can have memory holes inside the movable zone when messing
> > with "movablecore" cmdline parameter.
>
> Maybe because we haven't initialized MOABLE zone info at this time.
We already have zone_movable_pfn initialized at this point.
So if there is a possibility for holes in the movable zone, we should take
care of it.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-02-01 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 19:40 [PATCH v3 0/2] mm: fix initialization of struct page for holes in memory layout Mike Rapoport
2021-01-11 19:40 ` [PATCH v3 1/2] x86/setup: don't remove E820_TYPE_RAM for pfn 0 Mike Rapoport
2021-01-13 8:56 ` Oscar Salvador
2021-01-13 11:23 ` Mike Rapoport
2021-01-13 12:56 ` David Hildenbrand
2021-01-13 15:35 ` Mike Rapoport
2021-01-21 13:25 ` Borislav Petkov
2021-01-11 19:40 ` [PATCH v3 2/2] mm: fix initialization of struct page for holes in memory layout Mike Rapoport
2021-02-01 9:14 ` David Hildenbrand
2021-02-01 9:39 ` Baoquan He
2021-02-01 14:12 ` Mike Rapoport [this message]
2021-01-12 0:58 ` [PATCH v3 0/2] " Andrew Morton
2021-01-12 5:25 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201141222.GH242749@kernel.org \
--to=rppt@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.