Re: [PATCH v3 0/5] amba: minor fix and various cleanups - Russell King

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	kvm@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	dri-devel@lists.freedesktop.org, "Eric Anholt" <eric@anholt.net>,
	"Uwe Kleine-König" <u.kleine-koenig.org@pengutronix.de>,
	linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
	"Jiri Slaby" <jirislaby@kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	linux-rtc@vger.kernel.org,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
	linux-serial@vger.kernel.org, linux-input@vger.kernel.org,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Mike Leach" <mike.leach@linaro.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Suzuki K Poulose" <suzuki.poulose@arm.com>,
	coresight@lists.linaro.org, "Vladimir Zapolskiy" <vz@mleia.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-fbdev@vger.kernel.org, "Matt Mackall" <mpm@selenic.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	linux-watchdog@vger.kernel.org,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	linux-mmc@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
	linux-kernel@vger.kernel.org, "Vinod Koul" <vkoul@kernel.org>,
	linux-crypto@vger.kernel.org,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Leo Yan" <leo.yan@linaro.org>,
	dmaengine@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 0/5] amba: minor fix and various cleanups
Date: Tue, 2 Feb 2021 10:49:15 +0000	[thread overview]
Message-ID: <20210202104915.GK1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210126165835.687514-1-u.kleine-koenig@pengutronix.de>

On Tue, Jan 26, 2021 at 05:58:30PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig.org@pengutronix.de
> 
> Hello,
> 
> Changes since v2 sent with Message-Id:
> 20201124133139.3072124-1-uwe@kleine-koenig.org:
> 
>  - Rebase to v5.11-rc1 (which resulted in a few conflicts in
>    drivers/hwtracing).
>  - Add various Acks.
>  - Send to more maintainers directly (which I think is one of the
>    reasons why there are so few Acks).
> 
> For my taste patch 4 needs some more acks (drivers/char/hw_random,
> drivers/dma, drivers/gpu/drm/pl111, drivers/i2c, drivers/mmc,
> drivers/vfio, drivers/watchdog and sound/arm have no maintainer feedback
> yet).
> 
> My suggestion is to let this series go in via Russell King (who cares
> for amba). Once enough Acks are there I can also provide a tag for
> merging into different trees. Just tell me if you prefer this solution.
> 
> Would be great if this could make it for v5.12, but I'm aware it's
> already late in the v5.11 cycle so it might have to wait for v5.13.

I think you need to have a 6th patch which moves the
probe/remove/shutdown methods into the bus_type - if you're setting
them for every struct device_driver, then there's no point doing that
and they may as well be in the bus_type.

Apart from that, it looks good.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!